Skip to content

chore: cherry-pick #8504#8507

Merged
brianacnguyen merged 1 commit into
release/7.16.0from
chore/cherry-pick-8504
Feb 1, 2024
Merged

chore: cherry-pick #8504#8507
brianacnguyen merged 1 commit into
release/7.16.0from
chore/cherry-pick-8504

Conversation

@github-actions

@github-actions github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

This PR cherry-picks #8504

…ChainApproval (#8504)

## **Description**
- Remove `isFullscreen` from AddAccount, AccountPermissions, and
AddChainApproval so the view can dynamically grow to maxHeight instead
of setting it to maxHeight

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to MM Portfolio
2. Connect to an account
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

https://github.com/MetaMask/metamask-mobile/assets/14355083/c4989789-9a4d-439d-8e21-a247601ed74d

<!-- [screenshots/recordings] -->

### **After**

https://github.com/MetaMask/metamask-mobile/assets/14355083/eb37c70b-e6c9-4aa9-b4d8-48aadcb9fed1

https://github.com/MetaMask/metamask-mobile/assets/14355083/1133ad7f-d098-40ab-b05c-219be50cad3b

https://github.com/MetaMask/metamask-mobile/assets/14355083/5c91f31d-bca3-4c56-aa5c-f835df3bca03


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [ ] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Cal Leung <cleun007@gmail.com>
@brianacnguyen brianacnguyen marked this pull request as ready for review February 1, 2024 18:41
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 1, 2024 18:41
@github-actions

github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/efc93943-42a8-485a-9b9e-681196f519ef
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@brianacnguyen brianacnguyen merged commit e71ee43 into release/7.16.0 Feb 1, 2024
@brianacnguyen brianacnguyen deleted the chore/cherry-pick-8504 branch February 1, 2024 18:43
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 1, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Feb 1, 2024
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.16.0 on PR, as PR was cherry-picked in branch 7.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.16.0 Issue or pull request that will be included in release 7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants