Skip to content

fix: Remove isFullscreen from AddAccount, AccountPermissions, and AddChainApproval#8504

Merged
brianacnguyen merged 3 commits into
mainfrom
fix/fullscreen
Feb 1, 2024
Merged

fix: Remove isFullscreen from AddAccount, AccountPermissions, and AddChainApproval#8504
brianacnguyen merged 3 commits into
mainfrom
fix/fullscreen

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

Description

  • Remove isFullscreen from AddAccount, AccountPermissions, and AddChainApproval so the view can dynamically grow to maxHeight instead of setting it to maxHeight

Related issues

Fixes:

Manual testing steps

  1. Go to MM Portfolio
  2. Connect to an account

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-01.at.09.18.19.mp4

After

https://github.com/MetaMask/metamask-mobile/assets/14355083/eb37c70b-e6c9-4aa9-b4d8-48aadcb9fed1
https://github.com/MetaMask/metamask-mobile/assets/14355083/1133ad7f-d098-40ab-b05c-219be50cad3b
https://github.com/MetaMask/metamask-mobile/assets/14355083/5c91f31d-bca3-4c56-aa5c-f835df3bca03

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Feb 1, 2024
@brianacnguyen brianacnguyen self-assigned this Feb 1, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 1, 2024 17:40
@github-actions

github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen changed the title fix: Remove isFullscreen from AddAccount, AddPermissions, and AddChainApproval fix: Remove isFullscreen from AddAccount, AccountPermissions, and AddChainApproval Feb 1, 2024

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

sonarqubecloud Bot commented Feb 1, 2024

Copy link
Copy Markdown

@brianacnguyen brianacnguyen merged commit ff8e9b0 into main Feb 1, 2024
@brianacnguyen brianacnguyen deleted the fix/fullscreen branch February 1, 2024 18:40
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 1, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 1, 2024
@metamaskbot metamaskbot added release-7.17.0 Issue or pull request that will be included in release 7.17.0 release-7.16.0 Issue or pull request that will be included in release 7.16.0 and removed release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Feb 1, 2024
@metamaskbot

Copy link
Copy Markdown
Collaborator

Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0.

@sethkfman sethkfman added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead type-bug Something isn't working labels Feb 1, 2024
@chrisleewilcox chrisleewilcox added release-7.17.0 Issue or pull request that will be included in release 7.17.0 and removed release-7.16.0 Issue or pull request that will be included in release 7.16.0 regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead labels Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-design-system All issues relating to design system in Mobile type-bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants