Skip to content

chore: cherry-pick #8491#8498

Merged
NicolasMassart merged 1 commit into
release/7.16.0from
chore/cherry-pick-8491
Feb 1, 2024
Merged

chore: cherry-pick #8491#8498
NicolasMassart merged 1 commit into
release/7.16.0from
chore/cherry-pick-8491

Conversation

@github-actions

@github-actions github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

This PR cherry-picks #8491

components

## **Description**
Updated theme tokens in QR-related tokens from this.context.theme to
this.context. This correctly exposes the colors and brandColors needed.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:
https://app.zenhub.com/workspaces/mobile-release-testing-6249e5242464b70013315a98/issues/gh/metamask/mobile-planning/1529

## **Manual testing steps**

1. Go to Wallet
2. Click on Actions
3. Click on Receive

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

https://github.com/MetaMask/metamask-mobile/assets/14355083/215790d9-a758-45bc-82cc-711a767b92f2

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@NicolasMassart NicolasMassart marked this pull request as ready for review February 1, 2024 09:47
@NicolasMassart NicolasMassart requested a review from a team as a code owner February 1, 2024 09:47
@github-actions

github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/37b08974-35f0-42d4-a990-9f4105f239ed
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@NicolasMassart NicolasMassart merged commit c1aebaa into release/7.16.0 Feb 1, 2024
@NicolasMassart NicolasMassart deleted the chore/cherry-pick-8491 branch February 1, 2024 12:04
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 1, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Feb 1, 2024
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.16.0 on PR, as PR was cherry-picked in branch 7.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.16.0 Issue or pull request that will be included in release 7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants