fix: Update theme tokens for QR-related components#8491
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8491 +/- ##
=======================================
Coverage 40.67% 40.67%
=======================================
Files 1240 1240
Lines 30006 30006
Branches 2871 2871
=======================================
Hits 12206 12206
Misses 17101 17101
Partials 699 699 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
components
Description
Updated theme tokens in QR-related tokens from this.context.theme to this.context. This correctly exposes the colors and brandColors needed.
Related issues
Fixes: https://app.zenhub.com/workspaces/mobile-release-testing-6249e5242464b70013315a98/issues/gh/metamask/mobile-planning/1529
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-31.at.14.22.08.mp4
Pre-merge author checklist
Pre-merge reviewer checklist