Skip to content

chore: cherry-pick #8486#8487

Merged
brianacnguyen merged 1 commit into
release/7.16.0from
chore/cherry-pick-8486
Jan 31, 2024
Merged

chore: cherry-pick #8486#8487
brianacnguyen merged 1 commit into
release/7.16.0from
chore/cherry-pick-8486

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR cherry-picks #8486

## **Description**
- Updated theme tokens in General and Advanced Settings from
`this.context.theme` to `this.context`. This correctly exposes the
`colors` and `brandColors` needed.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:
https://app.zenhub.com/workspaces/mobile-release-testing-6249e5242464b70013315a98/issues/gh/metamask/mobile-planning/1527

## **Manual testing steps**

0. Turn on Dark mode
1. Go to Settings
2. Go to General 

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

https://github.com/MetaMask/metamask-mobile/assets/14355083/bded49c2-f68b-4f49-ab8f-b6c1da6dca93


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@sethkfman sethkfman marked this pull request as ready for review January 31, 2024 19:06
@sethkfman sethkfman requested a review from a team as a code owner January 31, 2024 19:06
@github-actions

Copy link
Copy Markdown
Contributor Author

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6a5d0ad3-d3c8-4d4e-9d7f-e5589177fc07
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sethkfman sethkfman added the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Jan 31, 2024
@brianacnguyen brianacnguyen merged commit adc647e into release/7.16.0 Jan 31, 2024
@brianacnguyen brianacnguyen deleted the chore/cherry-pick-8486 branch January 31, 2024 19:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 31, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 31, 2024
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.16.0 on PR, as PR was cherry-picked in branch 7.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.16.0 Issue or pull request that will be included in release 7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants