Skip to content

fix: Update theme tokens for General and Advanced Settings#8486

Merged
brianacnguyen merged 2 commits into
mainfrom
fix/theme-color
Jan 31, 2024
Merged

fix: Update theme tokens for General and Advanced Settings#8486
brianacnguyen merged 2 commits into
mainfrom
fix/theme-color

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

Description

  • Updated theme tokens in General and Advanced Settings from this.context.theme to this.context. This correctly exposes the colors and brandColors needed.

Related issues

Fixes: https://app.zenhub.com/workspaces/mobile-release-testing-6249e5242464b70013315a98/issues/gh/metamask/mobile-planning/1527

Manual testing steps

  1. Turn on Dark mode
  2. Go to Settings
  3. Go to General

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-31.at.10.01.30.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Jan 31, 2024
@brianacnguyen brianacnguyen self-assigned this Jan 31, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner January 31, 2024 18:05
@github-actions

github-actions Bot commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen removed the request for review from frankvonhoven January 31, 2024 18:08
@codecov-commenter

codecov-commenter commented Jan 31, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a201472) 40.67% compared to head (b227137) 40.67%.

Files Patch % Lines
...components/Views/Settings/GeneralSettings/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8486   +/-   ##
=======================================
  Coverage   40.67%   40.67%           
=======================================
  Files        1240     1240           
  Lines       30006    30006           
  Branches     2871     2871           
=======================================
  Hits        12206    12206           
  Misses      17101    17101           
  Partials      699      699

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Jan 31, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
44.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen merged commit 98d705a into main Jan 31, 2024
@brianacnguyen brianacnguyen deleted the fix/theme-color branch January 31, 2024 18:52
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 31, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 31, 2024
@metamaskbot metamaskbot added release-7.17.0 Issue or pull request that will be included in release 7.17.0 release-7.16.0 Issue or pull request that will be included in release 7.16.0 and removed release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Jan 31, 2024
@metamaskbot

metamaskbot commented Jan 31, 2024

Copy link
Copy Markdown
Collaborator

Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0.

@sethkfman sethkfman added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead type-bug Something isn't working labels Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@leotm leotm leotm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brianacnguyen brianacnguyen

Labels

regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-design-system All issues relating to design system in Mobile type-bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brianacnguyen @codecov-commenter @metamaskbot @leotm @sethkfman