Skip to content

fix: OpenSea V1 -> V2 patch#8155

Merged
chrisleewilcox merged 7 commits intorelease/7.12.4from
brian/osv2/release/7.12.4
Dec 19, 2023
Merged

fix: OpenSea V1 -> V2 patch#8155
chrisleewilcox merged 7 commits intorelease/7.12.4from
brian/osv2/release/7.12.4

Conversation

@bergeron
Copy link
Copy Markdown
Contributor

@bergeron bergeron commented Dec 18, 2023

Description

This is a release version of this PR: #8135

Migrate to OpenSea V2 API because V1 is being deprecated. Patches this change from core: MetaMask/core#3654

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1841

Manual testing steps

  1. Import a wallet containing NFTs on mainnet
  2. Manually import an NFT owner by the wallet, verify it appears
  3. Enable NFT autodetection in settings, verify the rest of the NFTs appear
  4. Verify descriptions, collection/token images are correct
  5. Send an NFT, verify it works

Screenshots/Recordings

No visible differences between before and after.

Before

After

Screen.Recording.2023-12-18.at.3.12.54.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • [] I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • [] In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner December 18, 2023 23:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Gudahtt
Gudahtt reviewed Dec 19, 2023
View reviewed changes
@chrisleewilcox
Copy link
Copy Markdown
Contributor

chrisleewilcox commented Dec 19, 2023

@bergeron can you review the comments left by @Gudahtt and the merge conflicts? Hoping to be able to merge later today.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/7.12.4@35ccd23). Click here to learn what that means.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/7.12.4    #8155   +/-   ##
=================================================
  Coverage                  ?   37.39%           
=================================================
  Files                     ?     1052           
  Lines                     ?    28173           
  Branches                  ?     2517           
=================================================
  Hits                      ?    10534           
  Misses                    ?    17040           
  Partials                  ?      599

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 19, 2023 •
edited by chrisleewilcox
Loading

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf6c953e-e771-4876-a815-81d6f253d3dd

Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e065cc34-044d-478b-8fa0-a4715d7b558b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Gudahtt
Gudahtt approved these changes Dec 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chrisleewilcox chrisleewilcox added the release-7.12.4 Issue or pull request that will be included in release 7.12.4 label Dec 19, 2023
@chrisleewilcox chrisleewilcox merged commit c718856 into release/7.12.4 Dec 19, 2023
@chrisleewilcox chrisleewilcox deleted the brian/osv2/release/7.12.4 branch December 19, 2023 22:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

release-7.12.4 Issue or pull request that will be included in release 7.12.4 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bergeron @chrisleewilcox @codecov-commenter @Gudahtt