Skip to content

fix: OpenSea V1 -> V2 patch#8135

Merged
chrisleewilcox merged 9 commits intomainfrom
brian/opensea-v2
Dec 19, 2023
Merged

fix: OpenSea V1 -> V2 patch#8135
chrisleewilcox merged 9 commits intomainfrom
brian/opensea-v2

Conversation

@bergeron
Copy link
Copy Markdown
Contributor

@bergeron bergeron commented Dec 15, 2023 •
edited
Loading

Description

Migrate to OpenSea V2 API because V1 is being deprecated. Patches this change from core: MetaMask/core#3654

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1841

Manual testing steps

  1. Import a wallet containing NFTs on mainnet
  2. Manually import an NFT owner by the wallet, verify it appears
  3. Enable NFT autodetection in settings, verify the rest of the NFTs appear
  4. Verify descriptions, collection/token images are correct
  5. Send an NFT, verify it works

Screenshots/Recordings

No visible differences between before and after.

Before

After

Screen.Recording.2023-12-18.at.3.12.54.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • [] I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • [] In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner December 15, 2023 23:16
@bergeron bergeron requested a review from Cal-L December 15, 2023 23:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 15, 2023 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4be2dc) 39.39% compared to head (7dc1bc6) 39.39%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8135   +/-   ##
=======================================
  Coverage   39.39%   39.39%           
=======================================
  Files        1220     1220           
  Lines       29800    29800           
  Branches     2831     2831           
=======================================
  Hits        11740    11740           
  Misses      17371    17371           
  Partials      689      689

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bergeron
Copy link
Copy Markdown
Contributor Author

bergeron commented Dec 15, 2023

I have read the CLA Document and I hereby sign the CLA

@bergeron bergeron changed the title OpenSea V1 -> V2 patch fix: OpenSea V1 -> V2 patch Dec 18, 2023
Cal-L
Cal-L approved these changes Dec 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/698ffaff-1b0d-4540-aa1a-60683593fe80
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@chrisleewilcox chrisleewilcox added the QA in Progress QA has started on the feature. label Dec 18, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bergeron bergeron mentioned this pull request Dec 18, 2023
Merged
11 tasks
@chrisleewilcox
Copy link
Copy Markdown
Contributor

chrisleewilcox commented Dec 19, 2023

E2E regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dde63266-a680-45f5-8ef2-5e7305b54fd7

@chrisleewilcox chrisleewilcox added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed QA in Progress QA has started on the feature. labels Dec 19, 2023
@chrisleewilcox chrisleewilcox merged commit f1c7e96 into main Dec 19, 2023
@chrisleewilcox chrisleewilcox deleted the brian/opensea-v2 branch December 19, 2023 02:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

release-7.15.0 Issue or pull request that will be included in release 7.15.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bergeron @codecov-commenter @chrisleewilcox @Cal-L @metamaskbot