Merged
Conversation
brunobar79
reviewed
May 2, 2019
Contributor
brunobar79
left a comment
There was a problem hiding this comment.
Code looks good. Question about the UX
app/components/UI/Navbar/index.js
Outdated
| headerStyle: { | ||
| shadowColor: 'transparent', | ||
| elevation: 0, | ||
| backgroundColor: 'white', |
Contributor
Author
There was a problem hiding this comment.
missed this, there are other styles in the same way, will change
| render() { | ||
| return ( | ||
| <SafeAreaView style={styles.root}> | ||
| <ActionView |
Contributor
There was a problem hiding this comment.
I thought we decided the buttons to NOT be sticky. Which will force users to scroll down and read everything before being able to continue.
Contributor
Author
There was a problem hiding this comment.
whops I think in that case I misunderstood, I made it always showing the message
| const onboardingWizard = await AsyncStorage.getItem('@MetaMask:onboardingWizard'); | ||
| if (onboardingWizard) { | ||
| // Check if user passed through metrics opt-in screen | ||
| const metricsOptIn = await AsyncStorage.getItem('@MetaMask:metricsOptIn'); |
Contributor
There was a problem hiding this comment.
Not sure if this one is needed. What would be a case of a user getting to the Login screen without getting through the Opt in first?
Contributor
Author
There was a problem hiding this comment.
This case is in the GIF. If you close the app while in optin screen after importing from seed without remember me option, next time you go to the app you'll start in Login screen, If we don't do this that case won't have the flag selected.
|
|
||
| onPressCreate = () => { | ||
| const { existingUser } = this.state; | ||
| //this.props.navigation.navigate('CreateWallet'); |
Contributor
Author
|
@brunobar79 updated
|
brunobar79
added a commit
that referenced
this pull request
May 25, 2019
* Transaction errors (#550) * wip: showing plain transaction error on screen alert * handle result promise * remove listener in approval * drop package-lock * comments * Add zxcvbn for password strength estimation (#555) * add zxcvbn * use zxcvbn for password estimations * add comments * update snapshot * navar title numberoflines 1 (#557) * Reduce instances of cached contract addresses (#547) Reduce instances of cached contract addresses * poll balances when tx happens (#562) * Fix custom gas price (#566) * fix wrong custom gas value * fix calculation * fix comments * Feature: implement method registry (#571) * add handlemethoddata gaba support * update action keys methods * update tests * in tx review if method data unknown default to unknown method * bump gaba * Feature: EIP747 watchAsset (#576) * watchasset erc20 basic support * render watchasset modal * handle watchasset call * handle watchasset rejection * handle watched asset images * missing strings * snapshots * bump gaba * fix styles * snapshots * styles update * pin dep * install * Improvement: Transaction Edit (#579) * close dropdown if press outside * snapshots * missing doc * renaming * Fix asset removal (#582) * fix asset removal * clean up * fix typo * bump gaba * update package-lock * Fix missing balances (#583) * fix missing balances * Update index.js * Update currency rate too * dont poll tokens * Remove ref * bump gaba * remember biometrics preference (#584) * Feature: token deeplinks support (#588) * handling data through deeplink * handle chainId * handle token value correctly * use contract metadata to get token info is in there * showing alert while changing network * don't validate toen that user doesn't have * validate amount token to send if user doesn't have it in state * move messages to locales * fix getbalanceof * handle state token * fix typo * update locale * locales * feature: update GABA to 1.0.0-beta.71 (#590) * Two step push notification prompt (#589) * two step notification prompt * clean up * fix typo * Update deps (#591) * update react-native-push-notification * upgrade react-native to v0.59.4 * Feature: Warning when send to known asset (#593) * warning when user is sending eth or assets to known asset contract * snapshots * check contract map only on mainnet * test * Bugfix: remove and ignore assets only where is necessary (#594) * remove and ignore assets only where is necessary * bump gaba * Feature: Choose IPFS gateway (#592) * use of ipfsgateway from GABA * handle ipfs gateway selection * snapshots * snapshots * reorder ipfs gateways list * only show available ipfs gateways * snapshots * bump gaba * handle current gateway down * snapshots * Improvement: consolidate send and approval screens (#596) * consolidate send screen * consolidate approval screen * tx mode from navigation * fix renderable value being undefined when edit approval * snapshots * Remember recent addresses (#597) * kinda works * keyboard wizardry working * fix eth input * bump detox (#599) * Fix account label wallet (#600) * bump detox * fix default value * feature: add 1102 convenience methods (#602) * Improvement: update corresponding balances (#601) * existing contact bugfix * poll only when necessary * recent address bugfix and adding asset type in approval * update left button navbar when tx fails * avoid checking for asset address for undefined * Feature: collectibles api key (#603) * add opensea key from env * bump gaba * change const name * Improvement: shareable SimpleWebView (#604) * make shareable simple web view * test * check for navigation * update ios * Animations on App launch & resume (#606) * lottie working * added fadeIn / out effect * finally fix crash in debug mode * added fadeIn to other views * update unit tests * fix lock screen * adjust timing * more timing stuff * fix timing stuff * use optimized bounce animation * fix for android * update snapshots * use exact versions * bump version to 0.1.7 (#608) * update gem lockfile (#612) * use latest xcode image (#614) * unlink libRCTGeolocation (#616) * Bugfix: currency code & values with less than 5 precision decimals (#615) * remove usd dollar symbol * render low values * avoid crashing app when hot reloading * avoid rendering when no value * rollback fix * tests * comment * update animation (#619) * update animation * update snapshots * Bugfix: standardize colors (#618) * reds * blue * greays and primaryfox * greens * yellow * orange * random colors * snapshots * update colords * snapshots * Revert "update animation (#619)" (#620) This reverts commit 884a20f. * Feature: switch primary currency (#624) * select primary currency * wip number methods * send ETH withprimary currency fiat * fiatNumberToTokenMinimalUnit * tokens working * avoid exponential and render input * ethinput doc * handle value from ethinput * fix fill max when fiat as primary currency * clean up of values * clean render input * clean renderAsset * render tokens according to primary currency * processreadablevalue and fill max * balances and secondary balances * snapshots * small changes * pick component * snapshots * handle periodic numbers * comments * Feature: onboarding wizard (#607) * onboarding wizard component * rendering on top of stack" * steps and close tooltips * fake navigator * indicator style * hardcoded step 1 WIP * step 1 done * step 2 done * bullet progress bar * step 4 * use redux to navigate through onboarding * step 5 * steps 6 and 7 * got it * rename tooltip to coachmark * delete unused file * transparent styled button * update step3 to change account label * skip tutorial button * handle all onboarding state from redux * progress bar from array * doc * locales * snapshots * passing content and onboarding styles * reorder texts * update spanish * render methods * render onboarding wizard only when first time in app * IOS styles * android styles * snapshots * browser first * snapshots * label padding * minor comments * check onboarding on create / import wallet * sync from extension success * sync from extension success * add to entry and login * snapshots * feature: allow transactions to be cancelled (#622) * Improvement: assets detection (#627) * use collectible contract if image collectible is empty * bump gaba * Feature: terms and conditions (#631) * terms and conditions compoenent * import from seed * webview to stack * locales * snapshots * rm unused state * Feature: Tabs (#623) * good progress on tabs UI * tabs "kinda working" * fix tab selection * snapshots * refactor into components * more refactor * animations FTW * adjust values * fix tests * fix android UI * fix bugs * good progress on multi-webview approach * working on android and ios * fix a bunch of bugs * fix thumbnails * fix tests * refactor folder structure * improve snapshot reliability * fix tab remounted issue * clean up * fix back button ios * take screenshot before showing tabs * show real tab count * bugfixzzz * code review comments * dynamic calculation for scrolling * Feature: opt-in metrics (#632) * WIP * optin metrics screen full structure working * optin screen * create wallet flow * entry flow * import from seed * sync with extension flow * docs * basic logger * metametrics settings * navbar * logoin flow * snapshots AND ICONS * update no thanks * navbar doc * navbar colors and comment/; * restore action view * scrollable optin * snapshots * Improvement: gas limit fallback (#633) * gas limit estimation fallback * log * Bugfix: asset overview balance (#635) * render value on corresponding network * handle txs loader when switching networks * snapshots * svoid balance of undefined * Bugfix: phishing modal (#637) * fix ios biometrics permission prompt (#634) * Feature: import from seed password strength (#639) * add password strength to import from seed * snapshots * padding and jump to password * Bugfix: collectibles original image (#642) * bump gaba * add collectible address * bump gaba and audit * Feature: payment request (#641) * modal payment request * add qr address modal * basic stricture done * rename * select asset payment request * basic amount input * handle payment request navigation * handle amount * handle primary currency * handle primary currency switch * get crypto amount * divide primary currency methods * add buttons * generate link * success UI * better ui * share and copy to clipboard * show and close qer modal * consolidate ui and shgow user tokens * payment request flow from asset * handle network assets and link * handle empty search and empty tokens * handle not conversion rate * handle fiat primary currency with no conversion nor exchange rate * handle decimal places * consolidate primary currency methods * fix condition * docs * more docs * qr codes update * locales * onbuy coming soon * fix android icions * update icons * snapshots * on submit next * handle payment request from qrscanner * update receive icon * snapshots * update qr codes * update qr and android * android * comments * Swap cent for bounties (#626) * Swap cent for bounties * Fix typo * Fix payment request icon (#645) * fix icon * update snapshots * Feature: WalletConnect support (#643) * working * show session prompt * support for multiple connectors * persisting sessions and list * update snapshots * clean up * clean-up * Update WalletConnect.js * Update animation (#646) * update animation * update snapshots * fix and update assets * adjust values * update snapshots * Bugfix: fiat deeplinks (#648) * fix button info type color * fix bug * drop package * make overlay tappable on connect modal (#650) * make overlay tappable on connect modal * update snapshot * Bugfix: websites title and icon (#651) * if on title query for title when adding bookmark * fix website icon state * delete didmount * snapshots * android navbar * android navbar * browser scripts * Bugfix: android icon (#653) * downgrade rn vector icons * copy address from public address * snapshots * drop fabric * space * Feature: local analytics (#656) * introduce analytics * analytics opts * introduce tracking methods * track onboarding events * track navigation events * common but navigation swipe * browser view * dapp view * wallet view * rm settings logger * tramsaction confirm and approval screens * tramsaction confirm and cancel actions * transactions signatureS * transactions signatures doc * switch accounts * track login * track connect * DRY * track settings * snapshots * id dev log * remove async storage optin from settings * drop package-lock * runafterinteractions for analytics in didmount * interactionmanager changes * move tracking to end in send * analytics * move to end * Updated tabs and browser navigation (#658) * updated tabs and browser navigation * fix android stuff * update snapshots * update snapshots * Delete comment * Update index.js * Update Sync instructions (#660) * update eng instructions * update es instructions * Feature: advanced custom rpc (#661) * add rpc target chainid ticker and nickname * use network nickname * add isETH * use of ticker * move settings component to settings * basic networks settings * basic network settings * add and edit forms * adding custom rpc from network settings * add block explorer url * handle action anabled * validate chainid * doc and locales Q * drawer view in blockexplorer * handle block explorer from tx detauls * handle tx unit with ticker * configure native currency * if no conversion rate shpiw 0 * handle send from drawer * handle render from wei * handle eth input * action keys * update snapshots * create snapshots * more locales * conditional rpc rendering in networks sett * network icon top * ticker to uppercase * android ui * small fixes * more android * getticker getblockexoplorer * parse url name * bump gaba * attempt 1 (#665) * fix approval screen (#662) * enable 64 bits builds android (#667) * Bugfix: currency rate config (#666) * configure native and current currency on engine init * from copntropller init * bump gaba * destructure CurrencyRateController * Bugfix: some ui fixes (#668) * tabs thumbnail website icon * copllectible contract title center * align onboarding wizard step 5 * align receive button from asset for android * snapshots * dont import from rn gesture handler (#669) * Bugfix: close dropdowns on scan qr (#671) * close dropdowns * snapshots * swipe to dismiss notifications (#670) * swipe to dismiss notifications * exact match version * fix tap and opacity
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* WIP * optin metrics screen full structure working * optin screen * create wallet flow * entry flow * import from seed * sync with extension flow * docs * basic logger * metametrics settings * navbar * logoin flow * snapshots AND ICONS * update no thanks * navbar doc * navbar colors and comment/; * restore action view * scrollable optin * snapshots
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Transaction errors (#550) * wip: showing plain transaction error on screen alert * handle result promise * remove listener in approval * drop package-lock * comments * Add zxcvbn for password strength estimation (#555) * add zxcvbn * use zxcvbn for password estimations * add comments * update snapshot * navar title numberoflines 1 (#557) * Reduce instances of cached contract addresses (#547) Reduce instances of cached contract addresses * poll balances when tx happens (#562) * Fix custom gas price (#566) * fix wrong custom gas value * fix calculation * fix comments * Feature: implement method registry (#571) * add handlemethoddata gaba support * update action keys methods * update tests * in tx review if method data unknown default to unknown method * bump gaba * Feature: EIP747 watchAsset (#576) * watchasset erc20 basic support * render watchasset modal * handle watchasset call * handle watchasset rejection * handle watched asset images * missing strings * snapshots * bump gaba * fix styles * snapshots * styles update * pin dep * install * Improvement: Transaction Edit (#579) * close dropdown if press outside * snapshots * missing doc * renaming * Fix asset removal (#582) * fix asset removal * clean up * fix typo * bump gaba * update package-lock * Fix missing balances (#583) * fix missing balances * Update index.js * Update currency rate too * dont poll tokens * Remove ref * bump gaba * remember biometrics preference (#584) * Feature: token deeplinks support (#588) * handling data through deeplink * handle chainId * handle token value correctly * use contract metadata to get token info is in there * showing alert while changing network * don't validate toen that user doesn't have * validate amount token to send if user doesn't have it in state * move messages to locales * fix getbalanceof * handle state token * fix typo * update locale * locales * feature: update GABA to 1.0.0-beta.71 (#590) * Two step push notification prompt (#589) * two step notification prompt * clean up * fix typo * Update deps (#591) * update react-native-push-notification * upgrade react-native to v0.59.4 * Feature: Warning when send to known asset (#593) * warning when user is sending eth or assets to known asset contract * snapshots * check contract map only on mainnet * test * Bugfix: remove and ignore assets only where is necessary (#594) * remove and ignore assets only where is necessary * bump gaba * Feature: Choose IPFS gateway (#592) * use of ipfsgateway from GABA * handle ipfs gateway selection * snapshots * snapshots * reorder ipfs gateways list * only show available ipfs gateways * snapshots * bump gaba * handle current gateway down * snapshots * Improvement: consolidate send and approval screens (#596) * consolidate send screen * consolidate approval screen * tx mode from navigation * fix renderable value being undefined when edit approval * snapshots * Remember recent addresses (#597) * kinda works * keyboard wizardry working * fix eth input * bump detox (#599) * Fix account label wallet (#600) * bump detox * fix default value * feature: add 1102 convenience methods (#602) * Improvement: update corresponding balances (#601) * existing contact bugfix * poll only when necessary * recent address bugfix and adding asset type in approval * update left button navbar when tx fails * avoid checking for asset address for undefined * Feature: collectibles api key (#603) * add opensea key from env * bump gaba * change const name * Improvement: shareable SimpleWebView (#604) * make shareable simple web view * test * check for navigation * update ios * Animations on App launch & resume (#606) * lottie working * added fadeIn / out effect * finally fix crash in debug mode * added fadeIn to other views * update unit tests * fix lock screen * adjust timing * more timing stuff * fix timing stuff * use optimized bounce animation * fix for android * update snapshots * use exact versions * bump version to 0.1.7 (#608) * update gem lockfile (#612) * use latest xcode image (#614) * unlink libRCTGeolocation (#616) * Bugfix: currency code & values with less than 5 precision decimals (#615) * remove usd dollar symbol * render low values * avoid crashing app when hot reloading * avoid rendering when no value * rollback fix * tests * comment * update animation (#619) * update animation * update snapshots * Bugfix: standardize colors (#618) * reds * blue * greays and primaryfox * greens * yellow * orange * random colors * snapshots * update colords * snapshots * Revert "update animation (#619)" (#620) This reverts commit 884a20f. * Feature: switch primary currency (#624) * select primary currency * wip number methods * send ETH withprimary currency fiat * fiatNumberToTokenMinimalUnit * tokens working * avoid exponential and render input * ethinput doc * handle value from ethinput * fix fill max when fiat as primary currency * clean up of values * clean render input * clean renderAsset * render tokens according to primary currency * processreadablevalue and fill max * balances and secondary balances * snapshots * small changes * pick component * snapshots * handle periodic numbers * comments * Feature: onboarding wizard (#607) * onboarding wizard component * rendering on top of stack" * steps and close tooltips * fake navigator * indicator style * hardcoded step 1 WIP * step 1 done * step 2 done * bullet progress bar * step 4 * use redux to navigate through onboarding * step 5 * steps 6 and 7 * got it * rename tooltip to coachmark * delete unused file * transparent styled button * update step3 to change account label * skip tutorial button * handle all onboarding state from redux * progress bar from array * doc * locales * snapshots * passing content and onboarding styles * reorder texts * update spanish * render methods * render onboarding wizard only when first time in app * IOS styles * android styles * snapshots * browser first * snapshots * label padding * minor comments * check onboarding on create / import wallet * sync from extension success * sync from extension success * add to entry and login * snapshots * feature: allow transactions to be cancelled (#622) * Improvement: assets detection (#627) * use collectible contract if image collectible is empty * bump gaba * Feature: terms and conditions (#631) * terms and conditions compoenent * import from seed * webview to stack * locales * snapshots * rm unused state * Feature: Tabs (#623) * good progress on tabs UI * tabs "kinda working" * fix tab selection * snapshots * refactor into components * more refactor * animations FTW * adjust values * fix tests * fix android UI * fix bugs * good progress on multi-webview approach * working on android and ios * fix a bunch of bugs * fix thumbnails * fix tests * refactor folder structure * improve snapshot reliability * fix tab remounted issue * clean up * fix back button ios * take screenshot before showing tabs * show real tab count * bugfixzzz * code review comments * dynamic calculation for scrolling * Feature: opt-in metrics (#632) * WIP * optin metrics screen full structure working * optin screen * create wallet flow * entry flow * import from seed * sync with extension flow * docs * basic logger * metametrics settings * navbar * logoin flow * snapshots AND ICONS * update no thanks * navbar doc * navbar colors and comment/; * restore action view * scrollable optin * snapshots * Improvement: gas limit fallback (#633) * gas limit estimation fallback * log * Bugfix: asset overview balance (#635) * render value on corresponding network * handle txs loader when switching networks * snapshots * svoid balance of undefined * Bugfix: phishing modal (#637) * fix ios biometrics permission prompt (#634) * Feature: import from seed password strength (#639) * add password strength to import from seed * snapshots * padding and jump to password * Bugfix: collectibles original image (#642) * bump gaba * add collectible address * bump gaba and audit * Feature: payment request (#641) * modal payment request * add qr address modal * basic stricture done * rename * select asset payment request * basic amount input * handle payment request navigation * handle amount * handle primary currency * handle primary currency switch * get crypto amount * divide primary currency methods * add buttons * generate link * success UI * better ui * share and copy to clipboard * show and close qer modal * consolidate ui and shgow user tokens * payment request flow from asset * handle network assets and link * handle empty search and empty tokens * handle not conversion rate * handle fiat primary currency with no conversion nor exchange rate * handle decimal places * consolidate primary currency methods * fix condition * docs * more docs * qr codes update * locales * onbuy coming soon * fix android icions * update icons * snapshots * on submit next * handle payment request from qrscanner * update receive icon * snapshots * update qr codes * update qr and android * android * comments * Swap cent for bounties (#626) * Swap cent for bounties * Fix typo * Fix payment request icon (#645) * fix icon * update snapshots * Feature: WalletConnect support (#643) * working * show session prompt * support for multiple connectors * persisting sessions and list * update snapshots * clean up * clean-up * Update WalletConnect.js * Update animation (#646) * update animation * update snapshots * fix and update assets * adjust values * update snapshots * Bugfix: fiat deeplinks (#648) * fix button info type color * fix bug * drop package * make overlay tappable on connect modal (#650) * make overlay tappable on connect modal * update snapshot * Bugfix: websites title and icon (#651) * if on title query for title when adding bookmark * fix website icon state * delete didmount * snapshots * android navbar * android navbar * browser scripts * Bugfix: android icon (#653) * downgrade rn vector icons * copy address from public address * snapshots * drop fabric * space * Feature: local analytics (#656) * introduce analytics * analytics opts * introduce tracking methods * track onboarding events * track navigation events * common but navigation swipe * browser view * dapp view * wallet view * rm settings logger * tramsaction confirm and approval screens * tramsaction confirm and cancel actions * transactions signatureS * transactions signatures doc * switch accounts * track login * track connect * DRY * track settings * snapshots * id dev log * remove async storage optin from settings * drop package-lock * runafterinteractions for analytics in didmount * interactionmanager changes * move tracking to end in send * analytics * move to end * Updated tabs and browser navigation (#658) * updated tabs and browser navigation * fix android stuff * update snapshots * update snapshots * Delete comment * Update index.js * Update Sync instructions (#660) * update eng instructions * update es instructions * Feature: advanced custom rpc (#661) * add rpc target chainid ticker and nickname * use network nickname * add isETH * use of ticker * move settings component to settings * basic networks settings * basic network settings * add and edit forms * adding custom rpc from network settings * add block explorer url * handle action anabled * validate chainid * doc and locales Q * drawer view in blockexplorer * handle block explorer from tx detauls * handle tx unit with ticker * configure native currency * if no conversion rate shpiw 0 * handle send from drawer * handle render from wei * handle eth input * action keys * update snapshots * create snapshots * more locales * conditional rpc rendering in networks sett * network icon top * ticker to uppercase * android ui * small fixes * more android * getticker getblockexoplorer * parse url name * bump gaba * attempt 1 (#665) * fix approval screen (#662) * enable 64 bits builds android (#667) * Bugfix: currency rate config (#666) * configure native and current currency on engine init * from copntropller init * bump gaba * destructure CurrencyRateController * Bugfix: some ui fixes (#668) * tabs thumbnail website icon * copllectible contract title center * align onboarding wizard step 5 * align receive button from asset for android * snapshots * dont import from rn gesture handler (#669) * Bugfix: close dropdowns on scan qr (#671) * close dropdowns * snapshots * swipe to dismiss notifications (#670) * swipe to dismiss notifications * exact match version * fix tap and opacity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a screen to choose whether the user wants to participate in MetaMetrics or not. Also it can be modified from settings.
GIF for IOS and Android: http://recordit.co/4DHacZEaJD
Opt-In screen will prompt after
Entry,SyncWithExtensionSuccess,Login,CreateWalletandImportFromWalletif the user haven't chosen any option yet.Once we merge this I'll create an issue to handle Crashlytics well, now
Loggeris reading the flag each time that wants to log something.Icons updated since I recorded the GIF
Checklist
Issue
Resolves #574