Skip to content

On-ramp: Add #5870 localization#5976

Merged
sethkfman merged 2 commits intorelease/6.2.0from
chore/onramp-add-l18n-5870
Mar 17, 2023
Merged

On-ramp: Add #5870 localization#5976
sethkfman merged 2 commits intorelease/6.2.0from
chore/onramp-add-l18n-5870

Conversation

@wachunei
Copy link
Copy Markdown
Member

@wachunei wachunei commented Mar 16, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR adds the translated strings for #5870

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei requested a review from a team as a code owner March 16, 2023 17:35
@wachunei wachunei mentioned this pull request Mar 16, 2023
Closed
Cal-L
Cal-L approved these changes Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko
Copy link
Copy Markdown
Member

cortisiko commented Mar 17, 2023

So a couple of things here:
In prod, the linked text “Import tokens” was on a separate line and that link was tappable.

Are we now making the entire line “Don’t see your token? Import tokens” tappable?

If the answer to the above is yes, then we need to decrease the font size of the import token link for languages with long translated strings such as Filipino.

compared to prod v6.1.2

Cal-L
Cal-L approved these changes Mar 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wachunei confirms that the text will be centered but the link itself can wrap. Code LGTM and will defer to @cortisiko for anymore questions.

cortisiko
cortisiko approved these changes Mar 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@cortisiko cortisiko added release-6.2.0 Issue or pull request that will be included in release 6.2.0 QA Passed QA testing has been completed and passed labels Mar 17, 2023
@Cal-L Cal-L force-pushed the chore/onramp-add-l18n-5870 branch from 076ef42 to 408437c Compare March 17, 2023 18:29
@sethkfman sethkfman merged commit 3cc47da into release/6.2.0 Mar 17, 2023
@sethkfman sethkfman deleted the chore/onramp-add-l18n-5870 branch March 17, 2023 18:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
@vpintorico vpintorico added the team-money-movement issues related to Money Movement features label Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-6.2.0 Issue or pull request that will be included in release 6.2.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wachunei @cortisiko @Cal-L @vpintorico @sethkfman