Merged
Conversation
25f3679 to
58dc7ce
Compare
NicolasMassart
approved these changes
Mar 6, 2023
Contributor
NicolasMassart
left a comment
There was a problem hiding this comment.
Reviewed, build on iPhone and tested. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR adds a
Buy <Token>button on the wallet home when the user has 0 balance and the network is supported buy the buy feature.Strategic rationale
We're using the empty space to get users off a zero balance—it's low-hanging fruit. New users need ETH/gas to submit transactions, and from user research, we know there needs to be more awareness of our On-ramp feature (and even Swaps).
Furthermore, we have data indicating the popularity of a previous iteration of this button. For example, in Sep 2021, this button received [n]M clicks, more than the smaller button. This simple button can significantly increase On-ramp engagement from new users/empty accounts.
Screenshots/Recordings
Issue
Progresses #???
Checklist