Skip to content

Add Custom Network during on boarding#5334

Closed
tommasini wants to merge 15 commits intorelease/5.12.1from
feature/5301-metametrics-copy
Closed

Add Custom Network during on boarding#5334
tommasini wants to merge 15 commits intorelease/5.12.1from
feature/5301-metametrics-copy

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Dec 1, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Now it's possible to add a custom network during onboarding, that enables the user to choose not to use a infura rpc url.

Screenshots/Recordings
https://recordit.co/PIQjzWnaue

Test Cases
Case1:

  • Fresh install the app
  • Press settings on meta metrics screen
  • add another rpc url for ethereum
  • finish on boarding (create a new wallet and importing an existing one)
  • go to settings -> networks
  • check active network and active network rpc url

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L force-pushed the feature/5301-metametrics-copy branch from 6b786cf to 5426bcd Compare December 2, 2022 03:56
@Cal-L Cal-L marked this pull request as ready for review December 2, 2022 04:18
@Cal-L Cal-L requested a review from a team as a code owner December 2, 2022 04:18
@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-5.12.1 Issue or pull request that will be included in release 5.12.1 labels Dec 2, 2022
@cortisiko
Copy link
Copy Markdown
Member

cortisiko commented Dec 2, 2022

this is not ready for QA since it did not go through dev review. Once we pass dev review. Feel free to add back the "needs-qa" label.

@cortisiko cortisiko removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Dec 2, 2022
sethkfman
sethkfman reviewed Dec 2, 2022
View reviewed changes
sethkfman
sethkfman approved these changes Dec 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 3, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Dec 5, 2022
@sethkfman sethkfman changed the base branch from main to release/5.12.1 December 5, 2022 23:01
cortisiko
cortisiko requested changes Dec 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cal-L I am done with testing. Below are my findings:

issue 1
from the MetaMetrics view if i were to open the custom RPC form:
enter an RPC url
hit save/confirm/set. basically, tapping the CTA confirms the RPC url.
i am taken back to the MetaMetrics view.
if i were to return back to the custom RPC url form, the saved RPC URL does not appear: http://recordit.co/lEz0ONEIZa

Issue 2
Custom RPC for mainnet edit the RPC after wallet creation and confirm you are not seeing duplicate networks. See recording: http://recordit.co/owxMG7DvX6

Issue 3
This one is sort of sensitive. Here is the slack chat with the bug description.

@cortisiko cortisiko added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Dec 6, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Dec 6, 2022
@Cal-L Cal-L mentioned this pull request Dec 7, 2022
Merged
3 tasks
@Cal-L
Copy link
Copy Markdown
Contributor

Cal-L commented Dec 7, 2022

Closing and moved to #5362

@Cal-L Cal-L closed this Dec 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
@Cal-L Cal-L removed QA in Progress QA has started on the feature. Mobile QA board labels Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortisiko cortisiko cortisiko requested changes

+1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-5.12.1 Issue or pull request that will be included in release 5.12.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tommasini @cortisiko @Cal-L @sethkfman