Skip to content

[ENHANCEMENT] Easy delete data#5175

Merged
gantunesr merged 17 commits intoanalytics/migrate-eventsfrom
feat/segment-easy-delete-data
Feb 28, 2023
Merged

[ENHANCEMENT] Easy delete data#5175
gantunesr merged 17 commits intoanalytics/migrate-eventsfrom
feat/segment-easy-delete-data

Conversation

@gantunesr
Copy link
Copy Markdown
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

Update "Easy Delete Data" feature to be compatible with Segment

2. What is the improvement/solution?

Use PR #4389 as reference.

Screenshots/Recordings

Use PR #4389 as reference.

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/373

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 31, 2022
@gantunesr gantunesr marked this pull request as ready for review October 31, 2022 02:43
@gantunesr gantunesr requested a review from a team as a code owner October 31, 2022 02:43
@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 6, 2022
@gantunesr gantunesr changed the base branch from main to analytics/migrate-events February 22, 2023 12:35
@gantunesr gantunesr mentioned this pull request Feb 22, 2023
5 tasks
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 28, 2023
@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 28, 2023
Copy link
Copy Markdown
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Left a question

@gantunesr gantunesr merged commit aafac25 into analytics/migrate-events Feb 28, 2023
@gantunesr gantunesr deleted the feat/segment-easy-delete-data branch February 28, 2023 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2023
@gantunesr gantunesr added team-mobile-client release-6.2.0 Issue or pull request that will be included in release 6.2.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 14, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-6.2.0 Issue or pull request that will be included in release 6.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants