Skip to content

[5.3] [FEAT] Easy delete data#4389

Merged
gantunesr merged 89 commits intomainfrom
feat/delete-all-data
Jun 16, 2022
Merged

[5.3] [FEAT] Easy delete data#4389
gantunesr merged 89 commits intomainfrom
feat/delete-all-data

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented May 24, 2022 •
edited
Loading

Description

Description in Planning#249 and designs in Figma.

Important considerations to have during both code review and QA,

  • This PR refactors the delete wallet logic and components, it's important to verify that this functionality works properly on both Login and Security Settings.
  • MixPanel Analytics Manager and Sentry now have the functionality of deleting data. There are only minor changes to the existing logic.
  • Refer to this comment to see the minimal test cases to verify.

Pending

  • Solve navigation login issue
  • Add Consensys Policy link
  • Verify UX/UI with @jakehaugen
  • Improve error handling
  • Section position

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

  1. Delete local wallet

  1. Delete user data

Next Steps

  1. Refactor legacy modals to use our navigation pattern

Issue

Progresses Planning#249

gantunesr added 30 commits May 8, 2022 01:20
Move url to constant file
bf54cd0
Add UI
fa81018
Add endpoint to delete mixpanel data
8e3643a
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
861d442 
…to feat/delete-all-data
Change Settings structure
0d2435a
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
3627e13 
…to feat/delete-all-data
Add texts
9091a55
Move delete modal
3a9fc29
Add policy url
b7a604a
Update Settings section component
555f5ab
Fix typo
8bcc3fd
Update variable name
c013a44
Add useDeleteWallet hook
0ed8465
Update Nav to access delete modal
795a83d
Rename and update delete modal
ec7878c
Add new routes values
89947b0
Remove delete wallet logic from login
068b167
Fix Login Nav
6eb02c0
Add DeleteWalletModal to Settings nav stack
52343b1
Update useDeleteWallet hook
62f3bcf
Update Login navigation
747d5e3
Update SettingsButtonSection to make modal optional
6dcd4b1
Update DeleteMetaMetricsData
d9c77f7
Rename Sentry file
8f5edcb
Rename Sentry file
d3198ff
Update SettingsButtonSection
4e8ee54
Update data deletion method
32609c0
Add animation between modals
39cb123
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
24ab66a 
…to feat/delete-all-data
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
a74c7e7 
…to feat/delete-all-data
@plasmacorral plasmacorral added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Jun 13, 2022
@plasmacorral
Copy link
Copy Markdown
Contributor

plasmacorral commented Jun 13, 2022 •
edited
Loading

Unable to successfully delete on Android or iOS at this time.

Receiving error: "We are unable to delete this data right now. This request can't be completed right now due to analytics system server issue, please try again later."

This error message may need a minor copy edit to add the word 'AN' before analytics, I think it should read:
"We are unable to delete this data right now. This request can't be completed right now due to an analytics system server issue, please try again later."

Screen Shot 2022-06-10 at 1 58 16 PM

@mobularay mobularay added the release-5.3.0 Issue or pull request that will be included in release 5.3.0 label Jun 14, 2022
@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jun 15, 2022
@plasmacorral
Copy link
Copy Markdown
Contributor

plasmacorral commented Jun 16, 2022

At this time I am unable to validate the deletion request in 2 scenarios, but I will follow-up on that further in to the 60 day window and will raise a fresh issue should I encounter anything unexpected.

@plasmacorral plasmacorral added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 16, 2022
@gantunesr gantunesr merged commit f555789 into main Jun 16, 2022
@gantunesr gantunesr deleted the feat/delete-all-data branch June 16, 2022 18:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2022
@chrisleewilcox chrisleewilcox added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead and removed regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead labels Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@blackdevelopa blackdevelopa blackdevelopa left review comments

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-5.3.0 Issue or pull request that will be included in release 5.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gantunesr @omnat @plasmacorral @sethkfman @blackdevelopa @chrisleewilcox @mobularay @Cal-L