Approval and Send navbars with network#429
Merged
estebanmino merged 2 commits intodevelopfrom Feb 22, 2019
Merged
Conversation
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
) ## **Description** Add new analytics properties to Predict market events to improve tracking for sports/game-based prediction markets: 1. **PREDICT_MARKET_DETAILS_OPENED** and **PREDICT_TRADE_TRANSACTION** events now include: - `market_slug` - Market slug identifier - `game_id` - Game identifier - `game_start_time` - Game start timestamp - `game_league` - League name (e.g., "NBA", "NFL") - `game_status` - Game status (e.g., "not_started", "live", "final") - `game_period` - Current game period (nullable) - `game_clock` - Current game clock (nullable) 2. **SHARE_ACTION** event tracking added for share button interactions: - `status` - Share status: "initiated", "success", or "failed" - `market_id` - Market identifier - `market_slug` - Market slug These changes align with the Segment schema updates in [segment-schema PR #429](Consensys/segment-schema#429). ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: - https://consensyssoftware.atlassian.net/browse/PRED-422 - https://consensyssoftware.atlassian.net/browse/PRED-505 ## **Manual testing steps** ```gherkin Feature: Predict Analytics Events Scenario: Game properties sent on market details view Given user navigates to a sports prediction market When user opens the market details view Then PREDICT_MARKET_DETAILS_OPENED event includes game properties (game_id, game_league, game_status, etc.) Scenario: Game properties sent on trade transaction Given user is on a sports prediction market buy/sell preview When user completes a buy or sell transaction Then PREDICT_TRADE_TRANSACTION event includes game properties Scenario: Share action tracking Given user is viewing a prediction market with game details When user taps the share button Then SHARE_ACTION event is sent with status "initiated" And when share completes successfully, SHARE_ACTION event is sent with status "success" And when share fails, SHARE_ACTION event is sent with status "failed" ``` ## **Screenshots/Recordings** N/A - Analytics only change, no UI modifications ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Enhances Predict analytics coverage for sports markets and share interactions. > > - Extends `PREDICT_TRADE_TRANSACTION` and `PREDICT_MARKET_DETAILS_OPENED` with `market_slug`, `game_id`, `game_start_time`, `game_league`, `game_status`, `game_period`, `game_clock` > - Adds `PredictController.trackShareAction` and wires `PredictShareButton` to track `initiated` → `success`/`failed` (includes `market_id` and optional `market_slug`) > - Passes `marketSlug` into `PredictShareButton` in market/game detail views > - Updates analytics types/interfaces to carry new fields across controller/provider layers > - Adds unit tests for share button analytics, URL/message construction, and edge cases > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4c8b0b8. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github bot
added a commit
that referenced
this pull request
Jan 23, 2026
…#25065) ## **Description** Add new analytics properties to Predict market events to improve tracking for sports/game-based prediction markets: 1. **PREDICT_MARKET_DETAILS_OPENED** and **PREDICT_TRADE_TRANSACTION** events now include: - `market_slug` - Market slug identifier - `game_id` - Game identifier - `game_start_time` - Game start timestamp - `game_league` - League name (e.g., "NBA", "NFL") - `game_status` - Game status (e.g., "not_started", "live", "final") - `game_period` - Current game period (nullable) - `game_clock` - Current game clock (nullable) 2. **SHARE_ACTION** event tracking added for share button interactions: - `status` - Share status: "initiated", "success", or "failed" - `market_id` - Market identifier - `market_slug` - Market slug These changes align with the Segment schema updates in [segment-schema PR #429](https://github.com/Consensys/segment-schema/pull/429). ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: - https://consensyssoftware.atlassian.net/browse/PRED-422 - https://consensyssoftware.atlassian.net/browse/PRED-505 ## **Manual testing steps** ```gherkin Feature: Predict Analytics Events Scenario: Game properties sent on market details view Given user navigates to a sports prediction market When user opens the market details view Then PREDICT_MARKET_DETAILS_OPENED event includes game properties (game_id, game_league, game_status, etc.) Scenario: Game properties sent on trade transaction Given user is on a sports prediction market buy/sell preview When user completes a buy or sell transaction Then PREDICT_TRADE_TRANSACTION event includes game properties Scenario: Share action tracking Given user is viewing a prediction market with game details When user taps the share button Then SHARE_ACTION event is sent with status "initiated" And when share completes successfully, SHARE_ACTION event is sent with status "success" And when share fails, SHARE_ACTION event is sent with status "failed" ``` ## **Screenshots/Recordings** N/A - Analytics only change, no UI modifications ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Enhances Predict analytics coverage for sports markets and share interactions. > > - Extends `PREDICT_TRADE_TRANSACTION` and `PREDICT_MARKET_DETAILS_OPENED` with `market_slug`, `game_id`, `game_start_time`, `game_league`, `game_status`, `game_period`, `game_clock` > - Adds `PredictController.trackShareAction` and wires `PredictShareButton` to track `initiated` → `success`/`failed` (includes `market_id` and optional `market_slug`) > - Passes `marketSlug` into `PredictShareButton` in market/game detail views > - Updates analytics types/interfaces to carry new fields across controller/provider layers > - Adds unit tests for share button analytics, URL/message construction, and edge cases > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4c8b0b8. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github bot
added a commit
that referenced
this pull request
Jan 23, 2026
…#25065) ## **Description** Add new analytics properties to Predict market events to improve tracking for sports/game-based prediction markets: 1. **PREDICT_MARKET_DETAILS_OPENED** and **PREDICT_TRADE_TRANSACTION** events now include: - `market_slug` - Market slug identifier - `game_id` - Game identifier - `game_start_time` - Game start timestamp - `game_league` - League name (e.g., "NBA", "NFL") - `game_status` - Game status (e.g., "not_started", "live", "final") - `game_period` - Current game period (nullable) - `game_clock` - Current game clock (nullable) 2. **SHARE_ACTION** event tracking added for share button interactions: - `status` - Share status: "initiated", "success", or "failed" - `market_id` - Market identifier - `market_slug` - Market slug These changes align with the Segment schema updates in [segment-schema PR #429](https://github.com/Consensys/segment-schema/pull/429). ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: - https://consensyssoftware.atlassian.net/browse/PRED-422 - https://consensyssoftware.atlassian.net/browse/PRED-505 ## **Manual testing steps** ```gherkin Feature: Predict Analytics Events Scenario: Game properties sent on market details view Given user navigates to a sports prediction market When user opens the market details view Then PREDICT_MARKET_DETAILS_OPENED event includes game properties (game_id, game_league, game_status, etc.) Scenario: Game properties sent on trade transaction Given user is on a sports prediction market buy/sell preview When user completes a buy or sell transaction Then PREDICT_TRADE_TRANSACTION event includes game properties Scenario: Share action tracking Given user is viewing a prediction market with game details When user taps the share button Then SHARE_ACTION event is sent with status "initiated" And when share completes successfully, SHARE_ACTION event is sent with status "success" And when share fails, SHARE_ACTION event is sent with status "failed" ``` ## **Screenshots/Recordings** N/A - Analytics only change, no UI modifications ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Enhances Predict analytics coverage for sports markets and share interactions. > > - Extends `PREDICT_TRADE_TRANSACTION` and `PREDICT_MARKET_DETAILS_OPENED` with `market_slug`, `game_id`, `game_start_time`, `game_league`, `game_status`, `game_period`, `game_clock` > - Adds `PredictController.trackShareAction` and wires `PredictShareButton` to track `initiated` → `success`/`failed` (includes `market_id` and optional `market_slug`) > - Passes `marketSlug` into `PredictShareButton` in market/game detail views > - Updates analytics types/interfaces to carry new fields across controller/provider layers > - Adds unit tests for share button analytics, URL/message construction, and edge cases > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4c8b0b8. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
…es to analytics events (#25065) ## **Description** Add new analytics properties to Predict market events to improve tracking for sports/game-based prediction markets: 1. **PREDICT_MARKET_DETAILS_OPENED** and **PREDICT_TRADE_TRANSACTION** events now include: - `market_slug` - Market slug identifier - `game_id` - Game identifier - `game_start_time` - Game start timestamp - `game_league` - League name (e.g., "NBA", "NFL") - `game_status` - Game status (e.g., "not_started", "live", "final") - `game_period` - Current game period (nullable) - `game_clock` - Current game clock (nullable) 2. **SHARE_ACTION** event tracking added for share button interactions: - `status` - Share status: "initiated", "success", or "failed" - `market_id` - Market identifier - `market_slug` - Market slug These changes align with the Segment schema updates in [segment-schema PR #429](Consensys/segment-schema#429). ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: - https://consensyssoftware.atlassian.net/browse/PRED-422 - https://consensyssoftware.atlassian.net/browse/PRED-505 ## **Manual testing steps** ```gherkin Feature: Predict Analytics Events Scenario: Game properties sent on market details view Given user navigates to a sports prediction market When user opens the market details view Then PREDICT_MARKET_DETAILS_OPENED event includes game properties (game_id, game_league, game_status, etc.) Scenario: Game properties sent on trade transaction Given user is on a sports prediction market buy/sell preview When user completes a buy or sell transaction Then PREDICT_TRADE_TRANSACTION event includes game properties Scenario: Share action tracking Given user is viewing a prediction market with game details When user taps the share button Then SHARE_ACTION event is sent with status "initiated" And when share completes successfully, SHARE_ACTION event is sent with status "success" And when share fails, SHARE_ACTION event is sent with status "failed" ``` ## **Screenshots/Recordings** N/A - Analytics only change, no UI modifications ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Enhances Predict analytics coverage for sports markets and share interactions. > > - Extends `PREDICT_TRADE_TRANSACTION` and `PREDICT_MARKET_DETAILS_OPENED` with `market_slug`, `game_id`, `game_start_time`, `game_league`, `game_status`, `game_period`, `game_clock` > - Adds `PredictController.trackShareAction` and wires `PredictShareButton` to track `initiated` → `success`/`failed` (includes `market_id` and optional `market_slug`) > - Passes `marketSlug` into `PredictShareButton` in market/game detail views > - Updates analytics types/interfaces to carry new fields across controller/provider layers > - Adds unit tests for share button analytics, URL/message construction, and edge cases > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4c8b0b8. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
joaoloureirop
pushed a commit
that referenced
this pull request
Jan 23, 2026
…es to analytics events (#25123) - feat(predict): cp-7.63.0 add game properties to analytics events (#25065) ## **Description** Add new analytics properties to Predict market events to improve tracking for sports/game-based prediction markets: 1. **PREDICT_MARKET_DETAILS_OPENED** and **PREDICT_TRADE_TRANSACTION** events now include: - `market_slug` - Market slug identifier - `game_id` - Game identifier - `game_start_time` - Game start timestamp - `game_league` - League name (e.g., "NBA", "NFL") - `game_status` - Game status (e.g., "not_started", "live", "final") - `game_period` - Current game period (nullable) - `game_clock` - Current game clock (nullable) 2. **SHARE_ACTION** event tracking added for share button interactions: - `status` - Share status: "initiated", "success", or "failed" - `market_id` - Market identifier - `market_slug` - Market slug These changes align with the Segment schema updates in [segment-schema PR #429](https://github.com/Consensys/segment-schema/pull/429). ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: - https://consensyssoftware.atlassian.net/browse/PRED-422 - https://consensyssoftware.atlassian.net/browse/PRED-505 ## **Manual testing steps** ```gherkin Feature: Predict Analytics Events Scenario: Game properties sent on market details view Given user navigates to a sports prediction market When user opens the market details view Then PREDICT_MARKET_DETAILS_OPENED event includes game properties (game_id, game_league, game_status, etc.) Scenario: Game properties sent on trade transaction Given user is on a sports prediction market buy/sell preview When user completes a buy or sell transaction Then PREDICT_TRADE_TRANSACTION event includes game properties Scenario: Share action tracking Given user is viewing a prediction market with game details When user taps the share button Then SHARE_ACTION event is sent with status "initiated" And when share completes successfully, SHARE_ACTION event is sent with status "success" And when share fails, SHARE_ACTION event is sent with status "failed" ``` ## **Screenshots/Recordings** N/A - Analytics only change, no UI modifications ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Enhances Predict analytics coverage for sports markets and sharing flows. > > - Adds `market_slug`, `game_id`, `game_start_time`, `game_league`, `game_status`, `game_period`, `game_clock` to `PREDICT_TRADE_TRANSACTION` and `PREDICT_MARKET_DETAILS_OPENED` via `PredictController`, with type updates in `providers/types.ts` > - Introduces `PredictShareStatus` and new `SHARE_ACTION` tracking in `PredictController.trackShareAction` > - Updates `PredictShareButton` to send `SHARE_ACTION` events on press (initiated) and on result (success/failed), and accept/pass `marketSlug`; propagates prop from market detail/game views > - Adds comprehensive tests for share URL, toasts, edge cases, and analytics status flows > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7040a85. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [a2d49c6](a2d49c6) Co-authored-by: Luis Taniça <matallui@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new navbar for confirmation screens, it shows the current network.
Checklist
Issue
Resolves #427