Skip to content

Cherry-picking commits from main to release/7.81.0 for PR #31566#31585

Merged
sleepytanya merged 1 commit into
release/7.81.0from
runway-cherry-pick-7.81.0-1781201801
Jun 11, 2026
Merged

Cherry-picking commits from main to release/7.81.0 for PR #31566#31585
sleepytanya merged 1 commit into
release/7.81.0from
runway-cherry-pick-7.81.0-1781201801

Conversation

@runway-github

@runway-github runway-github Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

Updates the World Cup homepage discovery overflow copy from “events in
total” to “markets in total”.
This matches the product language for the overflowing World Cup market
count while leaving the normal non-overflow event count unchanged.

Changelog

CHANGELOG entry: Updated World Cup discovery copy to say markets instead
of events for overflowing counts.

Related issues

Fixes:

Manual testing steps

Feature: World Cup discovery card copy
  Scenario: user sees overflowing World Cup market count
    Given the Predictions homepage discovery card has more World Cup items than the display limit
    When the user views the World Cup discovery row
    Then the overflow count says "{{count}}+ markets in total"

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Copy-only English localization and test assertion change with no logic
or data-handling impact.

Overview
Updates World Cup homepage discovery overflow copy from “events”
to markets so overflowing counts match product terminology.

The English string
predict.homepage_discovery.events_in_total_overflow now renders
{{count}}+ markets in total instead of {{count}}+ events in total.
The non-overflow key events_in_total is unchanged. The
PredictionsSection test expectation for the discovery row was aligned
with the new copy.

Reviewed by Cursor Bugbot for commit
f19f028. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[c101846](https://github.com/MetaMask/metamask-mobile/commit/c10184632fdbe328ea22c73dee2e6f9aec6513fb)

…ation cp-7.81.0 (#31566)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->
<!--
mms-check directive vocabulary — read by
.github/scripts/shared/pr-template-checks.ts
at module load to build the validation plan. Directives are invisible in
rendered
markdown and must NOT be removed or edited without updating the
validator registry.

  type=text           Section must contain non-placeholder prose.
  type=changelog      Section must have a valid CHANGELOG entry: line.
type=issue-link Section must have a Fixes:/Closes:/Refs: line with a
value.
type=manual-testing Section must have real testing steps or an explicit
N/A.
type=screenshot Section must have evidence (image/URL) or an explicit
N/A.
type=checklist Section must have all checkboxes consciously checked.
required=true|false Whether a missing/invalid section runs the validator
at all.
blocking=true|false Whether a failure of this check fails the CI
workflow.
Default: false — failures are shown as warnings in the sticky
                      comment but do not block the PR.

Sections without a directive are checked for structural presence only.
-->

## **Description**

<!-- mms-check: type=text required=true -->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Updates the World Cup homepage discovery overflow copy from “events in
total” to “markets in total”.
This matches the product language for the overflowing World Cup market
count while leaving the normal non-overflow event count unchanged.


## **Changelog**

<!-- mms-check: type=changelog required=true blocking=true -->

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Updated World Cup discovery copy to say markets instead
of events for overflowing counts.

## **Related issues**

<!-- mms-check: type=issue-link required=true -->

Fixes:

## **Manual testing steps**

<!-- mms-check: type=manual-testing required=true -->

```gherkin
Feature: World Cup discovery card copy
  Scenario: user sees overflowing World Cup market count
    Given the Predictions homepage discovery card has more World Cup items than the display limit
    When the user views the World Cup discovery row
    Then the overflow count says "{{count}}+ markets in total"
```

## **Screenshots/Recordings**

<!-- mms-check: type=screenshot required=true -->

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

<!-- mms-check: type=checklist required=true -->

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Copy-only English localization and test assertion change with no logic
or data-handling impact.
> 
> **Overview**
> Updates World Cup homepage discovery **overflow** copy from “events”
to **markets** so overflowing counts match product terminology.
> 
> The English string
`predict.homepage_discovery.events_in_total_overflow` now renders
`{{count}}+ markets in total` instead of `{{count}}+ events in total`.
The non-overflow key `events_in_total` is unchanged. The
`PredictionsSection` test expectation for the discovery row was aligned
with the new copy.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
f19f028. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner June 11, 2026 18:16
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Jun 11, 2026
@sleepytanya sleepytanya enabled auto-merge (squash) June 11, 2026 18:36
@sleepytanya sleepytanya merged commit fb9d1f2 into release/7.81.0 Jun 11, 2026
119 checks passed
@sleepytanya sleepytanya deleted the runway-cherry-pick-7.81.0-1781201801 branch June 11, 2026 18:39
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants