Skip to content

fix(locales): update overflow text for event count in English localization cp-7.81.0#31566

Merged
PatrykLucka merged 1 commit into
mainfrom
update-world-cup-row-copy
Jun 11, 2026
Merged

fix(locales): update overflow text for event count in English localization cp-7.81.0#31566
PatrykLucka merged 1 commit into
mainfrom
update-world-cup-row-copy

Conversation

@PatrykLucka

@PatrykLucka PatrykLucka commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

Updates the World Cup homepage discovery overflow copy from “events in total” to “markets in total”.
This matches the product language for the overflowing World Cup market count while leaving the normal non-overflow event count unchanged.

Changelog

CHANGELOG entry: Updated World Cup discovery copy to say markets instead of events for overflowing counts.

Related issues

Fixes:

Manual testing steps

Feature: World Cup discovery card copy
  Scenario: user sees overflowing World Cup market count
    Given the Predictions homepage discovery card has more World Cup items than the display limit
    When the user views the World Cup discovery row
    Then the overflow count says "{{count}}+ markets in total"

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Copy-only English localization and test assertion change with no logic or data-handling impact.

Overview
Updates World Cup homepage discovery overflow copy from “events” to markets so overflowing counts match product terminology.

The English string predict.homepage_discovery.events_in_total_overflow now renders {{count}}+ markets in total instead of {{count}}+ events in total. The non-overflow key events_in_total is unchanged. The PredictionsSection test expectation for the discovery row was aligned with the new copy.

Reviewed by Cursor Bugbot for commit f19f028. Bugbot is set up for automated code reviews on this repo. Configure here.

@PatrykLucka PatrykLucka self-assigned this Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 11, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added the team-mobile-ux Mobile UX team label Jun 11, 2026
@mm-token-exchange-service

mm-token-exchange-service Bot commented Jun 11, 2026

Copy link
Copy Markdown

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.
  • Screenshots/Recordings section is empty. Add an image/video for user-facing changes, logs/console output for non-user-facing changes, or write N/A if no evidence is applicable.
  • Pre-merge author checklist has unchecked items (e.g. "I've tested on Android"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@PatrykLucka PatrykLucka changed the title fix(locales): update overflow text for event count in English localiz… fix(locales): update overflow text for event count in English localization Jun 11, 2026
@PatrykLucka PatrykLucka force-pushed the update-world-cup-row-copy branch from 9568f96 to a866c8a Compare June 11, 2026 14:24
@PatrykLucka PatrykLucka force-pushed the update-world-cup-row-copy branch from a866c8a to f19f028 Compare June 11, 2026 14:29
@PatrykLucka PatrykLucka marked this pull request as ready for review June 11, 2026 14:31
@PatrykLucka PatrykLucka requested a review from a team as a code owner June 11, 2026 14:31
@PatrykLucka PatrykLucka changed the title fix(locales): update overflow text for event count in English localization fix(locales): update overflow text for event count in English localization cp-7.81.0 Jun 11, 2026
@PatrykLucka PatrykLucka added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit c101846 Jun 11, 2026
79 checks passed
@PatrykLucka PatrykLucka deleted the update-world-cup-row-copy branch June 11, 2026 17:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.82.0 Issue or pull request that will be included in release 7.82.0 label Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. release-7.82.0 Issue or pull request that will be included in release 7.82.0 size-XS team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants