Skip to content

chore(runway): cherry-pick fix(ramps): remove Navigation Dev Panel and purge seeded orders#31229

Merged
runway-github[bot] merged 2 commits into
release/7.81.0from
cherry-pick-7-81-0-59970c9
Jun 8, 2026
Merged

chore(runway): cherry-pick fix(ramps): remove Navigation Dev Panel and purge seeded orders#31229
runway-github[bot] merged 2 commits into
release/7.81.0from
cherry-pick-7-81-0-59970c9

Conversation

@runway-github

@runway-github runway-github Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes invalid dev-panel-ramps-order traffic hitting the provider's Get
Orders by ID endpoint (500s on LIVE).

The Navigation Dev Panel (internal-only, gated by
MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS) seeded a mock Ramps order into
persisted RampsController state via addOrder():

providerOrderId: dev-panel-ramps-order
provider.id: paypal
That order persisted across launches. On internal/experimental builds
that use the production ramps environment, it reached the provider's
live endpoint with an invalid order ID. This started after the ramps
seed landed in #31037 (~June 4).

Changes:

  • Remove the Navigation Dev Panel entirely (component, mock params,
    Developer Options entry, route, and references) so nothing can seed
    these orders again.
  • Add migration 140 to purge dev-panel sentinel artifacts from affected
    devices on next launch:
  • RampsController.orders → dev-panel-ramps-order (the incident)
    fiatOrders.orders → dev-panel-aggregator-order, dev-panel-deposit-order,
    dev-panel-sell-order
  • BridgeStatusController.txHistory / TransactionController.transactions
    → dev-panel-bridge-tx
    Production users were never affected (dev panel not reachable in prod
    builds). Migration 140 is a no-op for them and only for RC users.

Changelog

CHANGELOG entry:null

Related issues

Fixes: Test seeding ramp with order ID dev-panel-ramps-order bug for
non-production users

Manual testing steps

 Background:
    Given the app is built with MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS enabled
    And the user has previously opened the Navigation Dev Panel
    And the user navigated to the Ramps Order Details entry in the panel
  
Scenario: Navigation Dev Panel is no longer available
    Given the user opens Settings
    And the user opens Developer Options
    Then the "Open Navigation Dev Panel" button is not shown
    And the NavigationDevPanel route is not registered in the navigator
  
Scenario: Dev panel no longer seeds a mock Ramps order
    Given the user is on Developer Options
    When the user attempts to open the Navigation Dev Panel
    Then the Navigation Dev Panel cannot be opened
    And no new order with providerOrderId "dev-panel-ramps-order" is added to RampsController state

Screenshots/Recordings

n/a

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Large deletion of dev-only UI plus a defensive state migration that
filters known sentinel IDs; no production user paths or live payment
logic changes.

Overview
Removes the internal Navigation Dev Panel (screen, mock params,
Developer Options entry, Routes.NAVIGATION_DEV_PANEL, and
MainNavigator registration) so dev tooling can no longer inject mock
ramp/fiat/bridge data into persisted state.

Adds redux-persist migration 140 to strip sentinel artifacts on
upgrade: dev-panel fiat order IDs, dev-panel-ramps-order in
RampsController, and dev-panel-bridge-tx from bridge history and
transactions. Includes unit tests; production users with no seeded data
are unaffected.

Reviewed by Cursor Bugbot for commit
2555e81. Bugbot is set up for automated
code reviews on this repo. Configure
here.

Co-authored-by: Cursor cursoragent@cursor.com 59970c9

…81.0 (#31188)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->
<!--
mms-check directive vocabulary — read by
.github/scripts/shared/pr-template-checks.ts
at module load to build the validation plan. Directives are invisible in
rendered
markdown and must NOT be removed or edited without updating the
validator registry.

  type=text           Section must contain non-placeholder prose.
  type=changelog      Section must have a valid CHANGELOG entry: line.
type=issue-link Section must have a Fixes:/Closes:/Refs: line with a
value.
type=manual-testing Section must have real testing steps or an explicit
N/A.
type=screenshot Section must have evidence (image/URL) or an explicit
N/A.
type=checklist Section must have all checkboxes consciously checked.
required=true|false Whether a missing/invalid section blocks the PR
check.

Sections without a directive are checked for structural presence only.
-->

<!-- mms-check: type=text required=true -->
Fixes invalid dev-panel-ramps-order traffic hitting the provider's Get
Orders by ID endpoint (500s on LIVE).

The Navigation Dev Panel (internal-only, gated by
MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS) seeded a mock Ramps order into
persisted RampsController state via addOrder():

providerOrderId: dev-panel-ramps-order
provider.id: paypal
That order persisted across launches. On internal/experimental builds
that use the production ramps environment, it reached the provider's
live endpoint with an invalid order ID. This started after the ramps
seed landed in #31037 (~June 4).

Changes:
- Remove the Navigation Dev Panel entirely (component, mock params,
Developer Options entry, route, and references) so nothing can seed
these orders again.
- Add migration 140 to purge dev-panel sentinel artifacts from affected
devices on next launch:
- RampsController.orders → dev-panel-ramps-order (the incident)
fiatOrders.orders → dev-panel-aggregator-order, dev-panel-deposit-order,
dev-panel-sell-order
- BridgeStatusController.txHistory / TransactionController.transactions
→ dev-panel-bridge-tx
Production users were never affected (dev panel not reachable in prod
builds). Migration 140 is a no-op for them and only for RC users.

<!-- mms-check: type=changelog required=true -->

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:null

<!-- mms-check: type=issue-link required=true -->

Fixes: Test seeding ramp with order ID dev-panel-ramps-order bug for
non-production users

<!-- mms-check: type=manual-testing required=true -->

```gherkin
 Background:
    Given the app is built with MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS enabled
    And the user has previously opened the Navigation Dev Panel
    And the user navigated to the Ramps Order Details entry in the panel

Scenario: Navigation Dev Panel is no longer available
    Given the user opens Settings
    And the user opens Developer Options
    Then the "Open Navigation Dev Panel" button is not shown
    And the NavigationDevPanel route is not registered in the navigator

Scenario: Dev panel no longer seeds a mock Ramps order
    Given the user is on Developer Options
    When the user attempts to open the Navigation Dev Panel
    Then the Navigation Dev Panel cannot be opened
    And no new order with providerOrderId "dev-panel-ramps-order" is added to RampsController state
```

<!-- mms-check: type=screenshot required=true -->

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
n/a

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

<!-- mms-check: type=checklist required=true -->

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [x] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [x] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [x] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Large deletion of dev-only UI plus a defensive state migration that
filters known sentinel IDs; no production user paths or live payment
logic changes.
>
> **Overview**
> Removes the internal **Navigation Dev Panel** (screen, mock params,
Developer Options entry, `Routes.NAVIGATION_DEV_PANEL`, and
`MainNavigator` registration) so dev tooling can no longer inject mock
ramp/fiat/bridge data into persisted state.
>
> Adds **redux-persist migration 140** to strip sentinel artifacts on
upgrade: dev-panel fiat order IDs, `dev-panel-ramps-order` in
`RampsController`, and `dev-panel-bridge-tx` from bridge history and
transactions. Includes unit tests; production users with no seeded data
are unaffected.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
2555e81. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor <cursoragent@cursor.com>
@runway-github runway-github Bot requested review from a team as code owners June 8, 2026 18:36
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Jun 8, 2026
@github-actions github-actions Bot added size-M risk:low AI analysis: low risk labels Jun 8, 2026
… cp-7.81.0

The release cherry-pick hit modify/delete conflicts and kept these files; remove them to match the main removal.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

@github-actions github-actions Bot added size-L and removed size-M labels Jun 8, 2026
@runway-github runway-github Bot merged commit bd933d6 into release/7.81.0 Jun 8, 2026
389 of 395 checks passed
@runway-github runway-github Bot deleted the cherry-pick-7-81-0-59970c9 branch June 8, 2026 23:34
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk:low AI analysis: low risk size-L team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants