chore(runway): cherry-pick fix(ramps): remove Navigation Dev Panel and purge seeded orders#31229
Merged
Merged
Conversation
…81.0 (#31188) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> <!-- mms-check directive vocabulary — read by .github/scripts/shared/pr-template-checks.ts at module load to build the validation plan. Directives are invisible in rendered markdown and must NOT be removed or edited without updating the validator registry. type=text Section must contain non-placeholder prose. type=changelog Section must have a valid CHANGELOG entry: line. type=issue-link Section must have a Fixes:/Closes:/Refs: line with a value. type=manual-testing Section must have real testing steps or an explicit N/A. type=screenshot Section must have evidence (image/URL) or an explicit N/A. type=checklist Section must have all checkboxes consciously checked. required=true|false Whether a missing/invalid section blocks the PR check. Sections without a directive are checked for structural presence only. --> <!-- mms-check: type=text required=true --> Fixes invalid dev-panel-ramps-order traffic hitting the provider's Get Orders by ID endpoint (500s on LIVE). The Navigation Dev Panel (internal-only, gated by MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS) seeded a mock Ramps order into persisted RampsController state via addOrder(): providerOrderId: dev-panel-ramps-order provider.id: paypal That order persisted across launches. On internal/experimental builds that use the production ramps environment, it reached the provider's live endpoint with an invalid order ID. This started after the ramps seed landed in #31037 (~June 4). Changes: - Remove the Navigation Dev Panel entirely (component, mock params, Developer Options entry, route, and references) so nothing can seed these orders again. - Add migration 140 to purge dev-panel sentinel artifacts from affected devices on next launch: - RampsController.orders → dev-panel-ramps-order (the incident) fiatOrders.orders → dev-panel-aggregator-order, dev-panel-deposit-order, dev-panel-sell-order - BridgeStatusController.txHistory / TransactionController.transactions → dev-panel-bridge-tx Production users were never affected (dev panel not reachable in prod builds). Migration 140 is a no-op for them and only for RC users. <!-- mms-check: type=changelog required=true --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry:null <!-- mms-check: type=issue-link required=true --> Fixes: Test seeding ramp with order ID dev-panel-ramps-order bug for non-production users <!-- mms-check: type=manual-testing required=true --> ```gherkin Background: Given the app is built with MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS enabled And the user has previously opened the Navigation Dev Panel And the user navigated to the Ramps Order Details entry in the panel Scenario: Navigation Dev Panel is no longer available Given the user opens Settings And the user opens Developer Options Then the "Open Navigation Dev Panel" button is not shown And the NavigationDevPanel route is not registered in the navigator Scenario: Dev panel no longer seeds a mock Ramps order Given the user is on Developer Options When the user attempts to open the Navigation Dev Panel Then the Navigation Dev Panel cannot be opened And no new order with providerOrderId "dev-panel-ramps-order" is added to RampsController state ``` <!-- mms-check: type=screenshot required=true --> <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> n/a <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> <!-- mms-check: type=checklist required=true --> <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Large deletion of dev-only UI plus a defensive state migration that filters known sentinel IDs; no production user paths or live payment logic changes. > > **Overview** > Removes the internal **Navigation Dev Panel** (screen, mock params, Developer Options entry, `Routes.NAVIGATION_DEV_PANEL`, and `MainNavigator` registration) so dev tooling can no longer inject mock ramp/fiat/bridge data into persisted state. > > Adds **redux-persist migration 140** to strip sentinel artifacts on upgrade: dev-panel fiat order IDs, `dev-panel-ramps-order` in `RampsController`, and `dev-panel-bridge-tx` from bridge history and transactions. Includes unit tests; production users with no seeded data are unaffected. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 2555e81. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
… cp-7.81.0 The release cherry-pick hit modify/delete conflicts and kept these files; remove them to match the main removal. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
vpintorico
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes invalid dev-panel-ramps-order traffic hitting the provider's Get
Orders by ID endpoint (500s on LIVE).
The Navigation Dev Panel (internal-only, gated by
MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS) seeded a mock Ramps order into
persisted RampsController state via addOrder():
providerOrderId: dev-panel-ramps-order
provider.id: paypal
That order persisted across launches. On internal/experimental builds
that use the production ramps environment, it reached the provider's
live endpoint with an invalid order ID. This started after the ramps
seed landed in #31037 (~June 4).
Changes:
Developer Options entry, route, and references) so nothing can seed
these orders again.
devices on next launch:
fiatOrders.orders → dev-panel-aggregator-order, dev-panel-deposit-order,
dev-panel-sell-order
→ dev-panel-bridge-tx
Production users were never affected (dev panel not reachable in prod
builds). Migration 140 is a no-op for them and only for RC users.
Changelog
CHANGELOG entry:null
Related issues
Fixes: Test seeding ramp with order ID dev-panel-ramps-order bug for
non-production users
Manual testing steps
Screenshots/Recordings
n/a
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Large deletion of dev-only UI plus a defensive state migration that
filters known sentinel IDs; no production user paths or live payment
logic changes.
Overview
Removes the internal Navigation Dev Panel (screen, mock params,
Developer Options entry,
Routes.NAVIGATION_DEV_PANEL, andMainNavigatorregistration) so dev tooling can no longer inject mockramp/fiat/bridge data into persisted state.
Adds redux-persist migration 140 to strip sentinel artifacts on
upgrade: dev-panel fiat order IDs,
dev-panel-ramps-orderinRampsController, anddev-panel-bridge-txfrom bridge history andtransactions. Includes unit tests; production users with no seeded data
are unaffected.
Reviewed by Cursor Bugbot for commit
2555e81. Bugbot is set up for automated
code reviews on this repo. Configure
here.
Co-authored-by: Cursor cursoragent@cursor.com 59970c9