fix(ramps): remove Navigation Dev Panel and purge seeded orders cp-7.81.0#31188
Merged
Conversation
The Navigation Dev Panel seeded a mock Ramps order (provider `paypal`, providerOrderId `dev-panel-ramps-order`) directly into persisted RampsController state via `addOrder`, along with mock fiat orders and a bridge transaction. On internal/experimental builds that point at the production ramps environment, this synthetic order reached the provider's "Get Orders by ID" endpoint and caused 500s (invalid order ID). - Remove the NavigationDevPanel feature (component, mock params, settings section, route, and all references) so nothing can seed these orders. - Add migration 140 to scrub the sentinel artifacts (ramps order, the three dev-panel fiat orders, and the bridge tx/history) from affected devices on next launch. No-op for production users, which never had this data. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
amitabh94
approved these changes
Jun 7, 2026
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
wachunei
approved these changes
Jun 8, 2026
tommasini
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes invalid dev-panel-ramps-order traffic hitting the provider's Get Orders by ID endpoint (500s on LIVE).
The Navigation Dev Panel (internal-only, gated by MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS) seeded a mock Ramps order into persisted RampsController state via addOrder():
providerOrderId: dev-panel-ramps-order
provider.id: paypal
That order persisted across launches. On internal/experimental builds that use the production ramps environment, it reached the provider's live endpoint with an invalid order ID. This started after the ramps seed landed in #31037 (~June 4).
Changes:
fiatOrders.orders → dev-panel-aggregator-order, dev-panel-deposit-order, dev-panel-sell-order
Production users were never affected (dev panel not reachable in prod builds). Migration 140 is a no-op for them and only for RC users.
Changelog
CHANGELOG entry:null
Related issues
Fixes: Test seeding ramp with order ID dev-panel-ramps-order bug for non-production users
Manual testing steps
Screenshots/Recordings
n/a
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Large deletion of dev-only UI plus a defensive state migration that filters known sentinel IDs; no production user paths or live payment logic changes.
Overview
Removes the internal Navigation Dev Panel (screen, mock params, Developer Options entry,
Routes.NAVIGATION_DEV_PANEL, andMainNavigatorregistration) so dev tooling can no longer inject mock ramp/fiat/bridge data into persisted state.Adds redux-persist migration 140 to strip sentinel artifacts on upgrade: dev-panel fiat order IDs,
dev-panel-ramps-orderinRampsController, anddev-panel-bridge-txfrom bridge history and transactions. Includes unit tests; production users with no seeded data are unaffected.Reviewed by Cursor Bugbot for commit 2555e81. Bugbot is set up for automated code reviews on this repo. Configure here.