Skip to content

chore(runway): cherry-pick fix: metamask pay failures due to incorrect token balance#30969

Merged
tommasini merged 1 commit into
release/7.80.0from
cherry-pick-7-80-0-f764558
Jun 2, 2026
Merged

chore(runway): cherry-pick fix: metamask pay failures due to incorrect token balance#30969
tommasini merged 1 commit into
release/7.80.0from
cherry-pick-7-80-0-f764558

Conversation

@runway-github

@runway-github runway-github Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Description

Bumps @metamask/transaction-pay-controller to ^23.0.0. The breaking
change in this release requires the
NetworkController:getNetworkConfigurationByChainId action to be
delegated on the TransactionPayControllerMessenger and
TransactionControllerInitMessenger.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #30798

Manual testing steps

Covered by existing Pay E2E flows — no new behaviour introduced.

Screenshots/Recordings

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Narrow dependency bump plus messenger wiring with no new app business
logic; Pay E2E is expected to cover regressions.

Overview
Upgrades @metamask/transaction-pay-controller from 22.8.0 to
23.0.0 (lockfile included) so MetaMask Pay picks up the fix for
incorrect token balance behavior described in the release.

The mobile app wires the new v23 messenger requirement by
delegating NetworkController:getNetworkConfigurationByChainId on
the Transaction Pay controller messenger (runtime and init) and on
TransactionControllerInit messenger, so Pay and transaction init
paths can read per-chain network configuration at runtime.

No application logic beyond messenger delegation and the dependency
bump; behavior change lives in the upgraded package.

Reviewed by Cursor Bugbot for commit
1f7dbbe. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[f764558](https://github.com/MetaMask/metamask-mobile/commit/f76455865d49dcf89e92aa3e486656b9bf17ac37)

…30877)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

Bumps `@metamask/transaction-pay-controller` to `^23.0.0`. The breaking
change in this release requires the
`NetworkController:getNetworkConfigurationByChainId` action to be
delegated on the `TransactionPayControllerMessenger` and
`TransactionControllerInitMessenger`.

CHANGELOG entry: null

Fixes: #30798

Covered by existing Pay E2E flows — no new behaviour introduced.

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Narrow dependency bump plus messenger wiring with no new app business
logic; Pay E2E is expected to cover regressions.
>
> **Overview**
> Upgrades **`@metamask/transaction-pay-controller`** from **22.8.0** to
**23.0.0** (lockfile included) so MetaMask Pay picks up the fix for
incorrect token balance behavior described in the release.
>
> The mobile app wires the new **v23** messenger requirement by
delegating **`NetworkController:getNetworkConfigurationByChainId`** on
the **Transaction Pay** controller messenger (runtime and init) and on
**`TransactionControllerInit`** messenger, so Pay and transaction init
paths can read per-chain network configuration at runtime.
>
> No application logic beyond messenger delegation and the dependency
bump; behavior change lives in the upgraded package.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
1f7dbbe. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner June 2, 2026 19:52
@mm-token-exchange-service mm-token-exchange-service Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

@socket-security

Copy link
Copy Markdown

@tommasini tommasini merged commit d89dbbf into release/7.80.0 Jun 2, 2026
207 of 213 checks passed
@tommasini tommasini deleted the cherry-pick-7-80-0-f764558 branch June 2, 2026 23:19
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants