chore(runway): cherry-pick fix: metamask pay failures due to incorrect token balance#30969
Merged
Merged
Conversation
…30877) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> Bumps `@metamask/transaction-pay-controller` to `^23.0.0`. The breaking change in this release requires the `NetworkController:getNetworkConfigurationByChainId` action to be delegated on the `TransactionPayControllerMessenger` and `TransactionControllerInitMessenger`. CHANGELOG entry: null Fixes: #30798 Covered by existing Pay E2E flows — no new behaviour introduced. - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Narrow dependency bump plus messenger wiring with no new app business logic; Pay E2E is expected to cover regressions. > > **Overview** > Upgrades **`@metamask/transaction-pay-controller`** from **22.8.0** to **23.0.0** (lockfile included) so MetaMask Pay picks up the fix for incorrect token balance behavior described in the release. > > The mobile app wires the new **v23** messenger requirement by delegating **`NetworkController:getNetworkConfigurationByChainId`** on the **Transaction Pay** controller messenger (runtime and init) and on **`TransactionControllerInit`** messenger, so Pay and transaction init paths can read per-chain network configuration at runtime. > > No application logic beyond messenger delegation and the dependency bump; behavior change lives in the upgraded package. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1f7dbbe. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
@metamask/transaction-pay-controllerto^23.0.0. The breakingchange in this release requires the
NetworkController:getNetworkConfigurationByChainIdaction to bedelegated on the
TransactionPayControllerMessengerandTransactionControllerInitMessenger.Changelog
CHANGELOG entry: null
Related issues
Fixes: #30798
Manual testing steps
Covered by existing Pay E2E flows — no new behaviour introduced.
Screenshots/Recordings
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Narrow dependency bump plus messenger wiring with no new app business
logic; Pay E2E is expected to cover regressions.
Overview
Upgrades
@metamask/transaction-pay-controllerfrom 22.8.0 to23.0.0 (lockfile included) so MetaMask Pay picks up the fix for
incorrect token balance behavior described in the release.
The mobile app wires the new v23 messenger requirement by
delegating
NetworkController:getNetworkConfigurationByChainIdonthe Transaction Pay controller messenger (runtime and init) and on
TransactionControllerInitmessenger, so Pay and transaction initpaths can read per-chain network configuration at runtime.
No application logic beyond messenger delegation and the dependency
bump; behavior change lives in the upgraded package.
Reviewed by Cursor Bugbot for commit
1f7dbbe. Bugbot is set up for automated
code reviews on this repo. Configure
here.