fix: cp-7.80.0 metamask pay failures due to incorrect token balance#30877
Merged
Conversation
41fc51a to
cb5157b
Compare
cb5157b to
d0cc584
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30877 +/- ##
==========================================
+ Coverage 82.66% 82.68% +0.02%
==========================================
Files 5551 5560 +9
Lines 142775 142975 +200
Branches 32957 33017 +60
==========================================
+ Hits 118026 118224 +198
+ Misses 16890 16879 -11
- Partials 7859 7872 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The 23.0.0 breaking change requires clients to allow the NetworkController:getNetworkConfigurationByChainId action on the TransactionPayControllerMessenger so live token balance queries can prefer the chain's Infura endpoint. Added to both TransactionPayControllerMessenger and TransactionControllerInitMessenger (the latter is cast as TransactionPayControllerMessenger inside the publish hook). Fixes #30798
a3686bf to
1f7dbbe
Compare
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
OGPoyraz
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
@metamask/transaction-pay-controllerto^23.0.0. The breaking change in this release requires theNetworkController:getNetworkConfigurationByChainIdaction to be delegated on theTransactionPayControllerMessengerandTransactionControllerInitMessenger.Changelog
CHANGELOG entry: null
Related issues
Fixes: #30798
Manual testing steps
Covered by existing Pay E2E flows — no new behaviour introduced.
Screenshots/Recordings
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Narrow dependency bump plus messenger wiring with no new app business logic; Pay E2E is expected to cover regressions.
Overview
Upgrades
@metamask/transaction-pay-controllerfrom 22.8.0 to 23.0.0 (lockfile included) so MetaMask Pay picks up the fix for incorrect token balance behavior described in the release.The mobile app wires the new v23 messenger requirement by delegating
NetworkController:getNetworkConfigurationByChainIdon the Transaction Pay controller messenger (runtime and init) and onTransactionControllerInitmessenger, so Pay and transaction init paths can read per-chain network configuration at runtime.No application logic beyond messenger delegation and the dependency bump; behavior change lives in the upgraded package.
Reviewed by Cursor Bugbot for commit 1f7dbbe. Bugbot is set up for automated code reviews on this repo. Configure here.