fix: android crash for new social login users cp-7.79.0#30775
Merged
Conversation
Cherry-pick of #30765 with manual conflict resolution. Skips success animation on Android for seedless onboarding flow to prevent crash. Co-Authored-By: Gaurav Goel <grvgoel19@gmail.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2a9309d. Configure here.
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
Contributor
Author
|
policy-bot: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of #30765 with manual conflict resolution.
Skips success animation on Android for seedless onboarding flow to prevent crash on new social login users.
Changes
SEEDLESS_ONBOARDINGtoONBOARDING_SUCCESS_FLOWenumOriginal PR
#30765
CHANGELOG entry: null
Note
Low Risk
Targeted UI/navigation guard on Android for one onboarding flow; no auth or wallet-core logic changes beyond existing success-flow routing.
Overview
Fixes an Android crash when new social (seedless) login users finish password setup by skipping the Rive-based onboarding success animation on that platform for the new flow.
Choose Password now resets navigation to Onboarding Success with
successFlow: SEEDLESS_ONBOARDINGinstead ofshowPasswordHint: true, and a matchingSEEDLESS_ONBOARDINGvalue is added toONBOARDING_SUCCESS_FLOW. Onboarding Success conditionally omitsOnboardingSuccessEndAnimationwhenPlatform.OS === 'android'and the flow is seedless. Wallet home onboarding steps eligibility treats seedless onboarding like other first-time completion flows, with tests updated.Reviewed by Cursor Bugbot for commit a1ce648. Bugbot is set up for automated code reviews on this repo. Configure here.