Skip to content

fix: android crash for new social login users cp-7.79.0#30765

Merged
grvgoel81 merged 7 commits into
mainfrom
release_bug_testing
May 28, 2026
Merged

fix: android crash for new social login users cp-7.79.0#30765
grvgoel81 merged 7 commits into
mainfrom
release_bug_testing

Conversation

@grvgoel81

@grvgoel81 grvgoel81 commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • This PR removes the onboarding success animation for Android social-login users to prevent a crash observed shortly after wallet creation

Changelog

CHANGELOG entry: Fixed a crash affecting some Android social-login users by removing the onboarding success animation in that flow.

Related issues

Fixes: #30737

Manual testing steps

Feature: Android social onboarding success stability

  Scenario: Android social user reaches onboarding success
    Given user is on Android and signs up via social login
    When user completes wallet creation and lands on onboarding success
    Then the onboarding success animation should not render
    And the app should not crash

Screenshots/Recordings

Before

599436551-4e8b0ff7-faaa-482d-993b-5f67eb236f30.mp4

After

2026-05-29.00.32.34.mp4

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Targeted UI guard on an existing onboarding screen; no auth, key material, or navigation reset logic changes beyond skipping one animation.

Overview
Skips the onboarding success end animation on Android when navigation passes showPasswordHint: true (the social-login path from ChoosePassword). The screen still shows the success title and actions; only OnboardingSuccessEndAnimation is omitted for that platform/flag combination.

A new optional route param and component prop wire showPasswordHint from the navigator into OnboardingSuccessComponent, with Platform.OS used to gate the animation.

Reviewed by Cursor Bugbot for commit e352fa2. Configure here.

@grvgoel81 grvgoel81 self-assigned this May 28, 2026
@grvgoel81 grvgoel81 requested a review from a team as a code owner May 28, 2026 18:44
@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-onboarding Onboarding team label May 28, 2026
ieow
ieow previously approved these changes May 28, 2026
View reviewed changes

@ieow ieow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSeedlessOnboarding
  • Selected Performance tags: @PerformanceOnboarding
  • Risk Level: medium
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are focused on the seedless onboarding flow:

  1. ONBOARDING_SUCCESS_FLOW.SEEDLESS_ONBOARDING enum value added: New constant used to identify the seedless onboarding path through the success screen.

  2. ChoosePassword/index.tsx: The navigation to OnboardingSuccess now passes successFlow: ONBOARDING_SUCCESS_FLOW.SEEDLESS_ONBOARDING instead of showPasswordHint: true. This is the password creation step in the seedless (social login) onboarding flow.

  3. OnboardingSuccess/index.tsx: Added Android-specific logic to skip the OnboardingSuccessEndAnimation when the flow is SEEDLESS_ONBOARDING. This is a platform-specific UI fix for Android.

  4. walletHomeOnboardingStepsEligibility.ts: The SEEDLESS_ONBOARDING flow now marks wallet home onboarding steps as eligible, ensuring users who onboard via social login get the proper onboarding step prompts.

These changes directly affect the seedless onboarding flow (Google/Apple social login). The SmokeSeedlessOnboarding tag covers all relevant E2E tests: Google Login New User, Apple Login New User, Google Login Existing User, Apple Login Existing User, Google Login Lock/Unlock, Google Login Reset Wallet, and Google Login Add SRP. These tests exercise the full onboarding flow including the ChoosePassword and OnboardingSuccess screens.

No other tags are needed as the changes are isolated to the seedless onboarding path and don't affect core wallet functionality, confirmations, swaps, or other features.

Performance Test Selection:
The OnboardingSuccess screen is used in performance test specs for seedless onboarding (seedless-google-onboarding.spec.ts, seedless-apple-onboarding.spec.ts). The change to conditionally skip the OnboardingSuccessEndAnimation on Android for the seedless flow could affect onboarding performance timing measurements. Running @PerformanceOnboarding ensures the animation skip doesn't negatively impact the measured onboarding flow performance.

View GitHub Actions results

@grvgoel81 grvgoel81 enabled auto-merge May 28, 2026 20:06
@grvgoel81 grvgoel81 added this pull request to the merge queue May 28, 2026
@grvgoel81 grvgoel81 changed the title fix: android crash for new social login users fix: android crash for new social login users cp-7.79.0 May 28, 2026
Merged via the queue into main with commit 7602aff May 28, 2026
186 of 192 checks passed
@grvgoel81 grvgoel81 deleted the release_bug_testing branch May 28, 2026 20:30
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.81.0 Issue or pull request that will be included in release 7.81.0 label May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@himanshuchawla009 himanshuchawla009 himanshuchawla009 approved these changes

@ieow ieow ieow left review comments

Assignees

@grvgoel81 grvgoel81

Labels

release-7.81.0 Issue or pull request that will be included in release 7.81.0 size-S team-onboarding Onboarding team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Seedless onboarding: tapping Done on Wallet Created opens Chrome Downloads instead of staying in app

3 participants

@grvgoel81 @ieow @himanshuchawla009