chore(runway): cherry-pick chore: bump @metamask/tron-wallet-snap to 1.25.6#30768
Merged
Conversation
This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` n/a ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches Tron signing and broadcast behavior via the wallet snap; scope is limited to a patch dependency bump with no local code edits, but failed or incorrect ref-block handling could still affect Tron sends. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to `^1.25.6` in `package.json` and `yarn.lock`, with an **Unreleased** changelog entry. There are **no application source changes** in this repo—the mobile app picks up upstream snap behavior from the new package version. > > Per the PR intent, **1.25.6** brings Tron transaction validation fixes, notably **refreshing stale or invalid `expiration`, `ref_block_bytes`, and `ref_block_hash` before signing** on send and broadcast paths. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b958d77. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com>
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vpintorico
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@metamask/tron-wallet-snapto1.25.6(chore: bump@metamask/tron-wallet-snapto1.25.6#30200)Description
This PR bumps @metamask/tron-wallet-snap from
^1.25.3to^1.25.6.The main purpose of this update is to pull in the latest Tron snap
validation fixes, in particular a mechanism to refresh stale or invalid
expiration,ref_block_bytesandref_block_hashbefore signing inboth send/broadcast paths.
Preview package:
@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5Release:
@metamask-previews/tron-wallet-snap@^1.25.6Upstream PR:
Changelog
CHANGELOG entry: bump the
@metamask/tron-wallet-snapto^1.25.6Related issues
n/a
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Touches Tron signing and broadcast behavior via the wallet snap; scope
is limited to a patch dependency bump with no local code edits, but
failed or incorrect ref-block handling could still affect Tron sends.
Overview
Bumps
@metamask/tron-wallet-snapfrom^1.25.3to^1.25.6inpackage.jsonandyarn.lock, with an Unreleased changelog entry.There are no application source changes in this repo—the mobile app
picks up upstream snap behavior from the new package version.
Per the PR intent, 1.25.6 brings Tron transaction validation
fixes, notably refreshing stale or invalid
expiration,ref_block_bytes, andref_block_hashbefore signing on send andbroadcast paths.
Reviewed by Cursor Bugbot for commit
b958d77. Bugbot is set up for automated
code reviews on this repo. Configure
here.
Co-authored-by: gabrieledm gabriele.delmonte@proton.me
Co-authored-by: Gabriele Del Monte 37625739+gabrieledm@users.noreply.github.com 2bb066b