Skip to content

chore: bump @metamask/tron-wallet-snap to 1.25.6#30200

Merged
gabrieledm merged 27 commits into
mainfrom
chore/release-tron-snap-version-1.25.3-preview-995ddc5
May 28, 2026
Merged

chore: bump @metamask/tron-wallet-snap to 1.25.6#30200
gabrieledm merged 27 commits into
mainfrom
chore/release-tron-snap-version-1.25.3-preview-995ddc5

Conversation

@ulissesferreira

@ulissesferreira ulissesferreira commented May 14, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

This PR bumps @metamask/tron-wallet-snap from ^1.25.3 to ^1.25.6.

The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid expiration, ref_block_bytes and ref_block_hash before signing in both send/broadcast paths.

Preview package:

  • @metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5

Release:

  • @metamask-previews/tron-wallet-snap@^1.25.6

Upstream PR:

Changelog

CHANGELOG entry: bump the @metamask/tron-wallet-snap to ^1.25.6

Related issues

n/a

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches Tron signing and broadcast behavior via the wallet snap; scope is limited to a patch dependency bump with no local code edits, but failed or incorrect ref-block handling could still affect Tron sends.

Overview
Bumps @metamask/tron-wallet-snap from ^1.25.3 to ^1.25.6 in package.json and yarn.lock, with an Unreleased changelog entry. There are no application source changes in this repo—the mobile app picks up upstream snap behavior from the new package version.

Per the PR intent, 1.25.6 brings Tron transaction validation fixes, notably refreshing stale or invalid expiration, ref_block_bytes, and ref_block_hash before signing on send and broadcast paths.

Reviewed by Cursor Bugbot for commit b958d77. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added team-networks Networks team INVALID-PR-TEMPLATE PR's body doesn't match template labels May 14, 2026
@gabrieledm gabrieledm changed the title chore: bump @metamask/tron-wallet-snap to 1.25.3-preview-995ddc5 chore: bump @metamask/tron-wallet-snap to 1.25.4-preview-20f5407 May 21, 2026
@gabrieledm gabrieledm changed the title chore: bump @metamask/tron-wallet-snap to 1.25.4-preview-20f5407 chore: bump @metamask/tron-wallet-snap to 1.25.6 May 22, 2026
@socket-security

socket-security Bot commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​tron-wallet-snap@​1.25.3 ⏵ 1.25.61001009698 +1100

View full report

@gabrieledm gabrieledm marked this pull request as ready for review May 25, 2026 07:46
@codecov-commenter

codecov-commenter commented May 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.27%. Comparing base (65cbeec) to head (c853c15).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #30200      +/-   ##
==========================================
- Coverage   82.28%   82.27%   -0.01%     
==========================================
  Files        5522     5522              
  Lines      148790   148804      +14     
  Branches    34280    34289       +9     
==========================================
+ Hits       122430   122431       +1     
- Misses      18030    18032       +2     
- Partials     8330     8341      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabrieledm gabrieledm removed the INVALID-PR-TEMPLATE PR's body doesn't match template label May 27, 2026
@metamaskbotv2 metamaskbotv2 Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 27, 2026
@gabrieledm gabrieledm removed the INVALID-PR-TEMPLATE PR's body doesn't match template label May 27, 2026
@metamaskbotv2 metamaskbotv2 Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 27, 2026
@gabrieledm gabrieledm removed the INVALID-PR-TEMPLATE PR's body doesn't match template label May 27, 2026
@metamaskbotv2 metamaskbotv2 Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 27, 2026
@gabrieledm gabrieledm enabled auto-merge May 28, 2026 12:05
@gabrieledm gabrieledm mentioned this pull request May 28, 2026
Closed
10 tasks
@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSnaps, SmokeStake
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR only bumps @metamask/tron-wallet-snap from ^1.25.3 to ^1.25.6 (a patch/minor version update), with supporting CHANGELOG.md and yarn.lock updates.

Key findings:

  1. Feature-flagged: The Tron wallet snap is entirely gated behind ///: BEGIN:ONLY_INCLUDE_IF(tron) build flags throughout the codebase (preinstalled-snaps.ts, TronWalletSnap.ts, AddAccountActions.tsx, etc.), meaning it's NOT included in standard builds used for E2E testing.
  2. No Tron E2E tests: There are zero Tron-specific E2E test files (.e2e.ts or .e2e.js).
  3. Preinstalled snap: The snap is registered as a preinstalled snap, which could theoretically affect snap infrastructure initialization.
  4. Low risk: This is a minor version bump (1.25.3 → 1.25.6) with no app code changes.

Selected tags rationale:

  • SmokeSnaps: The tron-wallet-snap is a preinstalled snap. Even though it's feature-flagged, the snap infrastructure (preinstalled-snaps.ts) is shared. Running SmokeSnaps validates that the snap system still works correctly after the dependency update.
  • SmokeStake: The snap is used in Earn/staking flows (useTronStake, useTronUnstake, useTronClaimUnstakedTrx hooks), so running stake tests provides coverage for any potential regression in the staking infrastructure.

No performance tests are needed as this is a dependency version bump with no UI rendering, state management, or performance-critical code changes.

Performance Test Selection:
This is a minor version bump of a feature-flagged snap dependency with no changes to UI rendering, state management, data loading, or performance-critical code paths. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 28, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gabrieledm gabrieledm added this pull request to the merge queue May 28, 2026
Merged via the queue into main with commit 2bb066b May 28, 2026
193 of 195 checks passed
@gabrieledm gabrieledm deleted the chore/release-tron-snap-version-1.25.3-preview-995ddc5 branch May 28, 2026 13:14
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.80.0 Issue or pull request that will be included in release 7.80.0 label May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.80.0 Issue or pull request that will be included in release 7.80.0 size-XS team-networks Networks team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ulissesferreira @codecov-commenter @andrepimenta @gabrieledm