Skip to content

chore(runway): cherry-pick fix: explore search v2 issues cp-7.79.0#30688

Merged
joaoloureirop merged 1 commit into
release/7.79.0from
runway-cherry-pick-7.79.0-1779892881
May 27, 2026
Merged

chore(runway): cherry-pick fix: explore search v2 issues cp-7.79.0#30688
joaoloureirop merged 1 commit into
release/7.79.0from
runway-cherry-pick-7.79.0-1779892881

Conversation

@runway-github

@runway-github runway-github Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Description

  • Fix explore search v2 issues:
  • Cryptos -> Crypto
  • "View all" wont show in the loading state
  • "View all" stays on the no_query state
  • When there is a query:
    • "View X more" will be shown only if there are more than 3 items
    • Every section with less than 3 items does not show "View all"
  • When there are no results we should show the correct empty state with
    the pills
  • If there are no results for all sections we do not show "We found
    these results for "Btcx""

Changelog

CHANGELOG entry: fix explore search v2 issues

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3272

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
UI and label logic in Explore search with broad test updates; no auth,
payments, or security-sensitive paths.

Overview
Explore Search v2 UX fixes: Crypto tab copy (was “Cryptos”),
smarter View all / View more behavior, richer empty states, and
a custom search placeholder overlay.

Section actions: getViewMoreLabel now returns null when
there’s nothing beyond the 3-item cap (with an active query), so headers
hide the control instead of showing misleading “View all”. Loading
sections skip the button entirely. With no query, labels still use
View all. With a query, View X more appears only when counts
justify it; tokens without a server total can still fall back to View
all
.

Empty results: When every section is empty, the list shows a
global “no results” message, optional BTC/ETH/SOL quick pills, and
only shows the “other results” line when some sections still have hits
(with a count in copy). Per-feed empty states keep the feed-specific
message.

Search bar: Interactive mode uses an empty native placeholder plus
a non-interactive overlay for alignment; tests target
EXPLORE_VIEW_SEARCH_TEXT_INPUT instead of placeholder text.

Reviewed by Cursor Bugbot for commit
906285a. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[596aadf](https://github.com/MetaMask/metamask-mobile/commit/596aadfccb50599f302e94bd12a6d7f142468aad)

…30677)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

## **Description**

- Fix explore search v2 issues:
- Cryptos -> Crypto
- "View all" wont show in the loading state
- "View all" stays on the no_query state
- When there is a query:
  - "View X more" will be shown only if there are more than 3 items
  - Every section with less than 3 items does not show "View all"
- When there are no results we should show the correct empty state with
the pills
- If there are no results for all sections we do not show "We found
these results for "Btcx""

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: fix explore search v2 issues

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3272


## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> UI and label logic in Explore search with broad test updates; no auth,
payments, or security-sensitive paths.
> 
> **Overview**
> Explore Search v2 UX fixes: **Crypto** tab copy (was “Cryptos”),
smarter **View all / View more** behavior, richer **empty states**, and
a **custom search placeholder** overlay.
> 
> **Section actions:** `getViewMoreLabel` now returns `null` when
there’s nothing beyond the 3-item cap (with an active query), so headers
hide the control instead of showing misleading “View all”. Loading
sections skip the button entirely. With **no** query, labels still use
**View all**. With a query, **View X more** appears only when counts
justify it; tokens without a server total can still fall back to **View
all**.
> 
> **Empty results:** When every section is empty, the list shows a
global “no results” message, optional **BTC/ETH/SOL** quick pills, and
only shows the “other results” line when some sections still have hits
(with a `count` in copy). Per-feed empty states keep the feed-specific
message.
> 
> **Search bar:** Interactive mode uses an empty native placeholder plus
a non-interactive overlay for alignment; tests target
`EXPLORE_VIEW_SEARCH_TEXT_INPUT` instead of placeholder text.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
906285a. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label May 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@joaoloureirop joaoloureirop enabled auto-merge (squash) May 27, 2026 15:56
@joaoloureirop joaoloureirop merged commit bddeb61 into release/7.79.0 May 27, 2026
208 of 210 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.79.0-1779892881 branch May 27, 2026 16:01
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants