Skip to content

fix: explore search v2 issues cp-7.79.0#30677

Merged
juanmigdr merged 16 commits into
mainfrom
fix/explore-v2-issues
May 27, 2026
Merged

fix: explore search v2 issues cp-7.79.0#30677
juanmigdr merged 16 commits into
mainfrom
fix/explore-v2-issues

Conversation

@juanmigdr

@juanmigdr juanmigdr commented May 27, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Member

Description

  • Fix explore search v2 issues:
  • Cryptos -> Crypto
  • "View all" wont show in the loading state
  • "View all" stays on the no_query state
  • When there is a query:
    • "View X more" will be shown only if there are more than 3 items
    • Every section with less than 3 items does not show "View all"
  • When there are no results we should show the correct empty state with the pills
  • If there are no results for all sections we do not show "We found these results for "Btcx""

Changelog

CHANGELOG entry: fix explore search v2 issues

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3272

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI and label logic in Explore search with broad test updates; no auth, payments, or security-sensitive paths.

Overview
Explore Search v2 UX fixes: Crypto tab copy (was “Cryptos”), smarter View all / View more behavior, richer empty states, and a custom search placeholder overlay.

Section actions: getViewMoreLabel now returns null when there’s nothing beyond the 3-item cap (with an active query), so headers hide the control instead of showing misleading “View all”. Loading sections skip the button entirely. With no query, labels still use View all. With a query, View X more appears only when counts justify it; tokens without a server total can still fall back to View all.

Empty results: When every section is empty, the list shows a global “no results” message, optional BTC/ETH/SOL quick pills, and only shows the “other results” line when some sections still have hits (with a count in copy). Per-feed empty states keep the feed-specific message.

Search bar: Interactive mode uses an empty native placeholder plus a non-interactive overlay for alignment; tests target EXPLORE_VIEW_SEARCH_TEXT_INPUT instead of placeholder text.

Reviewed by Cursor Bugbot for commit 906285a. Bugbot is set up for automated code reviews on this repo. Configure here.

@juanmigdr juanmigdr enabled auto-merge May 27, 2026 12:11
cursor[bot]
cursor Bot reviewed May 27, 2026
View reviewed changes
Comment thread locales/languages/en.json Outdated
Comment thread app/components/Views/TrendingView/search/ExploreSearchResultsV2.test.ts
cursor[bot]
cursor Bot reviewed May 27, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2b40851. Configure here.

Comment thread app/components/Views/TrendingView/search/viewMoreLabel.ts
Comment thread app/components/Views/TrendingView/search/viewMoreLabel.ts
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
All changes are confined to the TrendingView's Explore Search functionality:

  1. ExploreSearchBar.tsx: UI fix for placeholder text display (custom overlay, numberOfLines, flex-1 for truncation prevention). No logic changes to navigation or core wallet features.

  2. ExploreSearchResultsV2.tsx: Improved empty state UI (shows popular assets BTC/ETH/SOL when no results), conditional "View more" button rendering (null when not needed), better result count display. These are search result presentation improvements.

  3. viewMoreLabel.ts: Logic change - getViewMoreLabel now returns null instead of always returning a string, allowing callers to conditionally render the button. This is a contained utility function change.

  4. locales/en.json: New strings for no-results states, updated "Cryptos" → "Crypto" label, updated showing_all_results_for to include count.

  5. ExploreSearchScreen.testIds.ts: Comment-only update.

  6. Test files: Unit test updates matching the above changes.

Tag selection rationale:

  • SmokeWalletPlatform: The Trending tab is explicitly covered by this tag, including the search functionality, browsing content feeds (Tokens, Perps, Predictions, Sites sections), and browser navigation integration. The changes directly affect the Trending/Explore search experience.

No other tags are needed since:

  • Changes don't touch confirmations, swaps, staking, accounts, identity, network management, snaps, browser, or any other feature areas
  • The changes are UI/UX improvements to search within Trending, not core wallet functionality
  • No performance-sensitive code paths are modified (no list rendering changes, no state management changes, no API call changes)

Performance Test Selection:
The changes are limited to UI presentation improvements in the TrendingView search feature: a placeholder overlay fix, conditional button rendering, and empty state improvements. These are minor UI changes that don't introduce new list rendering, heavy state management, or API call patterns that would meaningfully impact performance metrics. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 27, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@juanmigdr juanmigdr added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit 596aadf May 27, 2026
189 of 190 checks passed
@juanmigdr juanmigdr deleted the fix/explore-v2-issues branch May 27, 2026 14:28
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.80.0 Issue or pull request that will be included in release 7.80.0 label May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@bergarces bergarces bergarces approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees

No one assigned

Labels

release-7.80.0 Issue or pull request that will be included in release 7.80.0 size-M team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juanmigdr @bergarces @Prithpal-Sooriya