Skip to content

chore(runway): cherry-pick fix: gate Social AI notification settings & bump notification-services-controller to 24.1.1#30629

Merged
joaoloureirop merged 2 commits into
release/7.79.0from
runway-cherry-pick-7.79.0-1779798877
May 26, 2026
Merged

chore(runway): cherry-pick fix: gate Social AI notification settings & bump notification-services-controller to 24.1.1#30629
joaoloureirop merged 2 commits into
release/7.79.0from
runway-cherry-pick-7.79.0-1779798877

Conversation

@runway-github

@runway-github runway-github Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Description

Ensure the project uses the newer
@metamask/notification-services-controller version and prevent Social
AI notification controls from showing when the Social Leaderboard
feature is disabled.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/GE-244

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk: UI visibility is now controlled by an existing remote
feature flag and changes are covered by updated tests; dependency bump
may have minor integration fallout but is limited in scope.

Overview
Gates the Social AI notification settings section so it only
appears when the aiSocialLeaderboardEnabled remote feature flag is
enabled (via selectSocialLeaderboardEnabled).

Updates unit/component-view tests and notification-state presets to
cover both flag states, and adjusts the user-storage mock defaults for
marketing.inAppNotificationsEnabled.

Bumps @metamask/notification-services-controller to 24.1.1 (and
updates lockfile accordingly).

Reviewed by Cursor Bugbot for commit
445bca5. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[a0b59b8](https://github.com/MetaMask/metamask-mobile/commit/a0b59b8dd9f0285cdf63a933a28c9e192f0d9332)

…& bump notification-services-controller to 24.1.1 (#30528)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Ensure the project uses the newer
`@metamask/notification-services-controller` version and prevent Social
AI notification controls from showing when the Social Leaderboard
feature is disabled.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/GE-244

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: UI visibility is now controlled by an existing remote
feature flag and changes are covered by updated tests; dependency bump
may have minor integration fallout but is limited in scope.
> 
> **Overview**
> **Gates the Social AI notification settings section** so it only
appears when the `aiSocialLeaderboardEnabled` remote feature flag is
enabled (via `selectSocialLeaderboardEnabled`).
> 
> Updates unit/component-view tests and notification-state presets to
cover both flag states, and adjusts the user-storage mock defaults for
`marketing.inAppNotificationsEnabled`.
> 
> Bumps `@metamask/notification-services-controller` to `24.1.1` (and
updates lockfile accordingly).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
445bca5. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested review from a team as code owners May 26, 2026 12:34
@socket-security

socket-security Bot commented May 26, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​notification-services-controller@​24.1.0 ⏵ 24.1.198 +110088 +198 +1100

View full report

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@joaoloureirop joaoloureirop enabled auto-merge (squash) May 26, 2026 16:32
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

@joaoloureirop joaoloureirop disabled auto-merge May 26, 2026 18:27
@joaoloureirop joaoloureirop merged commit 6390185 into release/7.79.0 May 26, 2026
415 of 434 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.79.0-1779798877 branch May 26, 2026 18:27
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants