fix: gate Social AI notification settings & bump notification-services-controller to 24.1.1#30528
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bc0a08a. Configure here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30528 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 5490 5490
Lines 147805 147807 +2
Branches 33992 33993 +1
=======================================
+ Hits 121412 121414 +2
+ Misses 18084 18081 -3
- Partials 8309 8312 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@metamaskbot update-mobile-fixture |
|
🔄 Fixture update started. Running workflow from branch |
|
❌ E2E fixture update failed.\n\nCommon causes:\n- CI workflow is still running — wait for 'Build iOS Apps' to complete\n- CI workflow was skipped — ensure your PR has iOS-impacting changes or use |
445bca5
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|
Description
Ensure the project uses the newer
@metamask/notification-services-controllerversion and prevent Social AI notification controls from showing when the Social Leaderboard feature is disabled.Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/GE-244
Related to MetaMask/core#8861
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk: UI visibility is now controlled by an existing remote feature flag and changes are covered by updated tests; dependency bump may have minor integration fallout but is limited in scope.
Overview
Gates the Social AI notification settings section so it only appears when the
aiSocialLeaderboardEnabledremote feature flag is enabled (viaselectSocialLeaderboardEnabled).Updates unit/component-view tests and notification-state presets to cover both flag states, and adjusts the user-storage mock defaults for
marketing.inAppNotificationsEnabled.Bumps
@metamask/notification-services-controllerto24.1.1(and updates lockfile accordingly).Reviewed by Cursor Bugbot for commit 445bca5. Bugbot is set up for automated code reviews on this repo. Configure here.