chore(runway): cherry-pick fix: cp-7.78.0 add isAtomicBatchSupported action to TransactionPayController init messenger#30455
Merged
Conversation
…` action to `TransactionPayController` init messenger (#30425) ## **Description** Add `TransactionControllerIsAtomicBatchSupportedAction` to the `TransactionPayControllerInit` messenger. This enables the init messenger to delegate the `TransactionController:isAtomicBatchSupported` action, which is needed during controller initialization to check atomic batch support. Companion to MetaMask/metamask-extension#42809. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: #42781 ## **Manual testing steps** 1. Build the app with `yarn start:ios` or `yarn start:android` 2. Verify the app loads without errors 3. Verify transaction pay functionality works as expected <!-- ## **Screenshots/Recordings** ### **Before** ### **After** --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: adds a single delegated messenger action used during initialization, with no changes to transaction execution or signing behavior. > > **Overview** > Allows `TransactionPayController` initialization to query atomic batch capability by **adding delegation for** `TransactionController:isAtomicBatchSupported`. > > This extends `TransactionPayControllerInit` messenger types/imports to include `TransactionControllerIsAtomicBatchSupportedAction` and delegates the new action via `rootMessenger.delegate`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b81e10b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release branch (release/*) All E2E tests pre-selected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



isAtomicBatchSupportedaction toTransactionPayControllerinit messenger (fix: cp-7.78.0 addisAtomicBatchSupportedaction toTransactionPayControllerinit messenger #30425)Description
Add
TransactionControllerIsAtomicBatchSupportedActionto theTransactionPayControllerInitmessenger. This enables the initmessenger to delegate the
TransactionController:isAtomicBatchSupportedaction, which is needed during controller initialization to check atomic
batch support.
Companion to MetaMask/metamask-extension#42809.
Changelog
CHANGELOG entry: null
Related issues
Fixes: #42781
Manual testing steps
yarn start:iosoryarn start:androidPre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Low risk: adds a single delegated messenger action used during
initialization, with no changes to transaction execution or signing
behavior.
Overview
Allows
TransactionPayControllerinitialization to query atomic batchcapability by adding delegation for
TransactionController:isAtomicBatchSupported.This extends
TransactionPayControllerInitmessenger types/imports toinclude
TransactionControllerIsAtomicBatchSupportedActionanddelegates the new action via
rootMessenger.delegate.Reviewed by Cursor Bugbot for commit
b81e10b. Bugbot is set up for automated
code reviews on this repo. Configure
here.