Skip to content

fix: cp-7.78.0 add isAtomicBatchSupported action to TransactionPayController init messenger#30425

Merged
OGPoyraz merged 1 commit into
mainfrom
ogp/42781
May 20, 2026
Merged

fix: cp-7.78.0 add isAtomicBatchSupported action to TransactionPayController init messenger#30425
OGPoyraz merged 1 commit into
mainfrom
ogp/42781

Conversation

@OGPoyraz

@OGPoyraz OGPoyraz commented May 20, 2026

Copy link
Copy Markdown
Member

Description

Add TransactionControllerIsAtomicBatchSupportedAction to the TransactionPayControllerInit messenger. This enables the init messenger to delegate the TransactionController:isAtomicBatchSupported action, which is needed during controller initialization to check atomic batch support.

Companion to MetaMask/metamask-extension#42809.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #42781

Manual testing steps

  1. Build the app with yarn start:ios or yarn start:android
  2. Verify the app loads without errors
  3. Verify transaction pay functionality works as expected

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: adds a single delegated messenger action used during initialization, with no changes to transaction execution or signing behavior.

Overview
Allows TransactionPayController initialization to query atomic batch capability by adding delegation for TransactionController:isAtomicBatchSupported.

This extends TransactionPayControllerInit messenger types/imports to include TransactionControllerIsAtomicBatchSupportedAction and delegates the new action via rootMessenger.delegate.

Reviewed by Cursor Bugbot for commit b81e10b. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamaskbotv2 metamaskbotv2 Bot added the team-confirmations Push issues to confirmations team label May 20, 2026
@OGPoyraz OGPoyraz changed the title fix: add isAtomicBatchSupported action to TransactionPayController init messenger fix: add isAtomicBatchSupported action to TransactionPayController init messenger May 20, 2026
@OGPoyraz OGPoyraz marked this pull request as ready for review May 20, 2026 07:49
@OGPoyraz OGPoyraz requested a review from a team as a code owner May 20, 2026 07:49
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions, SmokeConfirmations, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change adds TransactionControllerIsAtomicBatchSupportedAction to the TransactionPayControllerInitMessenger, enabling the TransactionPayController to call TransactionController:isAtomicBatchSupported during its initialization flows.

Nature of change: Additive messenger configuration change (adding a new allowed action). Per the architecture skill, adding actions is "usually safe, extends functionality" - Medium risk.

Impact areas:

  1. SmokePredictions: The TransactionPayController is directly used for Polymarket/Predictions flows (polymarket-callbacks.ts uses the initMessenger). The new isAtomicBatchSupported action may be used in deposit wallet batch flows, which are core to Predictions functionality.

  2. SmokeConfirmations: isAtomicBatchSupported is an EIP-7702 atomic batch transaction feature. SmokeConfirmations explicitly covers "advanced EIP-7702 account abstraction features like batch transactions and gas fee token payments." The TransactionPayController is involved in transaction payment flows that go through confirmations.

  3. SmokeWalletPlatform: Required per SmokePredictions tag description - "When selecting SmokePredictions, also select SmokeWalletPlatform (Trending section)."

Why not broader coverage: This is a targeted additive change to a specific controller's messenger configuration. It doesn't affect Phase 2 controllers (Network, Keyring), doesn't change initialization order, and doesn't remove any existing actions. The blast radius is limited to TransactionPayController's functionality domain.

Performance Test Selection:
This change is a messenger configuration update (adding a new allowed action to TransactionPayControllerInitMessenger). It does not affect UI rendering, data loading, list components, or critical user flow performance. No performance tests are warranted.

View GitHub Actions results

@OGPoyraz OGPoyraz changed the title fix: add isAtomicBatchSupported action to TransactionPayController init messenger fix: cp-7.78.0 add isAtomicBatchSupported action to TransactionPayController init messenger May 20, 2026
@sonarqubecloud

Copy link
Copy Markdown

@OGPoyraz OGPoyraz added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 2b27a4f May 20, 2026
229 of 256 checks passed
@OGPoyraz OGPoyraz deleted the ogp/42781 branch May 20, 2026 15:29
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 20, 2026
@bschorchit bschorchit linked an issue May 20, 2026 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-XS team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with controller init messenger

2 participants