test: unskip multichain account selector search#30446
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables the previously skipped Jest test covering MultichainAccountSelectorList search behavior across multiple wallets, restoring coverage for cross-wallet account filtering without production code changes.
Changes:
- Removed the
it.skipon the “filters across multiple wallets” test so it runs in CI again. - Dropped the now-unnecessary ESLint suppression for
jest/no-disabled-tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
hmalik88
approved these changes
May 20, 2026
gantunesr
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Re-enables the
MultichainAccountSelectorListtest for filtering across multiple wallets.This test was disabled in #26377 (
chore: skip failing MultichainAccountSelectorList test) as a temporary CI unblocker while the failure was investigated. Leaving it skipped removes coverage for a real user path: searching for an account when account groups are spread across more than one wallet.The test now passes on current
mainwith the existing deterministic FlashList mock and search wait helper, so this PR restores that coverage without changing production code.Changelog
CHANGELOG entry: null
Related issues
Fixes: N/A
Part of INFRA-3513.
Manual testing steps
Verified:
git diff --check HEAD~1..HEADyarn eslint app/component-library/components-temp/MultichainAccounts/MultichainAccountSelectorList/MultichainAccountSelectorList.test.tsxScreenshots/Recordings
N/A - test-only change.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist