Skip to content

test: unskip multichain account selector search#30446

Merged
Qbandev merged 1 commit into
mainfrom
infra-3513-multichain-selector
May 20, 2026
Merged

test: unskip multichain account selector search#30446
Qbandev merged 1 commit into
mainfrom
infra-3513-multichain-selector

Conversation

@Qbandev

@Qbandev Qbandev commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

Re-enables the MultichainAccountSelectorList test for filtering across multiple wallets.

This test was disabled in #26377 (chore: skip failing MultichainAccountSelectorList test) as a temporary CI unblocker while the failure was investigated. Leaving it skipped removes coverage for a real user path: searching for an account when account groups are spread across more than one wallet.

The test now passes on current main with the existing deterministic FlashList mock and search wait helper, so this PR restores that coverage without changing production code.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Part of INFRA-3513.

Manual testing steps

Feature: Multichain account selector search

  Scenario: user searches across multiple wallets
    Given the account selector has accounts in two wallets

    When user searches for "Account 2"
    Then only "Account 2" remains visible

Verified:

  • git diff --check HEAD~1..HEAD
  • yarn eslint app/component-library/components-temp/MultichainAccounts/MultichainAccountSelectorList/MultichainAccountSelectorList.test.tsx
  • Targeted Jest run reports the unskipped test as passing locally; this worktree has an unrelated post-run Jest OOM also reproduced with an unrelated test file.

Screenshots/Recordings

N/A - test-only change.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-dev-ops DevOps team label May 20, 2026
@Qbandev Qbandev requested a review from Copilot May 20, 2026 14:09
@Qbandev Qbandev added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels May 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-enables the previously skipped Jest test covering MultichainAccountSelectorList search behavior across multiple wallets, restoring coverage for cross-wallet account filtering without production code changes.

Changes:

  • Removed the it.skip on the “filters across multiple wallets” test so it runs in CI again.
  • Dropped the now-unnecessary ESLint suppression for jest/no-disabled-tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Qbandev Qbandev marked this pull request as ready for review May 20, 2026 14:12
@Qbandev Qbandev requested a review from a team as a code owner May 20, 2026 14:12
@Qbandev Qbandev added 7.99.0 and removed 7.99.0 labels May 20, 2026
@sonarqubecloud

Copy link
Copy Markdown

@Qbandev Qbandev added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit b8a0fd9 May 20, 2026
221 of 300 checks passed
@Qbandev Qbandev deleted the infra-3513-multichain-selector branch May 20, 2026 16:02
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-XS team-dev-ops DevOps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants