Skip to content

chore: skip failing MultichainAccountSelectorList test#26377

Merged
Cal-L merged 1 commit into
mainfrom
hm/skip-multichain-selector-list-test
Feb 24, 2026
Merged

chore: skip failing MultichainAccountSelectorList test#26377
Cal-L merged 1 commit into
mainfrom
hm/skip-multichain-selector-list-test

Conversation

@hmalik88

@hmalik88 hmalik88 commented Feb 20, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Skipping failing test to unblock CI (will be investigated).

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Production code is unchanged; the main risk is reduced test coverage for cross-wallet search filtering until the test is re-enabled.

Overview
Skips the failing MultichainAccountSelectorList Jest test filters across multiple wallets by changing it to it.skip, with an eslint override to allow a disabled test.

Written by Cursor Bugbot for commit 80b97b9. This will update automatically on new commits. Configure here.

@hmalik88 hmalik88 requested a review from a team as a code owner February 20, 2026 20:03
@github-actions

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added team-accounts-framework Accounts team INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 20, 2026
@github-actions

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR only modifies a unit test file (MultichainAccountSelectorList.test.tsx) by skipping a single test case ('filters across multiple wallets') using it.skip. This is a common pattern for temporarily disabling flaky or problematic unit tests.

Key observations:

  1. No production code changes - Only a unit test file is modified
  2. Test infrastructure unchanged - No E2E test files, page objects, or fixtures are affected
  3. Simple change - Just adds it.skip and an eslint-disable comment to one test case
  4. Unit test, not E2E test - The skipped test is a Jest unit test, not a Detox E2E test

The MultichainAccountSelectorList component is used in account selection flows (AccountSelector, Bridge RecipientSelectorModal, MultichainAccountConnect), but since no production code is being changed and only a unit test is being skipped, there's no risk to the actual functionality. E2E tests are not needed to validate this change.

Performance Test Selection:
This change only skips a unit test in a test file. No production code is modified, so there is no potential impact on app performance. No performance tests are needed.

View GitHub Actions results

Cal-L
Cal-L approved these changes Feb 20, 2026
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

sonarqubecloud Bot commented Feb 20, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Cal-L Cal-L enabled auto-merge February 24, 2026 07:14
@Cal-L Cal-L added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 9b68d6d Feb 24, 2026
85 checks passed
@Cal-L Cal-L deleted the hm/skip-multichain-selector-list-test branch February 24, 2026 08:33
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2026
@metamaskbot metamaskbot added the release-7.68.0 Issue or pull request that will be included in release 7.68.0 label Feb 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mathieuartu mathieuartu mathieuartu approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.68.0 Issue or pull request that will be included in release 7.68.0 size-XS team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmalik88 @mathieuartu @Cal-L @metamaskbot