Cherry-picking commits from cherry-pick-7-77-2-72e0e00 to release/7.77.2-ota for PR #30407#30423
Merged
Merged
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
…6.1 (#30407) Bump `@metamask/transaction-pay-controller` from `^22.5.0` to `^22.6.1`. CHANGELOG entry: null - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've tested on Android - [ ] I've tested with a power user scenario - [ ] I've instrumented key operations with Sentry traces for production performance metrics - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Updates a core payments/transaction dependency and refreshes several related MetaMask controller packages, which could subtly affect transaction/bridge behavior at runtime despite being a version bump only. > > **Overview** > Bumps **`@metamask/transaction-pay-controller`** from `^22.5.0` to `^22.6.1` in `package.json` and updates `yarn.lock` accordingly. > > The lockfile refresh also pulls newer related controller versions (notably `@metamask/bridge-controller`, `@metamask/bridge-status-controller`, `@metamask/gas-fee-controller`, and `@metamask/transaction-controller`), aligning transitive dependencies with the updated pay controller. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 3b7622d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
6cc5943 to
091427b
Compare
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…on 22.5.0 Replaces the 22.5.0 -> 22.6.1 version bump with a yarn patch against 22.5.0 that backports the perpsDepositAndOrder fix from core PR #8851. This avoids pulling in the transitive dependency bumps required by 22.6.1 (bridge-controller, bridge-status-controller, transaction-controller, gas-fee-controller) on the 7.77.2-ota release branch.
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release branch (release/*) All E2E tests pre-selected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump
@metamask/transaction-pay-controllerfrom^22.5.0to^22.6.1.Changelog
CHANGELOG entry: null
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
performance metrics
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Updates a core payments/transaction dependency and refreshes several
related MetaMask controller packages, which could subtly affect
transaction/bridge behavior at runtime despite being a version bump
only.
Overview
Bumps
@metamask/transaction-pay-controllerfrom^22.5.0to^22.6.1inpackage.jsonand updatesyarn.lockaccordingly.The lockfile refresh also pulls newer related controller versions
(notably
@metamask/bridge-controller,@metamask/bridge-status-controller,@metamask/gas-fee-controller,and
@metamask/transaction-controller), aligning transitivedependencies with the updated pay controller.
Reviewed by Cursor Bugbot for commit
3b7622d. Bugbot is set up for automated
code reviews on this repo. Configure
here.