Skip to content

Feat/2165 disable basic api calls#8851

Closed
frankvonhoven wants to merge 3 commits into
mainfrom
feat/2165-disable-basic-api-calls
Closed

Feat/2165 disable basic api calls#8851
frankvonhoven wants to merge 3 commits into
mainfrom
feat/2165-disable-basic-api-calls

Conversation

@frankvonhoven

@frankvonhoven frankvonhoven commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

codecov-commenter commented Mar 5, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 31.81818% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 41.60%. Comparing base (f11f359) to head (ffdff33).
Report is 48 commits behind head on main.

Files Patch % Lines
app/store/sagas/index.ts 22.22% 14 Missing ⚠️
app/reducers/settings/index.js 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8851      +/-   ##
==========================================
+ Coverage   41.41%   41.60%   +0.18%     
==========================================
  Files        1270     1269       -1     
  Lines       30826    30889      +63     
  Branches     3042     3092      +50     
==========================================
+ Hits        12768    12851      +83     
+ Misses      17295    17261      -34     
- Partials      763      777      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
22.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@frankvonhoven

frankvonhoven commented Apr 16, 2024

Copy link
Copy Markdown
Contributor Author

Replaced with #9208

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frankvonhoven @codecov-commenter