fix: graceful fallback for assets missing images cp-7.77.0 by Prithpal-Sooriya · Pull Request #30096 · MetaMask/metamask-mobile

Prithpal-Sooriya · 2026-05-13T12:02:34Z

Description

replace the confirmation token avatar fallback with AssetLogo in token.tsx so send/perps flows use the same asset image pipeline + fallback as home/swap.

Changelog

CHANGELOG entry: fix: ensure missing assets try a fallback image url path.

Related issues

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
I've tested with a power user scenario
- Use these power-user SRPs to import wallets with many accounts and tokens
I've instrumented key operations with Sentry traces for production performance metrics
- See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI change that only alters how token logos are rendered; main risk is minor layout/styling differences or unexpected image URL fallback behavior in a few flows.

Overview
Uses the shared AssetLogo component (with its fallback image URL logic) anywhere non-native token avatars were previously rendered directly via AvatarToken, including the asset overview balance header and the confirmations token selector.

Updates the confirmations Token tests to mock AssetLogo to keep them focused on text/interaction behavior.

^{Reviewed by Cursor Bugbot for commit 5d62794. Bugbot is set up for automated code reviews on this repo. Configure here.}

Prithpal-Sooriya · 2026-05-13T12:19:03Z

@cursor validate and fix this pls
#30096 (comment)

cursor · 2026-05-13T12:19:12Z

Validated and fixed the exact issue in that discussion thread (#discussion_r3234065291).

✅ Fix applied

Removed the unused AvatarToken import from:
- app/components/Views/confirmations/components/UI/token/token.tsx

✅ Validation

yarn eslint app/components/Views/confirmations/components/UI/token/token.tsx
- Passes (only existing deprecation warnings, no errors)
yarn jest app/components/Views/confirmations/components/UI/token/token.test.tsx --coverage=false
- Passes (10/10)

✅ Git updates

Commit pushed to PR branch: 87405304bf
PR fix: graceful fallback for assets missing images cp-7.77.0 #30096 updated with the new commit (without overwriting human-edited title/body content).

codecov-commenter · 2026-05-13T12:39:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.74%. Comparing base (3751d9a) to head (8740530).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #30096      +/-   ##
==========================================
+ Coverage   81.54%   81.74%   +0.19%     
==========================================
  Files        5343     5387      +44     
  Lines      142128   143484    +1356     
  Branches    32411    32766     +355     
==========================================
+ Hits       115899   117290    +1391     
+ Misses      18299    18179     -120     
- Partials     7930     8015      +85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-05-13T16:14:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ff151f5. Configure here.}

Prithpal-Sooriya · 2026-05-13T18:55:04Z

@cursor fix this pls
#30096 (comment)

cursor · 2026-05-13T18:55:12Z

Fixed the issue from that review thread (#discussion_r3236724052) on the PR branch.

What I changed

Removed dead imports in:
- app/components/UI/AssetOverview/Balance/Balance.tsx
Specifically removed:
- AvatarToken
- AvatarSize

These were left unused after switching renderNetworkAvatar to AssetLogo.

Validation

Ran:
- yarn eslint app/components/UI/AssetOverview/Balance/Balance.tsx
Result:
- ✅ no errors (only existing deprecation warnings)

Git updates

Commit pushed: 5d62794e7e
Branch: cursor/musd-send-flow-assetlogo-fix-2926
PR fix: graceful fallback for assets missing images cp-7.77.0 #30096 is updated with this commit.

github-actions · 2026-05-13T19:00:24Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeConfirmations, SmokeWalletPlatform, SmokeStake
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 82%

click to see 🤖 AI reasoning details

E2E Test Selection:

The PR replaces direct AvatarToken usage with the shared AssetLogo component in two places:

Balance.tsx (AssetOverview): The token logo in the asset overview/balance screen now uses AssetLogo instead of AvatarToken directly. AssetLogo internally uses AvatarToken for non-native tokens but adds fallback URL support via getAssetImageUrl. This affects the wallet's token detail view.
token.tsx (confirmations): The token display component in confirmation screens now uses AssetLogo instead of AvatarToken from the design-system. This affects how tokens are displayed in transaction/signature confirmation flows.
token.test.tsx: Updated unit test to mock the new AssetLogo import.

Tag selection rationale:

SmokeConfirmations: Directly affected - token.tsx is used in confirmation screens to display token information. The logo rendering change needs validation in confirmation flows (ERC-20 approvals, token transfers, etc.).
SmokeWalletPlatform: Balance.tsx is in the AssetOverview component which is part of the core wallet platform. Token logo display in the asset detail screen needs validation.
SmokeStake: AssetLogo is used in StakingBalance and StakingConfirmation/TokenValueStack components. The staking flows display token logos and should be validated.

Not selected:

SmokeSwap: While swap flows show tokens, the changes are in Balance.tsx (asset overview) and token.tsx (confirmations), not in swap-specific token display components.
SmokeMoney: CardAssetItem uses AssetLogo but was not changed in this PR.
SmokePerps: Not directly affected by these specific component changes.

The risk is medium because while the refactoring is straightforward (same underlying AvatarToken component), the AssetLogo component adds logic for native token detection and fallback URL resolution that could behave differently in edge cases.

Performance Test Selection:
These changes are UI refactoring - replacing AvatarToken with AssetLogo component. AssetLogo internally uses the same AvatarToken for non-native tokens, so there is no meaningful performance impact. The change adds a small amount of logic (native token check, fallback URL resolution) but this is negligible and not expected to affect rendering performance metrics.

View GitHub Actions results

Prithpal-Sooriya · 2026-05-13T20:38:18Z

Skipping E2E as known failure

SmokeWalletPlatform: mUSD Conversion Happy Path › converts USDC to mUSD from Asset Overview
https://consensys.slack.com/archives/C02U025CVU4/p1778698549273839

sonarqubecloud · 2026-05-13T20:59:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Fix token icon rendering in confirmation flow

fe5b8aa

metamaskbotv2 Bot added the team-assets label May 13, 2026

cursor Bot mentioned this pull request May 13, 2026

[Bug]: Assets - mUSD doesn't have a token icon when going over the Send flow #29946

Closed

cursor Bot changed the title ~~[Bug]: Assets - mUSD icon missing in Send flow asset list~~ fix: Assets - mUSD icon missing in Send flow asset list May 13, 2026

github-actions Bot added the size-S label May 13, 2026

Prithpal-Sooriya marked this pull request as ready for review May 13, 2026 12:10

Prithpal-Sooriya requested a review from a team as a code owner May 13, 2026 12:10

Prithpal-Sooriya changed the title ~~fix: Assets - mUSD icon missing in Send flow asset list~~ fix: mUSD icon missing in Send flow asset list May 13, 2026

cursor Bot reviewed May 13, 2026

View reviewed changes

Comment thread app/components/Views/confirmations/components/UI/token/token.tsx

Prithpal-Sooriya changed the title ~~fix: mUSD icon missing in Send flow asset list~~ fix: graceful fallback for assets missing images May 13, 2026

juanmigdr previously approved these changes May 13, 2026

View reviewed changes

fix: remove unused AvatarToken import in token row

8740530

cursor Bot dismissed juanmigdr’s stale review via 8740530 May 13, 2026 12:21

Prithpal-Sooriya enabled auto-merge May 13, 2026 12:32

OGPoyraz previously approved these changes May 13, 2026

View reviewed changes

fix: remove deprecated image, use improved image that handles fallback

bd6ceae

Prithpal-Sooriya dismissed OGPoyraz’s stale review via bd6ceae May 13, 2026 16:14

Prithpal-Sooriya requested a review from a team as a code owner May 13, 2026 16:14

Prithpal-Sooriya changed the title ~~fix: graceful fallback for assets missing images~~ fix: graceful fallback for assets missing images cp-7.77.0 May 13, 2026

bergarces previously approved these changes May 13, 2026

View reviewed changes

Merge branch 'main' into cursor/musd-send-flow-assetlogo-fix-2926

ff151f5

cursor Bot reviewed May 13, 2026

View reviewed changes

Comment thread app/components/UI/AssetOverview/Balance/Balance.tsx

fix: remove unused avatar imports in balance

5d62794

cursor Bot dismissed bergarces’s stale review via 5d62794 May 13, 2026 18:57

OGPoyraz approved these changes May 13, 2026

View reviewed changes

Prithpal-Sooriya added the skip-e2e skip E2E test jobs label May 13, 2026

bergarces approved these changes May 13, 2026

View reviewed changes

Prithpal-Sooriya added this pull request to the merge queue May 13, 2026

Merged via the queue into main with commit 24712bd May 13, 2026
220 of 225 checks passed

Prithpal-Sooriya deleted the cursor/musd-send-flow-assetlogo-fix-2926 branch May 13, 2026 21:27

github-actions Bot locked and limited conversation to collaborators May 13, 2026

metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: graceful fallback for assets missing images cp-7.77.0#30096

fix: graceful fallback for assets missing images cp-7.77.0#30096
Prithpal-Sooriya merged 5 commits into
mainfrom
cursor/musd-send-flow-assetlogo-fix-2926

Prithpal-Sooriya commented May 13, 2026 •

edited by cursor Bot

Loading

Uh oh!

Uh oh!

Prithpal-Sooriya commented May 13, 2026

Uh oh!

cursor Bot commented May 13, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Prithpal-Sooriya commented May 13, 2026

Uh oh!

cursor Bot commented May 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

Prithpal-Sooriya commented May 13, 2026

Uh oh!

sonarqubecloud Bot commented May 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Prithpal-Sooriya commented May 13, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

Pre-merge reviewer checklist

Uh oh!

Uh oh!

Prithpal-Sooriya commented May 13, 2026

Uh oh!

cursor Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Fix applied

✅ Validation

✅ Git updates

Uh oh!

codecov-commenter commented May 13, 2026

Codecov Report

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Prithpal-Sooriya commented May 13, 2026

Uh oh!

cursor Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I changed

Validation

Git updates

Uh oh!

github-actions Bot commented May 13, 2026

🔍 Smart E2E Test Selection

Uh oh!

Prithpal-Sooriya commented May 13, 2026

Uh oh!

sonarqubecloud Bot commented May 13, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Prithpal-Sooriya commented May 13, 2026 •

edited by cursor Bot

Loading

cursor Bot commented May 13, 2026 •

edited

Loading

cursor Bot commented May 13, 2026 •

edited

Loading