chore(runway): cherry-pick ci: skip smart e2e ai selection for cherry-pick PRs targeting release branch#29677
Merged
Conversation
…-pick PRs targeting release branch (#29658) ## **Description** Re-introduces the release-branch skip in `.github/actions/smart-e2e-selection/action.yml`. The original logic was added in #28331 and accidentally removed by #29305 ("ci: add automated E2E readiness label and CI checks - Part1"), which refactored the action and didn't carry the release-branch handling forward. Since the merge of #29305, every cherry-pick PR targeting `release/*` runs the AI-based reduced E2E selection — same as a `main` PR — instead of running the full suite. Why release branches deserve different handling (same reasoning as #28331): - On `main`, iterating quickly with a risk-scored subset is a reasonable trade-off — we accept some residual risk for speed and catch the rest in follow-up PRs. - A PR into `release/*` is effectively "this build is a candidate to ship." Release cherry-picks are low-volume and high-impact, and we cannot afford to merge a cherry-pick that breaks CI on the release branch under release urgency. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/INFRA-3464 ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** > ⏭️ **Smart E2E selection skipped** - PR targets a release branch (release/\*) > > All E2E tests pre-selected. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk CI-only change that just alters when the composite action runs AI selection vs defaulting to the full E2E suite; main risk is unintentionally skipping AI selection if `base-ref` is mis-set. > > **Overview** > **Smart E2E selection now skips AI for PRs targeting `release/*`.** The `smart-e2e-selection` composite action adds a `check-release-target` gate using `inputs.base-ref`; when it matches `release/*`, the action bypasses checkout/deps/analysis and keeps the default `ai_e2e_test_tags=["ALL"]` with `ai_confidence=100`. > > The action’s `base-ref` input description is updated to document this behavior, and the AI analysis step now reports a specific skip reason for release-branch targets (in addition to the existing skip-label behavior). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 94855dc. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Re-introduces the release-branch skip in
.github/actions/smart-e2e-selection/action.yml.The original logic was added in #28331 and accidentally removed by
#29305 ("ci: add automated E2E readiness label and CI checks - Part1"),
which refactored the action and didn't carry the release-branch handling
forward. Since the merge of #29305, every cherry-pick PR targeting
release/*runs the AI-based reduced E2E selection — same as amainPR — instead of running the full suite.
Why release branches deserve different handling (same reasoning as
#28331):
main, iterating quickly with a risk-scored subset is a reasonabletrade-off — we accept some residual risk for speed and catch the rest in
follow-up PRs.
release/*is effectively "this build is a candidate toship." Release cherry-picks are low-volume and high-impact, and we
cannot afford to merge a cherry-pick that breaks CI on the release
branch under release urgency.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/INFRA-3464
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Made with Cursor
Note
Low Risk
Low risk CI-only change that just alters when the composite action
runs AI selection vs defaulting to the full E2E suite; main risk is
unintentionally skipping AI selection if
base-refis mis-set.Overview
Smart E2E selection now skips AI for PRs targeting
release/*.The
smart-e2e-selectioncomposite action adds acheck-release-targetgate using
inputs.base-ref; when it matchesrelease/*, the actionbypasses checkout/deps/analysis and keeps the default
ai_e2e_test_tags=["ALL"]withai_confidence=100.The action’s
base-refinput description is updated to document thisbehavior, and the AI analysis step now reports a specific skip reason
for release-branch targets (in addition to the existing skip-label
behavior).
Reviewed by Cursor Bugbot for commit
94855dc. Bugbot is set up for automated
code reviews on this repo. Configure
here.
Co-authored-by: Cursor cursoragent@cursor.com 346a5a7