Skip to content

ci: skip smart e2e ai selection for cherry-pick PRs targeting release branch#29658

Merged
chloeYue merged 1 commit into
mainfrom
skip-e2e-selection-release-v2
May 4, 2026
Merged

ci: skip smart e2e ai selection for cherry-pick PRs targeting release branch#29658
chloeYue merged 1 commit into
mainfrom
skip-e2e-selection-release-v2

Conversation

@chloeYue

@chloeYue chloeYue commented May 4, 2026

Copy link
Copy Markdown
Contributor

Description

Re-introduces the release-branch skip in .github/actions/smart-e2e-selection/action.yml.

The original logic was added in #28331 and accidentally removed by #29305 ("ci: add automated E2E readiness label and CI checks - Part1"), which refactored the action and didn't carry the release-branch handling forward. Since the merge of #29305, every cherry-pick PR targeting release/* runs the AI-based reduced E2E selection — same as a main PR — instead of running the full suite.

Why release branches deserve different handling (same reasoning as #28331):

  • On main, iterating quickly with a risk-scored subset is a reasonable trade-off — we accept some residual risk for speed and catch the rest in follow-up PRs.
  • A PR into release/* is effectively "this build is a candidate to ship." Release cherry-picks are low-volume and high-impact, and we cannot afford to merge a cherry-pick that breaks CI on the release branch under release urgency.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/INFRA-3464

Manual testing steps

Screenshots/Recordings

Before

After

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Low Risk
Low risk CI-only change that just alters when the composite action runs AI selection vs defaulting to the full E2E suite; main risk is unintentionally skipping AI selection if base-ref is mis-set.

Overview
Smart E2E selection now skips AI for PRs targeting release/*. The smart-e2e-selection composite action adds a check-release-target gate using inputs.base-ref; when it matches release/*, the action bypasses checkout/deps/analysis and keeps the default ai_e2e_test_tags=["ALL"] with ai_confidence=100.

The action’s base-ref input description is updated to document this behavior, and the AI analysis step now reports a specific skip reason for release-branch targets (in addition to the existing skip-label behavior).

Reviewed by Cursor Bugbot for commit 94855dc. Bugbot is set up for automated code reviews on this repo. Configure here.

… branch

Re-introduces the release-branch skip logic from #28331 on top of #29305's
refactor. Cherry-pick PRs into release/* branches now bypass AI selection
and run the full E2E suite — release cherry-picks are low-volume and
high-impact, and we cannot afford a partial CI signal there.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 4, 2026
@github-actions github-actions Bot added the size-S label May 4, 2026
@chloeYue chloeYue added team-mobile-delivery and removed team-qa QA team labels May 4, 2026
@chloeYue chloeYue force-pushed the skip-e2e-selection-release-v2 branch from 9d2049e to 94855dc Compare May 4, 2026 13:00
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.84%. Comparing base (51b6bbd) to head (94855dc).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29658      +/-   ##
==========================================
- Coverage   82.15%   81.84%   -0.32%     
==========================================
  Files        5178     5244      +66     
  Lines      137450   138672    +1222     
  Branches    31079    31460     +381     
==========================================
+ Hits       112924   113498     +574     
- Misses      16875    17449     +574     
- Partials     7651     7725      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown

@chloeYue chloeYue marked this pull request as ready for review May 4, 2026 13:22
@chloeYue chloeYue requested a review from a team as a code owner May 4, 2026 13:22
@chloeYue chloeYue added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit 346a5a7 May 4, 2026
108 of 132 checks passed
@chloeYue chloeYue deleted the skip-e2e-selection-release-v2 branch May 4, 2026 16:45
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-S team-mobile-delivery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants