Skip to content

test: skip changing the slippage in Swap smoke test due to bug#29618

Merged
davibroc merged 2 commits into
mainfrom
test/reomove-slippage-test
May 1, 2026
Merged

test: skip changing the slippage in Swap smoke test due to bug#29618
davibroc merged 2 commits into
mainfrom
test/reomove-slippage-test

Conversation

@davibroc

@davibroc davibroc commented May 1, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are limited to smoke-test steps and analytics expectations, adjusting assertions to match a temporarily missing slippage event.

Overview
Updates the swap action smoke test to stop setting custom slippage during the first ETH→USDC swap while bug #29615 is unresolved.

Adjusts the associated analytics expectations by reducing INPUT_CHANGED event count from 12→11 and temporarily disabling the slippage input assertion, with comments indicating it should be re-enabled once the bug is fixed.

Reviewed by Cursor Bugbot for commit 05981c9. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 1, 2026
@davibroc davibroc added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Sev-2 team-qa QA team and removed team-qa QA team labels May 1, 2026
cursor[bot]
cursor Bot reviewed May 1, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 811f747. Configure here.

Comment thread tests/smoke/swap/swap-action-smoke.spec.ts
@davibroc davibroc mentioned this pull request May 1, 2026
Open
@github-actions github-actions Bot added size-S and removed size-XS labels May 1, 2026
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSwap, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The two changed files are both test-only files within the SmokeSwap suite:

  1. tests/smoke/swap/swap-action-smoke.spec.ts: Comments out slippage: '3.5' in the submitSwapUnifiedUI call as a temporary workaround for bug [Bug]: Swap Footer disappears during slippage-triggered re-fetch #29615 (slippage modal issue). No app source code is touched.

  2. tests/helpers/analytics/expectations/swap-action.analytics.ts: Updates the analytics expectations to match the new test behavior — reduces expected INPUT_CHANGED event count from 12 to 11 and comments out the slippage input assertion.

These are minimal, isolated test changes. The only tags needed are:

  • SmokeSwap: Directly covers the modified swap smoke test file.
  • SmokeConfirmations: Per SmokeSwap tag description, swap flows involve transaction confirmations, so SmokeConfirmations should also be selected.

No other tags are impacted. No app source code, controllers, navigation, or shared components were modified.

Performance Test Selection:
No app source code was changed — only test files within the swap smoke suite were modified. There is no performance impact from commenting out a slippage parameter in a test or adjusting analytics event count expectations.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 1, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@davibroc davibroc enabled auto-merge May 1, 2026 18:33
@davibroc davibroc added this pull request to the merge queue May 1, 2026
Merged via the queue into main with commit 4d48e72 May 1, 2026
99 checks passed
@davibroc davibroc deleted the test/reomove-slippage-test branch May 1, 2026 18:36
@github-actions github-actions Bot locked and limited conversation to collaborators May 1, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@cortisiko cortisiko cortisiko approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.77.0 Issue or pull request that will be included in release 7.77.0 Sev-2 size-S team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davibroc @cortisiko