feat: replacing stubbed modules in Money Home#29454
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit df4364f. Configure here.
…ce and update tests
…radientText and PotentialEarningsTokenRow
…ngsView with tests
…fix homeState bug
…letons, and CashSection integration
… to match token list
… on your crypto" screen is ready
… button on homescreen (top-right) to be the first in the list.
…ve inline formatter
…eyHomeView; make MoneyEarnings props currency-aware refactor(money): wire useMoneyAccountBalance to moneyFormatFiat, remove inline formatter
…eyPotentialEarnings
…entialEarningsTokenRow
…eyPotentialEarningsView
…till centralizing to make maintenance easier.
…unnecessary call when MoneyHome feature is disabled
df4364f to
bc0d0e8
Compare
…form display of fiat values
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
The MainNavigator change is particularly impactful: when Performance Test Selection: |
|
brianacnguyen
left a comment
There was a problem hiding this comment.
Can you provide a screenshot/recording of the change?
|
@brianacnguyen here's a quick demo of the change requiring CO review. When the Money Home feature flag is enabled, we're replacing activity in the bottom navbar with "Money" and moving activity to the top-right action bar. money_bottom_navbar_demo.mov |
Description
This PR replaces many of the placeholder UI elements and no-ops with their production equivalents.
Money in bottom navbar: When
selectMoneyHomeScreenEnabledFlagis on, the Activity tab is replaced by a Money tab that redirects to Money Home. Activity has been moved to the wallet header.Money Home bottom sheets: The options button (top-right), Transfer action, APY info tooltip, and earnings info tooltip now navigate to their respective modals; Card CTAs route into the Card stack; “Earn on your crypto” opens-temporary "Earn on your crypto" page; wires up "Convert" buttons for assets displayed in the "Earn on your crypto" section.
MoneyPotentialEarningsView lists all eligible conversion tokens, shows aggregate projected yield, and reuses row-level conversion behavior.
Shared utilities & hooks: Adds
moneyFormatFiat, centralizes temp__DEV__vault APY handling inuseMoneyAccountBalance, addscalculateProjectedEarningshelper, and refactors Money-related components to use the shared formatter instead of ad hocIntl/useFiatFormatterusage. This means we no longer see the "US" prefix in front of USD fiat amount.Updated image assets Updates Money onboarding / condensed cards / How it works images; removes the temporary How it Works header.
MoneyAccountHomeRow When
selectMoneyHomeScreenEnabledFlagis on, The Money section on the home screen displays the Money account's balance instead of the aggregated mUSD balance. This component has 2 variants; an empty state and a funded state.Changelog
CHANGELOG entry: Improved the Money home experience behind the feature flag by wiring real navigation (sheets, Card flows, potential earnings and conversion), replacing the Activity tab when the flag is enabled, and showing projected earnings using live APY and balance data.
Related issues
No issue: Money Home and tab-navigation workstream without a single tracking issue from the branch; see #29454 for scope and review. Add
Fixes:/Closes:when a primary ticket exists.Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Introduces new Money navigation routes/modals and swaps core tab/wallet navigation behavior behind
selectMoneyHomeScreenEnabledFlag, which could affect app navigation flows if misconfigured. Also changes fiat formatting and APY/projection calculations used across Money UI, so regressions would show up as incorrect amounts or broken sheets rather than data loss.Overview
When
selectMoneyHomeScreenEnabledFlagis enabled, the bottom tab bar replaces Activity with a new Money tab (newTabBarIconKey.Money) and moves Activity access to a new wallet header button (withACTIVITY_CLICKEDanalytics). Navigation is updated so Money routes/modals (More,Transfer,APY info,Earnings info, plus a newMoneyPotentialEarningsView) are registered and can be opened from Money Home.Money Home is de-stubbed: menu/transfer/card CTAs now navigate to real routes, token “Convert” actions initiate the conversion flow with error logging, and earnings UI now shows lifetime/projected values and opens an earnings info sheet. Shared Money utilities are added and adopted:
moneyFormatFiatcentralizes fiat formatting,calculateProjectedEarningsstandardizes linear projections,useMoneyAccountBalancenow returnsapyDecimal/apyPercent/apyPercentFormattedand uses the shared formatter, and Money activity fiat formatting is migrated to the same utility.Homepage Cash section now conditionally renders a new
MoneyAccountHomeRow(balance/APY + Get started/Add CTA with loading skeletons) when the Money home flag is on, instead of the prior mUSD aggregated row. Tests and locales are updated accordingly.Reviewed by Cursor Bugbot for commit b459652. Bugbot is set up for automated code reviews on this repo. Configure here.