Description

Hardware wallet (Ledger/QR) transactions on gas-sponsored networks (MON, SEI) incorrectly showed "Paid by MetaMask" in the activity transaction details. The root cause was twofold:

1. Confirm callback gap: The isGasFeeSponsored override in useTransactionConfirm only ran inside handleSmartTransaction and handleGasless7702, both of which exit early when no selectedGasFeeToken is present — which is always the case for HW wallets since gasless is not supported. The flag was never cleared on the persisted transaction metadata.
2. Missing UI guard: The activity list TransactionDetails component passed isGasFeeSponsored from stored transaction data without checking if the account is a hardware wallet.

Fix: Moved the isGasFeeSponsored override to the top of onConfirm so it runs unconditionally for every transaction, and added an isHardwareAccount guard in the activity list UI (matching the pattern already used in Bridge TransactionDetails).

Changelog

CHANGELOG entry: Fixed "Paid by MetaMask" incorrectly showing for hardware wallet transactions on gas-sponsored networks

Related issues

Fixes: #29241

Manual testing steps

Feature: Gas sponsorship display for hardware wallets

  Background:
    Given I am logged into MetaMask Mobile
    And I have a Ledger or QR hardware wallet connected

  Scenario: HW wallet send on MON does not show "Paid by MetaMask"
    Given I am connected to the Monad network with a hardware wallet

    When user sends MON to another address
    And user confirms the transaction on the hardware device
    And user navigates to the activity log
    And user selects the completed transaction
    Then the network fee field should show the actual gas fee amount
    And "Paid by MetaMask" should not appear

  Scenario: HW wallet send on SEI does not show "Paid by MetaMask"
    Given I am connected to the Sei network with a hardware wallet

    When user sends SEI to another address
    And user confirms the transaction on the hardware device
    And user navigates to the activity log
    And user selects the completed transaction
    Then the network fee field should show the actual gas fee amount
    And "Paid by MetaMask" should not appear

  Scenario: Non-HW wallet send on sponsored network still shows "Paid by MetaMask"
    Given I am connected to a gas-sponsored network with a software wallet
    And the transaction is eligible for gas sponsorship

    When user sends a transaction
    And user navigates to the activity log
    And user selects the completed transaction
    Then "Paid by MetaMask" should appear in the network fee field

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.