fix(ramp): show PayPal in payment selector for UB2 (TRAM-3462) cp-7.74.0 by saustrie-consensys · Pull Request #29046 · MetaMask/metamask-mobile

saustrie-consensys · 2026-04-20T13:01:19Z

Description

In Unified Buy V2, PayPal is not shown in the Pay With bottom sheet even when the server would accept it. Two defects stack:

PaymentSelectionModal and ProviderSelectionModal called useRampsQuotes without redirectUrl. The quotes API only materializes a PayPal dummy quote when both redirectUrl and walletAddress are provided; otherwise PayPal is only returned under customActions. BuildQuote already sends redirectUrl, but the selection-stage modals were inconsistent.
PaymentSelectionModal's visibility filter in renderListContent excluded any success entry with quote.isCustomAction: true, so even when PayPal surfaced in success (e.g. when we do pass redirectUrl), its payment method row was still filtered out and the "No payment methods are available." banner was shown.

This PR:

Passes redirectUrl: getRampCallbackBaseUrl() from PaymentSelectionModal and ProviderSelectionModal, matching BuildQuote's existing shape so the quotes request is consistent across selection stages.
Drops !isCustomAction(q) from the visiblePaymentMethods filter so custom-action quotes count as "available" for listing. The per-item matchedQuote find remains strict, so custom-action rows still do not render a misleading priced preview.

Changelog

CHANGELOG entry: Fixed a bug where PayPal was missing from the Pay With list in Unified Buy V2 and the selector showed "No payment methods are available." instead.

Related issues

Fixes: https://consensyssoftware.atlassian.net/jira/software/c/projects/TRAM/boards/1568?assignee=712020%3Afd12f7ea-d9e1-4a0a-8a26-36804c9e11c9&selectedIssue=TRAM-3462

Manual testing steps

Feature: Pay With selector surfaces PayPal (UB2)

  Scenario: PayPal is available as a payment method
    Given the user is in the Unified Buy V2 flow with PayPal supported in their region
    And the user has selected a crypto asset and amount

    When the user opens the Pay With bottom sheet
    Then the PayPal row appears in the list
    And the "No payment methods are available." banner is not shown

  Scenario: PayPal row does not show a misleading price
    Given PayPal is available in the Pay With list
    When the user views the PayPal row
    Then no crypto amount or fiat amount is rendered for the row
    And the row remains tappable

  Scenario: Selecting PayPal continues into its checkout flow
    Given PayPal is listed in the Pay With sheet
    When the user taps the PayPal row
    Then the sheet closes and the existing custom-action checkout flow runs

Screenshots/Recordings

Before

https://www.loom.com/share/865aefe1f2024ed28f0564192c01bf0b

After

https://www.loom.com/share/556420ed2f3c41028cc9a1fc21b0d847

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI selection logic change plus added test coverage; risk is limited to which payment methods are shown and the quote request parameters sent.

Overview
Fixes Unified Buy V2 payment/provider selection so quote fetches from PaymentSelectionModal and ProviderSelectionModal include redirectUrl: getRampCallbackBaseUrl(), aligning them with the Build Quote flow and enabling providers that require a redirect URL to surface correctly.

Updates the payment-method visibility filter to treat custom-action quotes as “available” (so their rows remain listed), while keeping per-row price previews gated by non-custom-action quotes; tests were updated/added to cover both the new redirectUrl param and the custom-action visibility/no-price behavior.

^{Reviewed by Cursor Bugbot for commit 8c4209e. Bugbot is set up for automated code reviews on this repo. Configure here.}

PaymentSelectionModal and ProviderSelectionModal omitted `redirectUrl` when fetching quotes, so the API never materialized a PayPal dummy quote and PayPal only appeared in `customActions`. The per-row visibility filter also excluded `isCustomAction: true` quotes, so PayPal was hidden even when returned. Pass `redirectUrl: getRampCallbackBaseUrl()` from both modals and drop the `!isCustomAction(q)` clause from the `visiblePaymentMethods` filter so custom-action quotes count as available. The per-item matchedQuote find still skips custom-action quotes so rows without a priced quote don't render a misleading amount.

github-actions · 2026-04-20T13:01:31Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 1f06b92. Configure here.}

wachunei · 2026-04-20T13:37:41Z

aah so we were actually not sending the redirect url in that view get quotes call, great catch.

One question, if paypal is selected the flow works normally?

Please fix the unused useEffect by removing it and add cp-7.74.0 to the title so we can include this as a cherry pick. 🙏

saustrie-consensys · 2026-04-20T13:43:45Z

aah so we were actually not sending the redirect url in that view get quotes call, great catch.

One question, if paypal is selected the flow works normally?

Please fix the unused useEffect by removing it and add cp-7.74.0 to the title so we can include this as a cherry pick. 🙏

I plan to remove the useEffect. It was left over when I was debugging.

As far as "works normally", yes - I am directed to PayPal's iframe/widget url.

@wachunei

saustrie-consensys · 2026-04-20T13:46:09Z

@wachunei yes — BuildQuote was already sending redirectUrl, so when PayPal is the active payment method the controller fetches the PayPal custom-action quote, canContinue evaluates true, and Continue routes through the custom-action checkout from #27364. This PR doesn't touch that path; it only unblocks the Pay-With selector from hiding PayPal.

useEffect removed and cp-7.74.0 appended to the title. 🙏

saustrie-consensys · 2026-04-20T13:47:23Z

@wachunei All changes were made

github-actions · 2026-04-20T13:48:29Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeRamps
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
The 4 changed files are all within the Ramp feature area (app/components/UI/Ramp/Views/Modals/). Two are implementation files and two are their corresponding unit test files.

Key changes:

PaymentSelectionModal.tsx: (a) Adds redirectUrl: getRampCallbackBaseUrl() to the quotes request, enabling callback URL support for ramp providers. (b) Fixes payment method filtering logic — previously, payment methods with only custom-action quotes (e.g., PayPal) were hidden from users; now they remain visible since custom-action providers have their own checkout flow.
ProviderSelectionModal.tsx: Adds the same redirectUrl: getRampCallbackBaseUrl() to the quotes request.
Test files: Updated to assert the new redirectUrl parameter is passed and to verify the corrected custom-action quote filtering behavior.

These changes are entirely scoped to the Ramp (buy/sell) feature. No shared components (navigation, Engine, controllers, confirmations), no cross-cutting concerns. SmokeRamps is the correct and only tag needed. No dependent tags are required per the tag descriptions.

Performance Test Selection:
The changes are limited to Ramp modal UI components — adding a redirectUrl parameter to quote requests and fixing payment method visibility logic. These are not performance-sensitive code paths and do not affect rendering performance, data loading, account/network lists, or app startup. No performance tests are warranted.

View GitHub Actions results

sonarqubecloud · 2026-04-20T14:08:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-04-20T14:17:12Z

✅ E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

saustrie-consensys added the team-money-movement issues related to Money Movement features label Apr 20, 2026

github-actions Bot added the size-S label Apr 20, 2026

saustrie-consensys self-assigned this Apr 20, 2026

saustrie-consensys added the team-ramps label Apr 20, 2026

saustrie-consensys marked this pull request as ready for review April 20, 2026 13:33

saustrie-consensys requested a review from a team as a code owner April 20, 2026 13:33

cursor Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/Modals/PaymentSelectionModal/PaymentSelectionModal.tsx Outdated

chore(ramp): drop unused useEffect imports

8c4209e

saustrie-consensys changed the title ~~fix(ramp): show PayPal in payment selector for UB2 (TRAM-3462)~~ fix(ramp): show PayPal in payment selector for UB2 (TRAM-3462) cp-7.74.0 Apr 20, 2026

github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Apr 20, 2026

saustrie-consensys enabled auto-merge April 20, 2026 14:02

wachunei approved these changes Apr 20, 2026

View reviewed changes

saustrie-consensys added this pull request to the merge queue Apr 20, 2026

Merged via the queue into main with commit 5048eae Apr 20, 2026
101 checks passed

saustrie-consensys deleted the fix/ramp-paypal-payment-selection-tram-3462 branch April 20, 2026 14:40

github-actions Bot locked and limited conversation to collaborators Apr 20, 2026

metamaskbotv2 Bot added the release-7.75.0 Issue or pull request that will be included in release 7.75.0 label Apr 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ramp): show PayPal in payment selector for UB2 (TRAM-3462) cp-7.74.0#29046

fix(ramp): show PayPal in payment selector for UB2 (TRAM-3462) cp-7.74.0#29046
saustrie-consensys merged 2 commits into
mainfrom
fix/ramp-paypal-payment-selection-tram-3462

saustrie-consensys commented Apr 20, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

wachunei commented Apr 20, 2026

Uh oh!

saustrie-consensys commented Apr 20, 2026

Uh oh!

saustrie-consensys commented Apr 20, 2026 •

edited

Loading

Uh oh!

saustrie-consensys commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

sonarqubecloud Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

saustrie-consensys commented Apr 20, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wachunei commented Apr 20, 2026

Uh oh!

saustrie-consensys commented Apr 20, 2026

Uh oh!

saustrie-consensys commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saustrie-consensys commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented Apr 20, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saustrie-consensys commented Apr 20, 2026 •

edited by cursor Bot

Loading

saustrie-consensys commented Apr 20, 2026 •

edited

Loading