feat(ramps): add custom action order handling for external checkout flows by georgeweiler · Pull Request #27364 · MetaMask/metamask-mobile

georgeweiler · 2026-03-11T15:19:40Z

Description

Integrates new ramps-controller API for custom-action flows (e.g., PayPal) removes Redux-based custom ID tracking.
Simplifies ramps-controller state hydration system into a single init call on app start up.

What changed:

BuildQuote — Uses getBuyWidgetData instead of getWidgetUrl. For isCustomAction quotes, calls addPrecreatedOrder before opening external browser (InAppBrowser or Linking.openURL) and passes orderId to Checkout for WebView flows.
Checkout — Uses addPrecreatedOrder instead of Redux addFiatCustomIdData. Supports both orderId and customOrderId for backwards compatibility.
Hooks — useRampsOrders exposes addPrecreatedOrder and AddPrecreatedOrderParams; useRampsQuotes uses getBuyWidgetData returning Promise<BuyWidget | null>; useRampsController exposes both.
Provider/payment filtering — PaymentSelectionModal and ProviderSelection filter out isCustomAction quotes where appropriate.

What stays untouched: Non-custom-action flows (standard WebView checkout) unchanged. Existing ramps navigation and token selection preserved.

Dependencies: Requires MetaMask/core#8100 for the new controller API.

Changelog

CHANGELOG entry: Adds support for ramps providers such as PayPal, Robinhood & Coinbase that use a different checkout browser

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes the BuildQuote continue flow to support external-browser widget checkouts with precreated order tracking and post-auth callback handling, which can affect buy navigation and order state. Mostly scoped to ramps UI/controller integration with expanded test coverage, but touches user-facing purchase flow and deep-link/callback paths.

Overview
Updates the ramps BuildQuote flow to use the new controller API getBuyWidgetData (replacing getWidgetUrl) and to support widget providers that require external checkout. When external browser checkout is used, it now pre-creates an order via addPrecreatedOrder, opens the widget via InAppBrowser.openAuth (or Linking.openURL fallback), parses the callback to fetch/add the resulting order, and resets navigation either back to BuildQuote or into RAMPS_ORDER_DETAILS.

Refactors amount entry handling into a shared updateAmount path and consolidates user-facing errors under rampsError using reportRampsError. Bootstrap is adjusted to run useRampsProviders on mount (replacing useHydrateRampsController), and tests are heavily rewritten/updated to cover the new routing, error, and callback/order-handling behavior.

^{Written by Cursor Bugbot for commit 10e9092. This will update automatically on new commits. Configure here.}

…lows

github-actions · 2026-03-11T15:20:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2026-03-11T15:20:15Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@metamask/ramps-controller@10.2.0 ⏵ 12.0.0			⁺¹	⁺¹

View full report

…/v2-custom-actions-codeonly

georgeweiler · 2026-03-11T17:26:12Z

@@ -167,21 +167,35 @@ const Checkout = () => {
  }, [uri, createEventBuilder, trackEvent, rampRoutingDecision]);

  useEffect(() => {


georgeweiler · 2026-03-11T17:26:29Z

-      errorCount: 0,
-    };
-    setCustomIdData(data);
-    dispatch(addFiatCustomIdData(data));


georgeweiler · 2026-03-11T19:07:02Z

@cursoragent please fix the ramp bootstrap test

…k/metamask-mobile into codex/v2-custom-actions-codeonly

…/v2-custom-actions-codeonly

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

cursor · 2026-03-17T00:41:26Z

+  status: RampsOrderStatus | undefined,
+): boolean {
+  return status != null && BAILED_ORDER_STATUSES.has(status);
+}


Exported isBailedOrderStatus only used internally in BuildQuote

Low Severity

isBailedOrderStatus and BAILED_ORDER_STATUSES are defined at module scope and exported, but grep shows they are only referenced within BuildQuote.tsx itself. The function and the Set constant are better placed in a utility file (e.g., alongside extractOrderCode or rampsNavigation) or kept unexported, since mixing domain utility logic with a React component's module top-level scope reduces cohesion and readability.

Additional Locations (1)

app/components/UI/Ramp/Views/BuildQuote/BuildQuote.tsx#L81-L86

…/v2-custom-actions-codeonly

github-actions · 2026-03-17T16:05:56Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
Risk Level: high
AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/ramps-controller. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/ramps-controller. Running all tests.

View GitHub Actions results

sonarqubecloud · 2026-03-17T16:33:11Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
81.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-03-17T16:48:24Z

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

feat(ramps): add custom action order handling for external checkout f…

e7a6978

…lows

georgeweiler requested review from a team as code owners March 11, 2026 15:19

Merge branch 'main' into codex/v2-custom-actions-codeonly

945ca9a

metamaskbot added the team-money-movement issues related to Money Movement features label Mar 11, 2026

github-actions Bot added the size-XL label Mar 11, 2026

cursor Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/BuildQuote/BuildQuote.tsx

georgeweiler added 2 commits March 11, 2026 09:22

fix: fixes conflicts with main branch

847eece

Merge branch 'main' of github.com:MetaMask/metamask-mobile into codex…

e929938

…/v2-custom-actions-codeonly

cursor Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/BuildQuote/BuildQuote.tsx

chore: remove unrelated non-ramps changes

f545770

cursor Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/BuildQuote/BuildQuote.tsx

georgeweiler commented Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/utils/openExternalBrowserCheckout.ts Outdated

fix: adds missing build quote tests

ec1e6c4

georgeweiler commented Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/BuildQuote/BuildQuote.tsx

georgeweiler commented Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/BuildQuote/BuildQuote.tsx Outdated

amitabh94 reviewed Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/Modals/PaymentSelectionModal/PaymentSelectionModal.tsx

amitabh94 reviewed Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/Modals/ProviderSelectionModal/ProviderSelection.tsx

georgeweiler commented Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/OrderDetails/OrderDetails.tsx Outdated

georgeweiler commented Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/RampsBootstrap.tsx

Merge branch 'main' of github.com:MetaMask/metamask-mobile into codex…

73a64e8

…/v2-custom-actions-codeonly

cursor Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/Modals/ProviderSelectionModal/ProviderSelection.tsx

feat: code review cleanup and refactoring

fc88521

cursor Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/RampsBootstrap.tsx

georgeweiler commented Mar 11, 2026

View reviewed changes

Merge branch 'codex/v2-custom-actions-codeonly' of github.com:MetaMas…

bf75b78

…k/metamask-mobile into codex/v2-custom-actions-codeonly

github-actions Bot added the risk-high Extensive testing required · High bug introduction risk label Mar 16, 2026

georgeweiler added 2 commits March 16, 2026 18:33

chore: test fix

aee82ce

Merge branch 'main' of github.com:MetaMask/metamask-mobile into codex…

784f2f7

…/v2-custom-actions-codeonly

github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Mar 17, 2026

cursor Bot reviewed Mar 17, 2026

View reviewed changes

chore: snapshots

d62af31

github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Mar 17, 2026

chore: increases build quote test coverage

2bb8457

github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Mar 17, 2026

Merge branch 'main' of github.com:MetaMask/metamask-mobile into codex…

376a1a6

…/v2-custom-actions-codeonly

github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Mar 17, 2026

Merge branch 'main' of github.com:MetaMask/metamask-mobile into codex…

10e9092

…/v2-custom-actions-codeonly

github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Mar 17, 2026

wachunei removed the request for review from a team March 17, 2026 17:21

wachunei approved these changes Mar 17, 2026

View reviewed changes

georgeweiler added this pull request to the merge queue Mar 17, 2026

Merged via the queue into main with commit fd6b85a Mar 17, 2026
109 of 110 checks passed

georgeweiler deleted the codex/v2-custom-actions-codeonly branch March 17, 2026 17:52

github-actions Bot locked and limited conversation to collaborators Mar 17, 2026

metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 17, 2026

		@@ -167,21 +167,35 @@ const Checkout = () => {
		}, [uri, createEventBuilder, trackEvent, rampRoutingDecision]);

		useEffect(() => {

Uh oh!

Conversation

georgeweiler commented Mar 11, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

socket-security Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

georgeweiler Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

georgeweiler Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

georgeweiler commented Mar 11, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Mar 17, 2026

Choose a reason for hiding this comment

Exported isBailedOrderStatus only used internally in BuildQuote

Uh oh!

github-actions Bot commented Mar 17, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented Mar 17, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

georgeweiler commented Mar 11, 2026 •

edited by cursor Bot

Loading

socket-security Bot commented Mar 11, 2026 •

edited

Loading

Exported `isBailedOrderStatus` only used internally in BuildQuote