Skip to content

chore(runway): cherry-pick fix: bump axios to 1.15.0 to resolve critical SSRF vulnerability#28717

Merged
chloeYue merged 3 commits into
release/7.72.1from
runway-cherry-pick-7.72.1-1776068390
Apr 13, 2026
Merged

chore(runway): cherry-pick fix: bump axios to 1.15.0 to resolve critical SSRF vulnerability#28717
chloeYue merged 3 commits into
release/7.72.1from
runway-cherry-pick-7.72.1-1776068390

Conversation

@runway-github

@runway-github runway-github Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Description

CI is failing on yarn audit:ci due to a critical severity advisory
(GHSA-3p68-rc4w-qgx5)
in axios < 1.15.0. The vulnerability allows an attacker to bypass
NO_PROXY hostname normalization, leading to SSRF.

This PR bumps axios from 1.13.5 to 1.15.0 across dependencies,
resolutions, and the CI scripts package. Because 1.15.0 was published
less than 3 days ago, it is also temporarily added to
npmPreapprovedPackages in .yarnrc.yml to bypass the
npmMinimalAgeGate. This preapproval entry should be removed after
2025-04-12.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Updates a widely used HTTP client to remediate a critical SSRF
advisory; moderate risk due to potential subtle networking/proxy
behavior changes across the app and CI scripts.

Overview
Bumps axios from ^1.13.5 to ^1.15.0 across the repo (app
dependencies, resolutions, and the .github/scripts workspace) to
address the flagged security advisory.

Updates both lockfiles to the new axios and its transitive
proxy-from-env@^2.1.0, and temporarily adds axios to .yarnrc.yml
npmPreapprovedPackages to bypass the 3-day npmMinimalAgeGate for
this release.

Reviewed by Cursor Bugbot for commit
34350ca. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[f8a6fb8](https://github.com/MetaMask/metamask-mobile/commit/f8a6fb8f556cc10f408b780ca98317e76dfbc04c)

…cal SSRF vulnerability (#28620)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

CI is failing on `yarn audit:ci` due to a critical severity advisory
([GHSA-3p68-rc4w-qgx5](GHSA-3p68-rc4w-qgx5))
in axios < 1.15.0. The vulnerability allows an attacker to bypass
`NO_PROXY` hostname normalization, leading to SSRF.

This PR bumps axios from 1.13.5 to 1.15.0 across `dependencies`,
`resolutions`, and the CI scripts package. Because 1.15.0 was published
less than 3 days ago, it is also temporarily added to
`npmPreapprovedPackages` in `.yarnrc.yml` to bypass the
`npmMinimalAgeGate`. This preapproval entry should be removed after
2025-04-12.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Updates a widely used HTTP client to remediate a critical SSRF
advisory; moderate risk due to potential subtle networking/proxy
behavior changes across the app and CI scripts.
> 
> **Overview**
> **Bumps `axios` from `^1.13.5` to `^1.15.0` across the repo** (app
`dependencies`, `resolutions`, and the `.github/scripts` workspace) to
address the flagged security advisory.
> 
> Updates both lockfiles to the new `axios` and its transitive
`proxy-from-env@^2.1.0`, and temporarily adds `axios` to `.yarnrc.yml`
`npmPreapprovedPackages` to bypass the 3-day `npmMinimalAgeGate` for
this release.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
34350ca. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner April 13, 2026 08:19
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Apr 13, 2026
@github-actions github-actions Bot added size-XS risk-low Low testing needed · Low bug introduction risk labels Apr 13, 2026

@chloeYue chloeYue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​xmldom/​xmldom@​0.8.11 ⏵ 0.8.1299100 +16100 +188 +38100

View full report

@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeRamps, SmokeCard, SmokeNetworkAbstractions
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR contains only dependency version bumps:

  1. axios ^1.13.5 → ^1.15.0 in both the main app and GitHub CI scripts
  2. @xmldom/xmldom ^0.8.10 → ^0.8.12 (patch bump)
  3. proxy-from-env ^1.1.0 → ^2.1.0 (transitive dependency of axios, major version bump)
  4. .yarnrc.yml adds axios to npmPreapprovedPackages temporarily

No application logic was changed. These are library version updates.

Impact analysis:

  • axios is used in: Ramp/Deposit hooks (SmokeRamps), Card controller BaanxService (SmokeCard), networkChecker.util (SmokeNetworkAbstractions), and E2E test infrastructure (FixtureHelper, e2eCommandPolling, e2eStateExport)
  • @xmldom/xmldom is a minor patch bump with no breaking changes expected
  • proxy-from-env major bump (1→2) is a transitive dep of axios; axios 1.15.0 handles this internally

Test selection rationale:

  • SmokeRamps: axios is directly used in Ramp/Deposit hooks (useDepositRouting, useDepositUser)
  • SmokeCard: axios is directly used in BaanxService (card controller service layer)
  • SmokeNetworkAbstractions: axios is used in networkChecker.util which validates RPC network connections

The E2E test infrastructure (FixtureHelper) also uses axios, but this is the test runner itself - if it were broken, all tests would fail. Running a targeted subset validates the axios upgrade works correctly in the app's key HTTP-dependent flows.

No performance tests are needed as these are dependency version bumps with no UI rendering, state management, or initialization changes.

Performance Test Selection:
These changes are purely dependency version bumps (axios, xmldom, proxy-from-env). There are no UI rendering changes, no state management changes, no controller initialization changes, and no critical path modifications that would affect app performance metrics. Performance tests are not warranted.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@chloeYue chloeYue merged commit c1085e7 into release/7.72.1 Apr 13, 2026
79 of 81 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.72.1-1776068390 branch April 13, 2026 09:07
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-low Low testing needed · Low bug introduction risk size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants