Skip to content

fix: bump axios to 1.15.0 to resolve critical SSRF vulnerability#28620

Merged
weitingsun merged 2 commits into
mainfrom
wsun/upgrade-axios-to-fix-ci-audit
Apr 9, 2026
Merged

fix: bump axios to 1.15.0 to resolve critical SSRF vulnerability#28620
weitingsun merged 2 commits into
mainfrom
wsun/upgrade-axios-to-fix-ci-audit

Conversation

@weitingsun

@weitingsun weitingsun commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Description

CI is failing on yarn audit:ci due to a critical severity advisory (GHSA-3p68-rc4w-qgx5) in axios < 1.15.0. The vulnerability allows an attacker to bypass NO_PROXY hostname normalization, leading to SSRF.

This PR bumps axios from 1.13.5 to 1.15.0 across dependencies, resolutions, and the CI scripts package. Because 1.15.0 was published less than 3 days ago, it is also temporarily added to npmPreapprovedPackages in .yarnrc.yml to bypass the npmMinimalAgeGate. This preapproval entry should be removed after 2025-04-12.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Updates a widely used HTTP client to remediate a critical SSRF advisory; moderate risk due to potential subtle networking/proxy behavior changes across the app and CI scripts.

Overview
Bumps axios from ^1.13.5 to ^1.15.0 across the repo (app dependencies, resolutions, and the .github/scripts workspace) to address the flagged security advisory.

Updates both lockfiles to the new axios and its transitive proxy-from-env@^2.1.0, and temporarily adds axios to .yarnrc.yml npmPreapprovedPackages to bypass the 3-day npmMinimalAgeGate for this release.

Reviewed by Cursor Bugbot for commit 34350ca. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 9, 2026
@weitingsun weitingsun requested review from Cal-L and tommasini April 9, 2026 19:28
@weitingsun weitingsun self-assigned this Apr 9, 2026
@weitingsun weitingsun marked this pull request as ready for review April 9, 2026 19:28
@weitingsun weitingsun requested a review from a team as a code owner April 9, 2026 19:28
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@weitingsun weitingsun enabled auto-merge April 9, 2026 19:33
@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2026

Copy link
Copy Markdown

@joaoloureirop joaoloureirop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@weitingsun weitingsun added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit f8a6fb8 Apr 9, 2026
208 of 210 checks passed
@weitingsun weitingsun deleted the wsun/upgrade-axios-to-fix-ci-audit branch April 9, 2026 21:29
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants