Skip to content

chore:cherry pick 28490#28556

Merged
tommasini merged 1 commit into
release/7.73.0from
chore/cherry-pick-28490
Apr 8, 2026
Merged

chore:cherry pick 28490#28556
tommasini merged 1 commit into
release/7.73.0from
chore/cherry-pick-28490

Conversation

@tommasini

@tommasini tommasini commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Description

cherry pick #28490

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are limited to the Slack RC notification script’s environment-variable inputs and payload field naming, with no impact on app/runtime code. Main risk is missing notifications if CI still sets legacy vars (BUILD_NUMBER/BITRISE_PIPELINE_URL).

Overview
Simplifies scripts/slack-rc-notification.mjs to require explicit IOS_BUILD_NUMBER/ANDROID_BUILD_NUMBER and a single BUILD_PIPELINE_URL, removing fallbacks to BUILD_NUMBER and BITRISE_PIPELINE_URL.

Cleans up naming by passing pipelineUrl through buildSlackMessage (instead of bitriseUrl) and updates the script’s env-var documentation accordingly.

Reviewed by Cursor Bugbot for commit 4ace38b. Bugbot is set up for automated code reviews on this repo. Configure here.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: small, isolated changes to a notification script that only
affect Slack message metadata and optional links based on environment
variables.
> 
> **Overview**
> Updates `scripts/slack-rc-notification.mjs` to **standardize
environment inputs**: it now requires explicit
`IOS_BUILD_NUMBER`/`ANDROID_BUILD_NUMBER` (no fallback to
`BUILD_NUMBER`) and only uses `BUILD_PIPELINE_URL` (drops
`BITRISE_PIPELINE_URL`).
> 
> Renames the message option from `bitriseUrl` to `pipelineUrl` so the
Slack payload construction matches the updated pipeline URL source.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
b57d338. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 8, 2026
@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Apr 8, 2026
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is scripts/slack-rc-notification.mjs, which is a CI/release notification script that sends Slack messages about release candidates. The changes are:

  1. Removing the fallback to a generic BUILD_NUMBER env var in favor of requiring explicit IOS_BUILD_NUMBER and ANDROID_BUILD_NUMBER
  2. Removing the fallback to BITRISE_PIPELINE_URL (migrating from Bitrise to GitHub Actions pipeline URL)
  3. Renaming the bitriseUrl property to pipelineUrl in the message builder

This is purely a CI notification infrastructure change with zero impact on:

  • App source code or functionality
  • E2E test flows or user-facing features
  • Performance characteristics
  • Test infrastructure (no changes to test files, fixtures, or page objects)

No E2E tests need to run for this change. It's a low-risk, isolated script modification.

Performance Test Selection:
The change is limited to a Slack notification script for release candidates. There is no app code, UI component, controller, or data loading change that could affect performance metrics.

View GitHub Actions results

@github-actions github-actions Bot added the size-S label Apr 8, 2026
@tommasini tommasini changed the title chore: slack rc mjs cleanup (#28490) chore:cherry pick 28490 Apr 8, 2026
@tommasini tommasini merged commit dac8f5a into release/7.73.0 Apr 8, 2026
49 of 63 checks passed
@tommasini tommasini deleted the chore/cherry-pick-28490 branch April 8, 2026 17:22
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-low Low testing needed · Low bug introduction risk size-S team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants