Skip to content

chore: slack rc mjs cleanup#28490

Merged
tommasini merged 9 commits into
mainfrom
chore/slack-rc-mjs-cleanup
Apr 7, 2026
Merged

chore: slack rc mjs cleanup#28490
tommasini merged 9 commits into
mainfrom
chore/slack-rc-mjs-cleanup

Conversation

@tommasini

@tommasini tommasini commented Apr 7, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: small, isolated changes to a notification script that only affect Slack message metadata and optional links based on environment variables.

Overview
Updates scripts/slack-rc-notification.mjs to standardize environment inputs: it now requires explicit IOS_BUILD_NUMBER/ANDROID_BUILD_NUMBER (no fallback to BUILD_NUMBER) and only uses BUILD_PIPELINE_URL (drops BITRISE_PIPELINE_URL).

Renames the message option from bitriseUrl to pipelineUrl so the Slack payload construction matches the updated pipeline URL source.

Reviewed by Cursor Bugbot for commit b57d338. Bugbot is set up for automated code reviews on this repo. Configure here.

tommasini and others added 8 commits April 6, 2026 20:01
@tommasini
rc auto create script now using runway-ota-build-core.ym
cfdf178
@tommasini
chore: update post-rc-build-comment.mjs to remove Bitrise references
6f719fa 
Replace BITRISE_PIPELINE_URL with BUILD_PIPELINE_URL and handle missing
Android public URL gracefully by linking to the CI pipeline run instead
of hard-failing.

Made-with: Cursor
@tommasini
remove upload_testflight input
5c705f5
@tommasini
chore: extract build metadata into reusable script
d598f25 
Add scripts/get-build-metadata.sh as the single source of truth for
reading android_version_code, ios_version_code, and semantic_version
from the repo tree. All three consumers now call this script:

- build.yml (emit-build-metadata job)
- build-rc-auto.yml (post-rc-build-comment job)
- build-rc-create.yml (post-slack-notification job)

Both iOS and Android build numbers are now passed through to the
PR comment and Slack notification scripts, replacing the previous
single BUILD_NUMBER. Bitrise references in slack-rc-notification.mjs
are replaced with BUILD_PIPELINE_URL.

Made-with: Cursor
@tommasini
chore: add clarifying comment on skip_version_bump in build-rc-auto
dded073 
Made-with: Cursor
@tommasini
Merge branch 'main' into chore/rc-auto-create-with-gh-actions
b9e49c5
@tommasini
abstract slack notification, add it to the rc workflows and delete bu…
1d8441f 
…ild-rc-create
@tommasini
cleanup of slack rc mjs script cleanuo
eae3a18
@tommasini tommasini requested a review from a team as a code owner April 7, 2026 18:25
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 7, 2026
@github-actions github-actions Bot added size-M risk-low Low testing needed · Low bug introduction risk labels Apr 7, 2026
@github-actions github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk and removed size-M risk-low Low testing needed · Low bug introduction risk labels Apr 7, 2026
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is scripts/slack-rc-notification.mjs, a Slack notification script used during release candidate builds. The changes are:

  1. Removing the fallback to a generic BUILD_NUMBER env var in favor of explicit IOS_BUILD_NUMBER and ANDROID_BUILD_NUMBER
  2. Removing the fallback to BITRISE_PIPELINE_URL (migrating from Bitrise to GitHub Actions pipeline URL)
  3. Renaming the bitriseUrl property to pipelineUrl in the message builder

These are purely CI/release notification infrastructure changes with zero impact on app code, user flows, E2E test infrastructure, or performance. No E2E tests need to run for this change.

Performance Test Selection:
The change is limited to a Slack notification script for release candidate builds. There is no app code, UI rendering, state management, or performance-sensitive code affected. No performance tests are needed.

View GitHub Actions results

Cal-L
Cal-L approved these changes Apr 7, 2026
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini enabled auto-merge April 7, 2026 18:55
@sonarqubecloud

sonarqubecloud Bot commented Apr 7, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tommasini tommasini added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 7, 2026
@tommasini tommasini added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 825f0d9 Apr 7, 2026
67 of 68 checks passed
@tommasini tommasini deleted the chore/slack-rc-mjs-cleanup branch April 7, 2026 20:02
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 7, 2026
@weitingsun weitingsun added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-low Low testing needed · Low bug introduction risk size-S team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tommasini @Cal-L @metamaskbot @weitingsun