cherry pick 28368#28535
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e97b59a. Configure here.
| message: ${{ needs.decide.outputs.ota_version }} | ||
| channel: ${{ inputs.ota_channel }} | ||
| platform: ${{ inputs.platform }} | ||
| secrets: inherit |
There was a problem hiding this comment.
Reusable workflow call targets workflow lacking workflow_call trigger
High Severity
The trigger-ota job calls push-eas-update.yml as a reusable workflow via job-level uses:, but that workflow only defines on: workflow_dispatch: — it has no workflow_call trigger. GitHub Actions requires reusable workflows to declare on: workflow_call: with matching inputs. Without it, the job will fail at workflow resolution time, completely breaking the OTA update pipeline. The previous approach dispatched the workflow via actions/github-script (createWorkflowDispatch), which targeted workflow_dispatch and worked fine.
Reviewed by Cursor Bugbot for commit e97b59a. Configure here.
|
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
This change has zero impact on:
It only affects the OTA (Over-The-Air) build/release pipeline workflow. No E2E tests need to run to validate this CI-only change. Performance Test Selection: |
Description
Cherry pick #28368
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes release automation control flow for OTA updates and production tag creation; misconfiguration could block or mis-trigger OTA deployments in CI.
Overview
Updates
runway-ota-build-core.ymlto invoke the OTA publisher as a job-level reusable workflow (uses: ./.github/workflows/push-eas-update.yml) instead of an invalid step-level call.Adds a
validate-ota-prgate that hard-fails OTA runs when no PR number can be resolved, and simplifies production tag creation to usedecide.outputs.ota_versiondirectly (removing the priorrelease_tagoutput wiring).Reviewed by Cursor Bugbot for commit 179c16b. Bugbot is set up for automated code reviews on this repo. Configure here.