Skip to content

ci: fix Runway OTA core workflow reusable job layout#28368

Merged
weitingsun merged 1 commit into
mainfrom
wsun/fix-runway-workflow
Apr 3, 2026
Merged

ci: fix Runway OTA core workflow reusable job layout#28368
weitingsun merged 1 commit into
mainfrom
wsun/fix-runway-workflow

Conversation

@weitingsun

@weitingsun weitingsun commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Description

The trigger-ota job mixed shell steps with a reusable workflow (uses: ./.github/workflows/push-eas-update.yml). In GitHub Actions, a job must either define steps: or call another workflow with job-level uses:, not both.
This splits that into:

  1. validate-ota-pr — Validates a PR number exists before OTA (same guard as before).
  2. trigger-ota — Only calls push-eas-update.yml, with secrets: inherit for caller secrets.
    create-ota-production-tag now sets tag_name from needs.decide.outputs.ota_version (same value the old release_tag step echoed). It still needs: trigger-ota so tagging runs only after the OTA workflow finishes.

successful workflow run: https://github.com/MetaMask/metamask-mobile/actions/runs/23923283109

Changelog

CHANGELOG entry:null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes the job graph for Runway OTA publishing/tagging; misconfigured needs/uses/secrets inheritance could block OTA releases or trigger the wrong follow-up jobs.

Overview
Fixes runway-ota-build-core.yml to correctly invoke the reusable push-eas-update.yml workflow as a job-level uses: instead of mixing it with steps:.

Adds a separate validate-ota-pr job to guard OTA runs when no PR number is resolvable, updates trigger-ota to inherit secrets, and adjusts production tagging to use needs.decide.outputs.ota_version directly (removing the intermediate release_tag output).

Written by Cursor Bugbot for commit 92b5c4c. This will update automatically on new commits. Configure here.

@weitingsun weitingsun requested a review from a team as a code owner April 2, 2026 22:21
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 2, 2026
@github-actions github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk labels Apr 2, 2026
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is .github/workflows/runway-ota-build-core.yml, which is a GitHub Actions CI/CD workflow for OTA (Over-The-Air) builds. The changes are purely structural CI refactoring:

  1. Splits the trigger-ota job into two jobs: validate-ota-pr (for PR validation) and trigger-ota (now a proper reusable workflow call using uses: at job level)
  2. Fixes the reusable workflow invocation - GitHub Actions requires uses: at the job level, not as a step; this was a structural bug fix
  3. Adds secrets: inherit to pass secrets to the reusable workflow
  4. Updates create-ota-production-tag to source tag_name from needs.decide.outputs.ota_version instead of the removed job output

This change has zero impact on:

  • Application source code
  • E2E test flows
  • UI components
  • Controllers or Engine
  • Any user-facing functionality

No E2E tests need to run for this pure CI infrastructure change.

Performance Test Selection:
This is a pure CI/CD workflow change with no impact on app code, rendering, state management, or any performance-sensitive paths. No performance tests are needed.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Apr 2, 2026

Copy link
Copy Markdown

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@weitingsun weitingsun added this pull request to the merge queue Apr 3, 2026
Merged via the queue into main with commit 366e9cc Apr 3, 2026
118 checks passed
@weitingsun weitingsun deleted the wsun/fix-runway-workflow branch April 3, 2026 01:18
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2026
@weitingsun weitingsun added release-7.74.0 Issue or pull request that will be included in release 7.74.0 and removed release-99999.1.0 labels Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-low Low testing needed · Low bug introduction risk size-S team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants