ci: fix Runway OTA core workflow reusable job layout#28368
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
This change has zero impact on:
No E2E tests need to run for this pure CI infrastructure change. Performance Test Selection: |
|



Description
The
trigger-otajob mixed shell steps with a reusable workflow (uses: ./.github/workflows/push-eas-update.yml). In GitHub Actions, a job must either definesteps:or call another workflow with job-leveluses:, not both.This splits that into:
validate-ota-pr— Validates a PR number exists before OTA (same guard as before).trigger-ota— Only callspush-eas-update.yml, withsecrets: inheritfor caller secrets.create-ota-production-tagnow setstag_namefromneeds.decide.outputs.ota_version(same value the oldrelease_tagstep echoed). It stillneeds: trigger-otaso tagging runs only after the OTA workflow finishes.successful workflow run: https://github.com/MetaMask/metamask-mobile/actions/runs/23923283109
Changelog
CHANGELOG entry:null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes the job graph for Runway OTA publishing/tagging; misconfigured
needs/uses/secrets inheritance could block OTA releases or trigger the wrong follow-up jobs.Overview
Fixes
runway-ota-build-core.ymlto correctly invoke the reusablepush-eas-update.ymlworkflow as a job-leveluses:instead of mixing it withsteps:.Adds a separate
validate-ota-prjob to guard OTA runs when no PR number is resolvable, updatestrigger-otato inherit secrets, and adjusts production tagging to useneeds.decide.outputs.ota_versiondirectly (removing the intermediaterelease_tagoutput).Written by Cursor Bugbot for commit 92b5c4c. This will update automatically on new commits. Configure here.