Skip to content

chore(runway): cherry-pick 6334093#28523

Merged
tommasini merged 2 commits into
release/7.73.0from
runway-cherry-pick-7.73.0-1775650353
Apr 8, 2026
Merged

chore(runway): cherry-pick 6334093#28523
tommasini merged 2 commits into
release/7.73.0from
runway-cherry-pick-7.73.0-1775650353

Conversation

@runway-github

@runway-github runway-github Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Description

The upload-to-testflight.yml workflow had opaque summary_* prefixed
inputs that made it hard to understand what each value represented. The
build.yml workflow also lacked an iOS build number output, forcing
callers to use the Android version code as a proxy.

This PR:

  • Renames summary_* inputs in upload-to-testflight.yml to clearer
    names (build_version, build_number, build_commit_sha,
    source_branch, build_branch)
  • Adds ios_version_code as a new output from build.yml, extracted
    from the Xcode project's CURRENT_PROJECT_VERSION
  • Updates all callers (build-and-upload-to-testflight.yml,
    runway-ota-build-core.yml) to use the renamed inputs
  • Removes a leftover debug step from runway-ota-build-core.yml
  • Removes redundant fallback defaults in the upload script call (callers
    already provide defaults)

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A — CI workflow changes only. Verify by triggering the
build-and-upload-to-testflight or runway-ota-build-core workflows
and checking that the step summary displays the correct build metadata
fields.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Made with Cursor


Note

Medium Risk
CI/release workflow wiring changed for TestFlight uploads and build
metadata; mis-mapped inputs or parsing failures could break release
automation even though no app runtime code is touched.

Overview
Simplifies the reusable upload-to-testflight.yml interface by
replacing opaque summary_* inputs with explicit source_branch,
build_branch, build_commit_sha, build_version, and build_number,
and updates the step summary to match.

Extends build.yml to emit an ios_version_code output by parsing
Xcode’s CURRENT_PROJECT_VERSION, and updates TestFlight callers
(build-and-upload-to-testflight.yml, runway-ota-build-core.yml) to
pass the new fields and use the iOS build number instead of Android’s.

Removes a debug step from runway-ota-build-core.yml and drops
redundant default fallbacks when invoking
scripts/upload-to-testflight.sh (workflow inputs already provide
defaults).

Written by Cursor
Bugbot
for commit
08245a8. This will update automatically
on new commits. Configure
here.


Co-authored-by: Cal-L cal.leung@consensys.net 6334093

…d iOS build number (#28375)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

The `upload-to-testflight.yml` workflow had opaque `summary_*` prefixed
inputs that made it hard to understand what each value represented. The
`build.yml` workflow also lacked an iOS build number output, forcing
callers to use the Android version code as a proxy.

This PR:
- Renames `summary_*` inputs in `upload-to-testflight.yml` to clearer
names (`build_version`, `build_number`, `build_commit_sha`,
`source_branch`, `build_branch`)
- Adds `ios_version_code` as a new output from `build.yml`, extracted
from the Xcode project's `CURRENT_PROJECT_VERSION`
- Updates all callers (`build-and-upload-to-testflight.yml`,
`runway-ota-build-core.yml`) to use the renamed inputs
- Removes a leftover debug step from `runway-ota-build-core.yml`
- Removes redundant fallback defaults in the upload script call (callers
already provide defaults)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

N/A — CI workflow changes only. Verify by triggering the
`build-and-upload-to-testflight` or `runway-ota-build-core` workflows
and checking that the step summary displays the correct build metadata
fields.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- Generated with the help of the pr-description AI skill -->

Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> CI/release workflow wiring changed for TestFlight uploads and build
metadata; mis-mapped inputs or parsing failures could break release
automation even though no app runtime code is touched.
> 
> **Overview**
> Simplifies the reusable `upload-to-testflight.yml` interface by
replacing opaque `summary_*` inputs with explicit `source_branch`,
`build_branch`, `build_commit_sha`, `build_version`, and `build_number`,
and updates the step summary to match.
> 
> Extends `build.yml` to emit an `ios_version_code` output by parsing
Xcode’s `CURRENT_PROJECT_VERSION`, and updates TestFlight callers
(`build-and-upload-to-testflight.yml`, `runway-ota-build-core.yml`) to
pass the new fields and use the iOS build number instead of Android’s.
> 
> Removes a debug step from `runway-ota-build-core.yml` and drops
redundant default fallbacks when invoking
`scripts/upload-to-testflight.sh` (workflow inputs already provide
defaults).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
08245a8. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cal-L <cal.leung@consensys.net>
@runway-github runway-github Bot requested review from a team as code owners April 8, 2026 12:13
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Apr 8, 2026
@github-actions github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk labels Apr 8, 2026
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 4 changed files are GitHub Actions workflow files related to the build and TestFlight upload pipeline:

  1. build.yml: Adds ios_version_code output by extracting CURRENT_PROJECT_VERSION from the Xcode project file. No app code changes.

  2. upload-to-testflight.yml: Refactors input parameter names (e.g., summary_logical_source_branchsource_branch, summary_android_version_codebuild_number), adds a build_branch parameter, and cleans up fallback expressions. Pure interface cleanup.

  3. build-and-upload-to-testflight.yml: Updates callers to use the new parameter names from upload-to-testflight.yml, and passes ios_version_code as build_number.

  4. runway-ota-build-core.yml: Removes a debug logging step and updates parameter names to match the refactored upload-to-testflight.yml interface.

These are purely CI/CD infrastructure changes affecting the build artifact upload pipeline to TestFlight. They do not touch:

  • Any application source code
  • Any E2E test files or test infrastructure
  • Any controllers, Engine, or core modules
  • Any UI components or navigation

No E2E test tags are warranted because no app functionality has changed. No performance tests are needed as no performance-sensitive code was modified.

Performance Test Selection:
No application code, UI components, or performance-sensitive paths were modified. All changes are confined to GitHub Actions workflow files for build and TestFlight upload pipelines.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Apr 8, 2026

Copy link
Copy Markdown

@tommasini tommasini enabled auto-merge (squash) April 8, 2026 17:06
@tommasini tommasini disabled auto-merge April 8, 2026 17:06
@tommasini tommasini merged commit f69bf23 into release/7.73.0 Apr 8, 2026
22 of 35 checks passed
@tommasini tommasini deleted the runway-cherry-pick-7.73.0-1775650353 branch April 8, 2026 17:06
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-low Low testing needed · Low bug introduction risk size-S team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants