chore(runway): cherry-pick 6334093#28523
Conversation
…d iOS build number (#28375) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The `upload-to-testflight.yml` workflow had opaque `summary_*` prefixed inputs that made it hard to understand what each value represented. The `build.yml` workflow also lacked an iOS build number output, forcing callers to use the Android version code as a proxy. This PR: - Renames `summary_*` inputs in `upload-to-testflight.yml` to clearer names (`build_version`, `build_number`, `build_commit_sha`, `source_branch`, `build_branch`) - Adds `ios_version_code` as a new output from `build.yml`, extracted from the Xcode project's `CURRENT_PROJECT_VERSION` - Updates all callers (`build-and-upload-to-testflight.yml`, `runway-ota-build-core.yml`) to use the renamed inputs - Removes a leftover debug step from `runway-ota-build-core.yml` - Removes redundant fallback defaults in the upload script call (callers already provide defaults) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** N/A — CI workflow changes only. Verify by triggering the `build-and-upload-to-testflight` or `runway-ota-build-core` workflows and checking that the step summary displays the correct build metadata fields. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Generated with the help of the pr-description AI skill --> Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > CI/release workflow wiring changed for TestFlight uploads and build metadata; mis-mapped inputs or parsing failures could break release automation even though no app runtime code is touched. > > **Overview** > Simplifies the reusable `upload-to-testflight.yml` interface by replacing opaque `summary_*` inputs with explicit `source_branch`, `build_branch`, `build_commit_sha`, `build_version`, and `build_number`, and updates the step summary to match. > > Extends `build.yml` to emit an `ios_version_code` output by parsing Xcode’s `CURRENT_PROJECT_VERSION`, and updates TestFlight callers (`build-and-upload-to-testflight.yml`, `runway-ota-build-core.yml`) to pass the new fields and use the iOS build number instead of Android’s. > > Removes a debug step from `runway-ota-build-core.yml` and drops redundant default fallbacks when invoking `scripts/upload-to-testflight.sh` (workflow inputs already provide defaults). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 08245a8. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Cal-L <cal.leung@consensys.net>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
These are purely CI/CD infrastructure changes affecting the build artifact upload pipeline to TestFlight. They do not touch:
No E2E test tags are warranted because no app functionality has changed. No performance tests are needed as no performance-sensitive code was modified. Performance Test Selection: |
|



Description
The
upload-to-testflight.ymlworkflow had opaquesummary_*prefixedinputs that made it hard to understand what each value represented. The
build.ymlworkflow also lacked an iOS build number output, forcingcallers to use the Android version code as a proxy.
This PR:
summary_*inputs inupload-to-testflight.ymlto clearernames (
build_version,build_number,build_commit_sha,source_branch,build_branch)ios_version_codeas a new output frombuild.yml, extractedfrom the Xcode project's
CURRENT_PROJECT_VERSIONbuild-and-upload-to-testflight.yml,runway-ota-build-core.yml) to use the renamed inputsrunway-ota-build-core.ymlalready provide defaults)
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
N/A — CI workflow changes only. Verify by triggering the
build-and-upload-to-testflightorrunway-ota-build-coreworkflowsand checking that the step summary displays the correct build metadata
fields.
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Made with Cursor
Note
Medium Risk
CI/release workflow wiring changed for TestFlight uploads and build
metadata; mis-mapped inputs or parsing failures could break release
automation even though no app runtime code is touched.
Overview
Simplifies the reusable
upload-to-testflight.ymlinterface byreplacing opaque
summary_*inputs with explicitsource_branch,build_branch,build_commit_sha,build_version, andbuild_number,and updates the step summary to match.
Extends
build.ymlto emit anios_version_codeoutput by parsingXcode’s
CURRENT_PROJECT_VERSION, and updates TestFlight callers(
build-and-upload-to-testflight.yml,runway-ota-build-core.yml) topass the new fields and use the iOS build number instead of Android’s.
Removes a debug step from
runway-ota-build-core.ymland dropsredundant default fallbacks when invoking
scripts/upload-to-testflight.sh(workflow inputs already providedefaults).
Written by Cursor
Bugbot for commit
08245a8. This will update automatically
on new commits. Configure
here.
Co-authored-by: Cal-L cal.leung@consensys.net 6334093